Re: [PATCH v2 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt()

From: Li Qiang <liq3ea@gmail.com>
To: Chen Qun <kuhn.chenqun@huawei.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
	qemu-trivial@nongnu.org, Pan Nengyuan <pannengyuan@huawei.com>,
	Qemu Developers <qemu-devel@nongnu.org>,
	Eric Auger <eric.auger@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Euler Robot <euler.robot@huawei.com>
Subject: Re: [PATCH v2 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt()
Date: Wed, 26 Aug 2020 09:38:06 +0800	[thread overview]
Message-ID: <CAKXe6S+BBKztHmBG0TLRTJH6bDntyz4=mWpgccctaZgYWn_TdA@mail.gmail.com> (raw)
In-Reply-To: <20200825112447.126308-8-kuhn.chenqun@huawei.com>

Chen Qun <kuhn.chenqun@huawei.com> 于2020年8月25日周二 下午7:31写道：
>
> Clang static code analyzer show warning:
> hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read
>         ret = event_notifier_test_and_clear(intp->interrupt);
>         ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> ---
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Eric Auger <eric.auger@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  hw/vfio/platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
> index ac2cefc9b1..869ed2c39d 100644
> --- a/hw/vfio/platform.c
> +++ b/hw/vfio/platform.c
> @@ -236,7 +236,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp)
>          trace_vfio_intp_interrupt_set_pending(intp->pin);
>          QSIMPLEQ_INSERT_TAIL(&vdev->pending_intp_queue,
>                               intp, pqnext);
> -        ret = event_notifier_test_and_clear(intp->interrupt);

Shouldn't we check the 'ret' like the other place in this function?

Thanks,
Li Qiang

> +        event_notifier_test_and_clear(intp->interrupt);
>          return;
>      }
>
> --
> 2.23.0
>
>