From: Li Qiang <liq3ea@gmail.com>
To: Chen Qun <kuhn.chenqun@huawei.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org, Pan Nengyuan <pannengyuan@huawei.com>,
Qemu Developers <qemu-devel@nongnu.org>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
qemu-arm@nongnu.org, Euler Robot <euler.robot@huawei.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH v2 01/10] hw/arm/virt-acpi-build:Remove dead assignment in build_madt()
Date: Wed, 26 Aug 2020 09:25:10 +0800 [thread overview]
Message-ID: <CAKXe6SLQ2AxeW-eK3Mc+Z81LYM0qPhUXorrytZ54=S7GQgrjhQ@mail.gmail.com> (raw)
In-Reply-To: <20200825112447.126308-2-kuhn.chenqun@huawei.com>
Chen Qun <kuhn.chenqun@huawei.com> 于2020年8月25日周二 下午7:26写道：
>
> Clang static code analyzer show warning:
> hw/arm/virt-acpi-build.c:641:5: warning: Value stored to 'madt' is never read
> madt = acpi_data_push(table_data, sizeof *madt);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> Cc: Shannon Zhao <shannon.zhaosl@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: qemu-arm@nongnu.org
> ---
> hw/arm/virt-acpi-build.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index 91f0df7b13..f830f9b779 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -633,12 +633,11 @@ build_madt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
> int madt_start = table_data->len;
> const MemMapEntry *memmap = vms->memmap;
> const int *irqmap = vms->irqmap;
> - AcpiMultipleApicTable *madt;
> AcpiMadtGenericDistributor *gicd;
> AcpiMadtGenericMsiFrame *gic_msi;
> int i;
>
> - madt = acpi_data_push(table_data, sizeof *madt);
> + acpi_data_push(table_data, sizeof(AcpiMultipleApicTable));
>
> gicd = acpi_data_push(table_data, sizeof *gicd);
> gicd->type = ACPI_APIC_GENERIC_DISTRIBUTOR;
> --
> 2.23.0
>
>
next prev parent reply other threads:[~2020-08-26 1:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 11:24 [PATCH v2 00/10] trivial patchs for static code analyzer fixes Chen Qun
2020-08-25 11:24 ` [PATCH v2 01/10] hw/arm/virt-acpi-build:Remove dead assignment in build_madt() Chen Qun
2020-08-26 1:25 ` Li Qiang [this message]
2020-08-25 11:24 ` [PATCH v2 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read() Chen Qun
2020-08-25 12:35 ` Peter Maydell
2020-08-26 1:26 ` Li Qiang
2020-08-25 11:24 ` [PATCH v2 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli() Chen Qun
2020-08-25 12:37 ` Peter Maydell
2020-08-26 2:42 ` Chenqun (kuhn)
2020-08-25 11:24 ` [PATCH v2 04/10] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16() Chen Qun
2020-08-25 12:38 ` Peter Maydell
2020-08-25 11:24 ` [PATCH v2 05/10] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions() Chen Qun
2020-08-26 10:23 ` Li Qiang
2020-08-25 11:24 ` [PATCH v2 06/10] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check() Chen Qun
2020-08-26 1:35 ` Li Qiang
2020-08-25 11:24 ` [PATCH v2 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt() Chen Qun
2020-08-25 15:00 ` Stefan Hajnoczi
2020-08-26 1:38 ` Li Qiang
2020-08-26 1:47 ` Chenqun (kuhn)
2020-08-26 10:14 ` Li Qiang
2020-08-25 11:24 ` [PATCH v2 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path() Chen Qun
2020-08-25 14:39 ` Markus Armbruster
2020-08-26 1:59 ` Chenqun (kuhn)
2020-08-26 2:25 ` Chenqun (kuhn)
2020-08-25 11:24 ` [PATCH v2 09/10] hw/intc: Remove redundant statement in exynos4210_combiner_read() Chen Qun
2020-08-25 12:41 ` Peter Maydell
2020-08-27 7:00 ` Chenqun (kuhn)
2020-08-27 9:28 ` Peter Maydell
2020-08-25 11:24 ` [PATCH v2 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic() Chen Qun
2020-08-26 1:54 ` Li Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKXe6SLQ2AxeW-eK3Mc+Z81LYM0qPhUXorrytZ54=S7GQgrjhQ@mail.gmail.com' \
--to=liq3ea@gmail.com \
--cc=euler.robot@huawei.com \
--cc=imammedo@redhat.com \
--cc=kuhn.chenqun@huawei.com \
--cc=mst@redhat.com \
--cc=pannengyuan@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).