From: Peter Maydell <peter.maydell@linaro.org>
To: Chen Qun <kuhn.chenqun@huawei.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Pan Nengyuan <pannengyuan@huawei.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
Euler Robot <euler.robot@huawei.com>
Subject: Re: [PATCH v2 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli()
Date: Tue, 25 Aug 2020 13:37:44 +0100 [thread overview]
Message-ID: <CAFEAcA9mbQmGRNqJC7FmV8gBi3XOuMmYRVhWmczZPTuTW9tfVw@mail.gmail.com> (raw)
In-Reply-To: <20200825112447.126308-4-kuhn.chenqun@huawei.com>
On Tue, 25 Aug 2020 at 12:26, Chen Qun <kuhn.chenqun@huawei.com> wrote:
>
> Clang static code analyzer show warning:
> target/arm/translate-a64.c:8635:14: warning: Value stored to 'tcg_rn' during its
> initialization is never read
> TCGv_i64 tcg_rn = new_tmp_a64(s);
> ^~~~~~ ~~~~~~~~~~~~~~
> target/arm/translate-a64.c:8636:14: warning: Value stored to 'tcg_rd' during its
> initialization is never read
> TCGv_i64 tcg_rd = new_tmp_a64(s);
> ^~~~~~ ~~~~~~~~~~~~~~
>
> There is a memory leak for the variable new_tmp_a64 "s".
There is not, because TCG temps allocated via new_tmp_a64()
are all freed via free_tmp_a64() at the end of disas_a64_insn().
> We should delete the assignment.
But yes, the assignments are unused and should be deleted.
If you fix the commit message, then
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2020-08-25 12:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 11:24 [PATCH v2 00/10] trivial patchs for static code analyzer fixes Chen Qun
2020-08-25 11:24 ` [PATCH v2 01/10] hw/arm/virt-acpi-build:Remove dead assignment in build_madt() Chen Qun
2020-08-26 1:25 ` Li Qiang
2020-08-25 11:24 ` [PATCH v2 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read() Chen Qun
2020-08-25 12:35 ` Peter Maydell
2020-08-26 1:26 ` Li Qiang
2020-08-25 11:24 ` [PATCH v2 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli() Chen Qun
2020-08-25 12:37 ` Peter Maydell [this message]
2020-08-26 2:42 ` Chenqun (kuhn)
2020-08-25 11:24 ` [PATCH v2 04/10] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16() Chen Qun
2020-08-25 12:38 ` Peter Maydell
2020-08-25 11:24 ` [PATCH v2 05/10] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions() Chen Qun
2020-08-26 10:23 ` Li Qiang
2020-08-25 11:24 ` [PATCH v2 06/10] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check() Chen Qun
2020-08-26 1:35 ` Li Qiang
2020-08-25 11:24 ` [PATCH v2 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt() Chen Qun
2020-08-25 15:00 ` Stefan Hajnoczi
2020-08-26 1:38 ` Li Qiang
2020-08-26 1:47 ` Chenqun (kuhn)
2020-08-26 10:14 ` Li Qiang
2020-08-25 11:24 ` [PATCH v2 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path() Chen Qun
2020-08-25 14:39 ` Markus Armbruster
2020-08-26 1:59 ` Chenqun (kuhn)
2020-08-26 2:25 ` Chenqun (kuhn)
2020-08-25 11:24 ` [PATCH v2 09/10] hw/intc: Remove redundant statement in exynos4210_combiner_read() Chen Qun
2020-08-25 12:41 ` Peter Maydell
2020-08-27 7:00 ` Chenqun (kuhn)
2020-08-27 9:28 ` Peter Maydell
2020-08-25 11:24 ` [PATCH v2 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic() Chen Qun
2020-08-26 1:54 ` Li Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9mbQmGRNqJC7FmV8gBi3XOuMmYRVhWmczZPTuTW9tfVw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=euler.robot@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=pannengyuan@huawei.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).