Re: [Qemu-devel] [PATCH v8 15/37] target/mips: Style improvements in mips_malta.c

[Aleksandar Markovic <aleksandar.m.mail@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2560 bytes --]

On Friday, December 6, 2019, Aleksandar Markovic <
aleksandar.m.mail@gmail.com> wrote:

>
>
> On Friday, December 6, 2019, Philippe Mathieu-Daudé <philmd@redhat.com>
> wrote:
>
>> Hi Aleksandar,
>>
>> On 8/19/19 4:47 PM, Aleksandar Rikalo wrote:
>>
>>> From: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
>>>  > Sent: Monday, August 19, 2019 2:07 PM
>>>  > To: qemu-devel@nongnu.org <qemu-devel@nongnu.org>
>>>  > Cc: philmd@redhat.com <philmd@redhat.com>; Aleksandar Markovic <
>>> amarkovic@wavecomp.com>; Aleksandar Rikalo <arikalo@wavecomp.com>
>>>  > Subject: [EXTERNAL][PATCH v8 15/37] target/mips: Style improvements
>>> in mips_malta.c
>>>  >
>>>  > From: Aleksandar Markovic <amarkovic@wavecomp.com>
>>>  >
>>>  > Fixes mostly errors and warnings reported by 'checkpatch.pl -f'.
>>>  >
>>>  > Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
>>>  > ---
>>>  >  hw/mips/mips_malta.c | 216 ++++++++++++++++++++++++++++++
>>> ---------------------
>>>  >  1 file changed, 128 insertions(+), 88 deletions(-)
>>>  >
>>>  > diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
>>>
>> [...]>  > @@ -347,7 +362,8 @@ static uint64_t malta_fpga_read(void
>> *opaque,
>>
>>> hwaddr addr,
>>>  >
>>>  >      /* SWITCH Register */
>>>  >      case 0x00200:
>>>  > -        val = 0x00000000;              /* All switches closed */
>>>  > +        /* ori a3, a3, low(ram_low_size) */
>>>
>>
>> I'm not sure what happened here, this change is incorrect.
>>
>>
> You are right, a strange case of a stray comment.
>
> Do you want to send a patch-correction? So that I can select it for the
> first mips queue...
>
>
Philippe,

I can merge, while applying, this one-line correction into Filip's patch on
the same file, no need for a separate patch.

Thanks again,
Aleksandar



> Thanks for spotting it!
> Aleksandar
>
>  > +        val = 0x00000000;
>>>  >          break;
>>>  >
>>>  >      /* STATUS Register */
>>>  > @@ -386,10 +402,11 @@ static uint64_t malta_fpga_read(void *opaque,
>>> hwaddr addr,
>>>  >      /* GPINP Register */
>>>  >      case 0x00a08:
>>>  >          /* IN = OUT until a real I2C control is implemented */
>>>  > -        if (s->i2csel)
>>>  > +        if (s->i2csel) {
>>>  >              val = s->i2cout;
>>>  > -        else
>>>  > +        } else {
>>>  >              val = 0x00;
>>>  > +        }
>>>  >          break;
>>>  >
>>>
>> [...]
>>
>>>
>>> Reviewed-by: Aleksandar Rikalo <arikalo@wavecomp.com>
>>>
>>>
>>
>>

[-- Attachment #2: Type: text/html, Size: 4777 bytes --]