From: Palmer Dabbelt <palmer@sifive.com>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cc: Sagar Karandikar <sagark@eecs.berkeley.edu>,
qemu-riscv@nongnu.org, peer.adelt@hni.uni-paderborn.de,
richard.henderson@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v6 00/35] target/riscv: Convert to decodetree
Date: Tue, 12 Feb 2019 18:15:26 -0800 [thread overview]
Message-ID: <CANs6eMkMKGKVdnWh2CmEz1sOtXEZh6eMUN5NkCwGjna7zEhh9Q@mail.gmail.com> (raw)
In-Reply-To: <mhng-0fc7cd00-deda-4e41-abb3-c78657c4f0f1@palmer-si-x1c4>
On Tue, Feb 12, 2019 at 3:21 PM Palmer Dabbelt <palmer@sifive.com> wrote:
> On Wed, 23 Jan 2019 01:25:03 PST (-0800), Bastian Koppelmann wrote:
> > Hi,
> >
> > this patchset converts the RISC-V decoder to decodetree in four major
> steps:
> >
> > 1) Convert 32-bit instructions to decodetree [Patch 1-16]:
> > Many of the gen_* functions are called by the decode functions for
> 16-bit
> > and 32-bit functions. If we move translation code from the gen_*
> > functions to the generated trans_* functions of decode-tree, we get
> a lot of
> > duplication. Therefore, we mostly generate calls to the old gen_*
> function
> > which are properly replaced after step 2).
> >
> > Each of the trans_ functions are grouped into files corresponding to
> their
> > ISA extension, e.g. addi which is in RV32I is translated in the file
> > 'trans_rvi.inc.c'.
> >
> > 2) Convert 16-bit instructions to decodetree [Patch 17-19]:
> > All 16 bit instructions have a direct mapping to a 32 bit
> instruction. Thus,
> > we convert the arguments in the 16 bit trans_ function to the
> arguments of
> > the corresponding 32 bit instruction and call the 32 bit trans_
> function.
> >
> > 3) Remove old manual decoding in gen_* function [Patch 20-30]:
> > this move all manual translation code into the trans_* instructions
> of
> > decode tree, such that we can remove the old decode_* functions.
> >
> > 4) Simplify RVC by reusing as much as possible from the RVG decoder as
> suggested
> > by Richard. [Patch 31-35]
> >
> > full tree available at
> > https://github.com/bkoppelmann/qemu/tree/riscv-dt-v6
> >
> > Cheers,
> > Bastian
> >
> > v5 -> v6:
> > - fixed funky indentation
> >
> >
> > Bastian Koppelmann (35):
> > target/riscv: Move CPURISCVState pointer to DisasContext
> > target/riscv: Activate decodetree and implemnt LUI & AUIPC
> > target/riscv: Convert RVXI branch insns to decodetree
> > target/riscv: Convert RV32I load/store insns to decodetree
> > target/riscv: Convert RV64I load/store insns to decodetree
> > target/riscv: Convert RVXI arithmetic insns to decodetree
> > target/riscv: Convert RVXI fence insns to decodetree
> > target/riscv: Convert RVXI csr insns to decodetree
> > target/riscv: Convert RVXM insns to decodetree
> > target/riscv: Convert RV32A insns to decodetree
> > target/riscv: Convert RV64A insns to decodetree
> > target/riscv: Convert RV32F insns to decodetree
> > target/riscv: Convert RV64F insns to decodetree
> > target/riscv: Convert RV32D insns to decodetree
> > target/riscv: Convert RV64D insns to decodetree
> > target/riscv: Convert RV priv insns to decodetree
> > target/riscv: Convert quadrant 0 of RVXC insns to decodetree
> > target/riscv: Convert quadrant 1 of RVXC insns to decodetree
> > target/riscv: Convert quadrant 2 of RVXC insns to decodetree
> > target/riscv: Remove gen_jalr()
> > target/riscv: Remove manual decoding from gen_branch()
> > target/riscv: Remove manual decoding from gen_load()
> > target/riscv: Remove manual decoding from gen_store()
> > target/riscv: Move gen_arith_imm() decoding into trans_* functions
> > target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
> > target/riscv: Remove shift and slt insn manual decoding
> > target/riscv: Remove manual decoding of RV32/64M insn
> > target/riscv: Rename trans_arith to gen_arith
> > target/riscv: Remove gen_system()
> > target/riscv: Remove decode_RV32_64G()
> > target/riscv: Convert @cs_2 insns to share translation functions
> > target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
> > target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
> > target/riscv: Splice remaining compressed insn pairs for riscv32 vs
> > riscv64
> > target/riscv: Remaining rvc insn reuse 32 bit translators
> >
> > target/riscv/Makefile.objs | 22 +
> > target/riscv/insn16-32.decode | 31 +
> > target/riscv/insn16-64.decode | 33 +
> > target/riscv/insn16.decode | 114 ++
> > target/riscv/insn32-64.decode | 72 +
> > target/riscv/insn32.decode | 203 ++
> > .../riscv/insn_trans/trans_privileged.inc.c | 110 +
> > target/riscv/insn_trans/trans_rva.inc.c | 207 ++
> > target/riscv/insn_trans/trans_rvc.inc.c | 149 ++
> > target/riscv/insn_trans/trans_rvd.inc.c | 388 ++++
> > target/riscv/insn_trans/trans_rvf.inc.c | 388 ++++
> > target/riscv/insn_trans/trans_rvi.inc.c | 568 ++++++
> > target/riscv/insn_trans/trans_rvm.inc.c | 107 +
> > target/riscv/translate.c | 1781 ++---------------
> > 14 files changed, 2611 insertions(+), 1562 deletions(-)
> > create mode 100644 target/riscv/insn16-32.decode
> > create mode 100644 target/riscv/insn16-64.decode
> > create mode 100644 target/riscv/insn16.decode
> > create mode 100644 target/riscv/insn32-64.decode
> > create mode 100644 target/riscv/insn32.decode
> > create mode 100644 target/riscv/insn_trans/trans_privileged.inc.c
> > create mode 100644 target/riscv/insn_trans/trans_rva.inc.c
> > create mode 100644 target/riscv/insn_trans/trans_rvc.inc.c
> > create mode 100644 target/riscv/insn_trans/trans_rvd.inc.c
> > create mode 100644 target/riscv/insn_trans/trans_rvf.inc.c
> > create mode 100644 target/riscv/insn_trans/trans_rvi.inc.c
> > create mode 100644 target/riscv/insn_trans/trans_rvm.inc.c
>
> Do you, by any chance, have a v7? It looks like there's quite a few merge
> conflicts here, and while I'm OK fixing them I don't want to do it if you
> already have.
>
I made it through my rebase, so unless you want to send out a v7 I will.
There were some meaningful changes so I'd like to get a round of review
just so everyone is on the same page.
next prev parent reply other threads:[~2019-02-13 2:15 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 9:25 [Qemu-devel] [PATCH v6 00/35] target/riscv: Convert to decodetree Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 01/35] target/riscv: Move CPURISCVState pointer to DisasContext Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 02/35] target/riscv: Activate decodetree and implemnt LUI & AUIPC Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 03/35] target/riscv: Convert RVXI branch insns to decodetree Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 04/35] target/riscv: Convert RV32I load/store " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 05/35] target/riscv: Convert RV64I " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 06/35] target/riscv: Convert RVXI arithmetic " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 07/35] target/riscv: Convert RVXI fence " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 08/35] target/riscv: Convert RVXI csr " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 09/35] target/riscv: Convert RVXM " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 10/35] target/riscv: Convert RV32A " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 11/35] target/riscv: Convert RV64A " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 12/35] target/riscv: Convert RV32F " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 13/35] target/riscv: Convert RV64F " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 14/35] target/riscv: Convert RV32D " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 15/35] target/riscv: Convert RV64D " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 16/35] target/riscv: Convert RV priv " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 17/35] target/riscv: Convert quadrant 0 of RVXC " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 18/35] target/riscv: Convert quadrant 1 " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 19/35] target/riscv: Convert quadrant 2 " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 20/35] target/riscv: Remove gen_jalr() Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 21/35] target/riscv: Remove manual decoding from gen_branch() Bastian Koppelmann
2019-01-25 22:23 ` Alistair
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 22/35] target/riscv: Remove manual decoding from gen_load() Bastian Koppelmann
2019-01-25 22:23 ` Alistair
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 23/35] target/riscv: Remove manual decoding from gen_store() Bastian Koppelmann
2019-01-25 22:25 ` Alistair
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 24/35] target/riscv: Move gen_arith_imm() decoding into trans_* functions Bastian Koppelmann
2019-01-25 22:27 ` Alistair
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 25/35] target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 26/35] target/riscv: Remove shift and slt insn manual decoding Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 27/35] target/riscv: Remove manual decoding of RV32/64M insn Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 28/35] target/riscv: Rename trans_arith to gen_arith Bastian Koppelmann
2019-01-25 22:28 ` Alistair
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 29/35] target/riscv: Remove gen_system() Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 30/35] target/riscv: Remove decode_RV32_64G() Bastian Koppelmann
2019-01-25 22:29 ` Alistair
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 31/35] target/riscv: Convert @cs_2 insns to share translation functions Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 32/35] target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 33/35] target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 34/35] target/riscv: Splice remaining compressed insn pairs " Bastian Koppelmann
2019-01-23 9:25 ` [Qemu-devel] [PATCH v6 35/35] target/riscv: Remaining rvc insn reuse 32 bit translators Bastian Koppelmann
2019-01-31 17:50 ` [Qemu-devel] [PATCH v6 00/35] target/riscv: Convert to decodetree no-reply
2019-01-31 18:18 ` no-reply
2019-01-31 18:22 ` no-reply
2019-02-12 23:21 ` Palmer Dabbelt
2019-02-13 2:15 ` Palmer Dabbelt [this message]
2019-02-13 9:06 ` Bastian Koppelmann
2019-02-13 15:34 ` Palmer Dabbelt
2019-02-14 0:37 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANs6eMkMKGKVdnWh2CmEz1sOtXEZh6eMUN5NkCwGjna7zEhh9Q@mail.gmail.com \
--to=palmer@sifive.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=peer.adelt@hni.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).