* [PATCH] tests/migration: fix parameter of auto-converge migration
@ 2021-03-23 15:43 huangy81
2021-03-23 19:40 ` Dr. David Alan Gilbert
2021-04-06 17:05 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 5+ messages in thread
From: huangy81 @ 2021-03-23 15:43 UTC (permalink / raw)
To: qemu-devel
Cc: Hyman Huang(黄勇), Dr. David Alan Gilbert, Juan Quintela
From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
when execute the following test command:
$ ./guestperf-batch.py --auto-converge \
--auto-converge-step {percent} ...
test aborts and error message be throwed as the following:
"Parameter 'x-cpu-throttle-increment' is unexpected"
The reason is that 'x-cpu-throttle-increment' has been
deprecated and 'cpu-throttle-increment' was introduced
Since v2.7. Use the new parameter instead.
Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
---
tests/migration/guestperf/engine.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py
index e399447..6b49aed 100644
--- a/tests/migration/guestperf/engine.py
+++ b/tests/migration/guestperf/engine.py
@@ -102,7 +102,7 @@ def _migrate_progress(self, vm):
info.get("downtime", 0),
info.get("expected-downtime", 0),
info.get("setup-time", 0),
- info.get("x-cpu-throttle-percentage", 0),
+ info.get("cpu-throttle-percentage", 0),
)
def _migrate(self, hardware, scenario, src, dst, connect_uri):
@@ -135,7 +135,7 @@ def _migrate(self, hardware, scenario, src, dst, connect_uri):
"state": True }
])
resp = src.command("migrate-set-parameters",
- x_cpu_throttle_increment=scenario._auto_converge_step)
+ cpu_throttle_increment=scenario._auto_converge_step)
if scenario._post_copy:
resp = src.command("migrate-set-capabilities",
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/migration: fix parameter of auto-converge migration
2021-03-23 15:43 [PATCH] tests/migration: fix parameter of auto-converge migration huangy81
@ 2021-03-23 19:40 ` Dr. David Alan Gilbert
2021-03-24 5:42 ` Thomas Huth
2021-04-06 17:05 ` Dr. David Alan Gilbert
1 sibling, 1 reply; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2021-03-23 19:40 UTC (permalink / raw)
To: huangy81, thuth, berrange; +Cc: qemu-devel, Juan Quintela
* huangy81@chinatelecom.cn (huangy81@chinatelecom.cn) wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> when execute the following test command:
> $ ./guestperf-batch.py --auto-converge \
> --auto-converge-step {percent} ...
> test aborts and error message be throwed as the following:
> "Parameter 'x-cpu-throttle-increment' is unexpected"
>
> The reason is that 'x-cpu-throttle-increment' has been
> deprecated and 'cpu-throttle-increment' was introduced
> Since v2.7. Use the new parameter instead.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Please cc thuth@redhat.com and berrange@redhat.com on fixes to this
file.
> ---
> tests/migration/guestperf/engine.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py
> index e399447..6b49aed 100644
> --- a/tests/migration/guestperf/engine.py
> +++ b/tests/migration/guestperf/engine.py
> @@ -102,7 +102,7 @@ def _migrate_progress(self, vm):
> info.get("downtime", 0),
> info.get("expected-downtime", 0),
> info.get("setup-time", 0),
> - info.get("x-cpu-throttle-percentage", 0),
> + info.get("cpu-throttle-percentage", 0),
> )
>
> def _migrate(self, hardware, scenario, src, dst, connect_uri):
> @@ -135,7 +135,7 @@ def _migrate(self, hardware, scenario, src, dst, connect_uri):
> "state": True }
> ])
> resp = src.command("migrate-set-parameters",
> - x_cpu_throttle_increment=scenario._auto_converge_step)
> + cpu_throttle_increment=scenario._auto_converge_step)
>
> if scenario._post_copy:
> resp = src.command("migrate-set-capabilities",
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/migration: fix parameter of auto-converge migration
2021-03-23 19:40 ` Dr. David Alan Gilbert
@ 2021-03-24 5:42 ` Thomas Huth
2021-03-24 6:03 ` Hyman Huang
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2021-03-24 5:42 UTC (permalink / raw)
To: Dr. David Alan Gilbert, huangy81, berrange; +Cc: qemu-devel, Juan Quintela
On 23/03/2021 20.40, Dr. David Alan Gilbert wrote:
> * huangy81@chinatelecom.cn (huangy81@chinatelecom.cn) wrote:
>> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>>
>> when execute the following test command:
>> $ ./guestperf-batch.py --auto-converge \
>> --auto-converge-step {percent} ...
>> test aborts and error message be throwed as the following:
>> "Parameter 'x-cpu-throttle-increment' is unexpected"
>>
>> The reason is that 'x-cpu-throttle-increment' has been
>> deprecated and 'cpu-throttle-increment' was introduced
>> Since v2.7. Use the new parameter instead.
>>
>> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> Please cc thuth@redhat.com and berrange@redhat.com on fixes to this
> file.
This not really my turf, since it's not directly related to the qtests.
But I wonder why tests/migration/ is not listed in the "Migration" sections
in the MAINTAINERS file ... care to send a patch?
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/migration: fix parameter of auto-converge migration
2021-03-24 5:42 ` Thomas Huth
@ 2021-03-24 6:03 ` Hyman Huang
0 siblings, 0 replies; 5+ messages in thread
From: Hyman Huang @ 2021-03-24 6:03 UTC (permalink / raw)
To: Thomas Huth, Dr. David Alan Gilbert, berrange; +Cc: qemu-devel, Juan Quintela
在 2021/3/24 13:42, Thomas Huth 写道:
> On 23/03/2021 20.40, Dr. David Alan Gilbert wrote:
>> * huangy81@chinatelecom.cn (huangy81@chinatelecom.cn) wrote:
>>> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>>>
>>> when execute the following test command:
>>> $ ./guestperf-batch.py --auto-converge \
>>> --auto-converge-step {percent} ...
>>> test aborts and error message be throwed as the following:
>>> "Parameter 'x-cpu-throttle-increment' is unexpected"
>>>
>>> The reason is that 'x-cpu-throttle-increment' has been
>>> deprecated and 'cpu-throttle-increment' was introduced
>>> Since v2.7. Use the new parameter instead.
>>>
>>> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>>
>> Please cc thuth@redhat.com and berrange@redhat.com on fixes to this
>> file.
>
> This not really my turf, since it's not directly related to the qtests.
>
> But I wonder why tests/migration/ is not listed in the "Migration"
> sections in the MAINTAINERS file ... care to send a patch?
the following patch aim to do this, it's already reviewed and has not
been merged yet.
https://patchew.org/QEMU/91d5978357fb8709ef61d2030984f7142847037d.1616141556.git.huangy81@chinatelecom.cn/
>
> Thomas
>
--
Best regard
Hyman Huang(黄勇)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tests/migration: fix parameter of auto-converge migration
2021-03-23 15:43 [PATCH] tests/migration: fix parameter of auto-converge migration huangy81
2021-03-23 19:40 ` Dr. David Alan Gilbert
@ 2021-04-06 17:05 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2021-04-06 17:05 UTC (permalink / raw)
To: huangy81; +Cc: qemu-devel, Juan Quintela
* huangy81@chinatelecom.cn (huangy81@chinatelecom.cn) wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> when execute the following test command:
> $ ./guestperf-batch.py --auto-converge \
> --auto-converge-step {percent} ...
> test aborts and error message be throwed as the following:
> "Parameter 'x-cpu-throttle-increment' is unexpected"
>
> The reason is that 'x-cpu-throttle-increment' has been
> deprecated and 'cpu-throttle-increment' was introduced
> Since v2.7. Use the new parameter instead.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
Queued
> ---
> tests/migration/guestperf/engine.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py
> index e399447..6b49aed 100644
> --- a/tests/migration/guestperf/engine.py
> +++ b/tests/migration/guestperf/engine.py
> @@ -102,7 +102,7 @@ def _migrate_progress(self, vm):
> info.get("downtime", 0),
> info.get("expected-downtime", 0),
> info.get("setup-time", 0),
> - info.get("x-cpu-throttle-percentage", 0),
> + info.get("cpu-throttle-percentage", 0),
> )
>
> def _migrate(self, hardware, scenario, src, dst, connect_uri):
> @@ -135,7 +135,7 @@ def _migrate(self, hardware, scenario, src, dst, connect_uri):
> "state": True }
> ])
> resp = src.command("migrate-set-parameters",
> - x_cpu_throttle_increment=scenario._auto_converge_step)
> + cpu_throttle_increment=scenario._auto_converge_step)
>
> if scenario._post_copy:
> resp = src.command("migrate-set-capabilities",
> --
> 1.8.3.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-06 17:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 15:43 [PATCH] tests/migration: fix parameter of auto-converge migration huangy81
2021-03-23 19:40 ` Dr. David Alan Gilbert
2021-03-24 5:42 ` Thomas Huth
2021-03-24 6:03 ` Hyman Huang
2021-04-06 17:05 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).