qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Hao Wu <wuhaotsh@google.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Havard Skinnemoen <hskinnemoen@google.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Tyrone Ting <kfting@nuvoton.com>
Subject: Re: [PULL 17/21] hw/adc: Add an ADC module for NPCM7XX
Date: Fri, 29 Jan 2021 19:23:49 +0100	[thread overview]
Message-ID: <c319a7d5-59d7-d75b-d857-71951ecc2fdb@amsat.org> (raw)
In-Reply-To: <CAGcCb10p1Q2vxjfOshYx101206jqrQ9L-KkONqOuAwZpdL77SQ@mail.gmail.com>

On 1/29/21 6:15 PM, wuhaotsh--- via wrote:
> On Fri, Jan 29, 2021 at 6:41 AM Philippe Mathieu-Daudé <f4bug@amsat.org
> <mailto:f4bug@amsat.org>> wrote:
> 
>     Hi Hao Wu,
> 
>     On 1/12/21 5:57 PM, Peter Maydell wrote:
>     > From: Hao Wu <wuhaotsh@google.com <mailto:wuhaotsh@google.com>>
>     >
>     > The ADC is part of NPCM7XX Module. Its behavior is controled by the
>     > ADC_CON register. It converts one of the eight analog inputs into a
>     > digital input and stores it in the ADC_DATA register when enabled.
>     >
>     > Users can alter input value by using qom-set QMP command.
>     >
>     > Reviewed-by: Havard Skinnemoen <hskinnemoen@google.com
>     <mailto:hskinnemoen@google.com>>
>     > Reviewed-by: Tyrone Ting <kfting@nuvoton.com
>     <mailto:kfting@nuvoton.com>>
>     > Signed-off-by: Hao Wu <wuhaotsh@google.com
>     <mailto:wuhaotsh@google.com>>
>     > Message-id: 20210108190945.949196-4-wuhaotsh@google.com
>     <mailto:20210108190945.949196-4-wuhaotsh@google.com>
>     > [PMM: Added missing hw/adc/trace.h file]
>     > Reviewed-by: Peter Maydell <peter.maydell@linaro.org
>     <mailto:peter.maydell@linaro.org>>
>     > Signed-off-by: Peter Maydell <peter.maydell@linaro.org
>     <mailto:peter.maydell@linaro.org>>
>     > ---
>     >  docs/system/arm/nuvoton.rst    |   2 +-
>     >  meson.build                    |   1 +
>     >  hw/adc/trace.h                 |   1 +
>     >  include/hw/adc/npcm7xx_adc.h   |  69 ++++++
>     >  include/hw/arm/npcm7xx.h       |   2 +
>     >  hw/adc/npcm7xx_adc.c           | 301 ++++++++++++++++++++++++++
>     >  hw/arm/npcm7xx.c               |  24 ++-
>     >  tests/qtest/npcm7xx_adc-test.c | 377
>     +++++++++++++++++++++++++++++++++
>     >  hw/adc/meson.build             |   1 +
>     >  hw/adc/trace-events            |   5 +
>     >  tests/qtest/meson.build        |   3 +-
>     >  11 files changed, 783 insertions(+), 3 deletions(-)
>     >  create mode 100644 hw/adc/trace.h
>     >  create mode 100644 include/hw/adc/npcm7xx_adc.h
>     >  create mode 100644 hw/adc/npcm7xx_adc.c
>     >  create mode 100644 tests/qtest/npcm7xx_adc-test.c
>     >  create mode 100644 hw/adc/trace-events
>     ...

>     > +
>     > +REG32(NPCM7XX_ADC_CON, 0x0)
>     > +REG32(NPCM7XX_ADC_DATA, 0x4)
>     > +
>     > +/* Register field definitions. */
>     > +#define NPCM7XX_ADC_CON_MUX(rv) extract32(rv, 24, 4)
>     > +#define NPCM7XX_ADC_CON_INT_EN  BIT(21)
>     > +#define NPCM7XX_ADC_CON_REFSEL  BIT(19)
>     > +#define NPCM7XX_ADC_CON_INT     BIT(18)
>     > +#define NPCM7XX_ADC_CON_EN      BIT(17)
>     > +#define NPCM7XX_ADC_CON_RST     BIT(16)
>     > +#define NPCM7XX_ADC_CON_CONV    BIT(14)
>     > +#define NPCM7XX_ADC_CON_DIV(rv) extract32(rv, 1, 8)
>     > +
>     > +#define NPCM7XX_ADC_MAX_RESULT      1023
>     > +#define NPCM7XX_ADC_DEFAULT_IREF    2000000
>     > +#define NPCM7XX_ADC_CONV_CYCLES     20
>     > +#define NPCM7XX_ADC_RESET_CYCLES    10
>     > +#define NPCM7XX_ADC_R0_INPUT        500000
>     > +#define NPCM7XX_ADC_R1_INPUT        1500000
>     > +
>     > +static void npcm7xx_adc_reset(NPCM7xxADCState *s)
>     > +{
>     > +    timer_del(&s->conv_timer);
>     > +    s->con = 0x000c0001;
> 
>     This initialize CON to:
> 
>     NPCM7XX_ADC_CON_REFSEL | NPCM7XX_ADC_CON_INT | BIT(0)
> 
>     What is bit 0?
> 
> This reset value is from h/w spec. The bit is reserved and not used
> currently.

OK thanks. Since the datasheet is not public, better document
the reserved/unused bits to avoid further questioning later ;)

Thanks,

Phil.


  reply	other threads:[~2021-01-29 18:24 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12 16:57 [PULL 00/21] target-arm queue Peter Maydell
2021-01-12 16:57 ` [PULL 01/21] target/arm: ARMv8.4-TTST extension Peter Maydell
2021-01-12 16:57 ` [PULL 02/21] target/arm: enable Small Translation tables in max CPU Peter Maydell
2021-01-12 16:57 ` [PULL 03/21] target/arm: fix typo in cpu.h ID_AA64PFR1 field name Peter Maydell
2021-01-12 16:57 ` [PULL 04/21] target/arm: make ARMCPU.clidr 64-bit Peter Maydell
2021-01-12 16:57 ` [PULL 05/21] target/arm: make ARMCPU.ctr 64-bit Peter Maydell
2021-01-12 16:57 ` [PULL 06/21] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h Peter Maydell
2021-01-12 16:57 ` [PULL 07/21] target/arm: add aarch64 ID register fields " Peter Maydell
2021-01-12 16:57 ` [PULL 08/21] target/arm: add aarch32 " Peter Maydell
2021-01-12 16:57 ` [PULL 09/21] ui/cocoa: Update path to docs in build tree Peter Maydell
2021-01-12 16:57 ` [PULL 10/21] docs: Add qemu-storage-daemon(1) manpage to meson.build Peter Maydell
2021-01-12 16:57 ` [PULL 11/21] docs: Build and install all the docs in a single manual Peter Maydell
2022-12-08  6:55   ` Stefan Weil via
2022-12-08 10:39     ` Peter Maydell
2021-01-12 16:57 ` [PULL 12/21] target/arm: Don't decode insns in the XScale/iWMMXt space as cp insns Peter Maydell
2021-01-12 16:57 ` [PULL 13/21] hw/net/lan9118: Fix RX Status FIFO PEEK value Peter Maydell
2021-01-12 16:57 ` [PULL 14/21] hw/net/lan9118: Add symbolic constants for register offsets Peter Maydell
2021-01-12 16:57 ` [PULL 15/21] hw/misc: Add clock converter in NPCM7XX CLK module Peter Maydell
2021-01-12 16:57 ` [PULL 16/21] hw/timer: Refactor NPCM7XX Timer to use CLK clock Peter Maydell
2021-02-04  9:39   ` Philippe Mathieu-Daudé
2021-02-04 22:37     ` Hao Wu
2021-02-10 11:54       ` Philippe Mathieu-Daudé
2021-06-22 12:58         ` Philippe Mathieu-Daudé
2021-07-27 14:19       ` Peter Maydell
2021-07-27 18:07         ` Havard Skinnemoen
2021-01-12 16:57 ` [PULL 17/21] hw/adc: Add an ADC module for NPCM7XX Peter Maydell
2021-01-29 14:41   ` Philippe Mathieu-Daudé
2021-01-29 17:15     ` wuhaotsh--- via
2021-01-29 18:23       ` Philippe Mathieu-Daudé [this message]
2021-01-12 16:57 ` [PULL 18/21] hw/misc: Add a PWM " Peter Maydell
2021-01-13 16:02   ` Peter Maydell
2021-01-13 17:13     ` Hao Wu
2021-01-25 12:04       ` Peter Maydell
2021-01-12 16:57 ` [PULL 19/21] hw/misc: Add QTest for NPCM7XX PWM Module Peter Maydell
2021-01-12 16:57 ` [PULL 20/21] hw/*: Use type casting for SysBusDevice in NPCM7XX Peter Maydell
2021-01-12 16:57 ` [PULL 21/21] ui/cocoa: Fix openFile: deprecation on Big Sur Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c319a7d5-59d7-d75b-d857-71951ecc2fdb@amsat.org \
    --to=f4bug@amsat.org \
    --cc=hskinnemoen@google.com \
    --cc=kfting@nuvoton.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wuhaotsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).