From: Richard Henderson <richard.henderson@linaro.org>
To: Alexander Graf <agraf@csgraf.de>, Cameron Esfahani <dirty@apple.com>
Cc: kettenis@openbsd.org, qemu-devel@nongnu.org,
AJ Barris <AwlsomeAlex@github.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
Paolo Bonzini <pbonzini@redhat.com>,
osy@github.com
Subject: Re: [PATCH] hvf: arm: Ignore cache operations on MMIO
Date: Mon, 25 Oct 2021 17:14:26 -0700 [thread overview]
Message-ID: <f17a2693-0c1a-d41e-5218-1117d2636425@linaro.org> (raw)
In-Reply-To: <20211025191349.52992-1-agraf@csgraf.de>
On 10/25/21 12:13 PM, Alexander Graf wrote:
> + /*
> + * We ran into an instruction that traps for data, but is not
> + * hardware predecoded. This should not ever happen for well
> + * behaved guests. Let's try to see if we can somehow rescue
> + * the situation.
> + */
> +
> + cpu_synchronize_state(cpu);
> + if (cpu_memory_rw_debug(cpu, env->pc, &insn, 4, 0)) {
This isn't correct, since this would be a physical address access, and env->pc is virtual.
Phil's idea of cpu_ldl_data may be correct, and cpu_ldl_code may be slightly more so,
because we got EC_DATAABORT not EC_INSNABORT, which means that the virtual address at
env->pc is mapped and executable.
However, in the event that there's some sort of race condition in between this data abort
and hvf stopping all threads for the vm exit, by which the page tables could have been
modified between here and there, then cpu_ldl_code *could* produce another exception.
In which case the interface that gdbstub uses, cc->memory_rw_debug, will be most correct.
> @@ -1156,6 +1183,11 @@ int hvf_vcpu_exec(CPUState *cpu)
> hvf_exit->exception.physical_address, isv,
> iswrite, s1ptw, len, srt);
>
> + if (!isv) {
> + g_assert(hvf_emulate_insn(cpu));
> + advance_pc = true;
> + break;
> + }
> assert(isv);
Ouch. HVF really passes along an invalid syndrome? I was expecting that you'd be able to
avoid all of the instruction parsing and check syndrome.cm (bit 8) for a cache management
instruction.
r~
next prev parent reply other threads:[~2021-10-26 0:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 19:13 [PATCH] hvf: arm: Ignore cache operations on MMIO Alexander Graf
2021-10-25 20:57 ` Philippe Mathieu-Daudé
2021-10-26 0:14 ` Richard Henderson [this message]
2021-10-26 7:09 ` Alexander Graf
2021-10-26 8:56 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17a2693-0c1a-d41e-5218-1117d2636425@linaro.org \
--to=richard.henderson@linaro.org \
--cc=AwlsomeAlex@github.com \
--cc=agraf@csgraf.de \
--cc=dirty@apple.com \
--cc=kettenis@openbsd.org \
--cc=osy@github.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).