From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
kernel@pengutronix.de
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Fabio Estevam <festevam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/imx: fix memory leak in imx_pd_bind
Date: Sat, 5 Oct 2019 17:02:58 +0200 [thread overview]
Message-ID: <027fde47-86b3-35c8-85e6-ea7c191e772c@web.de> (raw)
In-Reply-To: <20191004190938.15353-1-navid.emamdoost@gmail.com>
> In imx_pd_bind, the duplicated memory for imxpd->edid via kmemdup should
> be released in drm_of_find_panel_or_bridge or imx_pd_register fail.
Please improve this change description.
> +++ b/drivers/gpu/drm/imx/parallel-display.c
> @@ -227,14 +227,18 @@ static int imx_pd_bind(struct device *dev, struct device *master, void *data)
>
> /* port@1 is the output port */
> ret = drm_of_find_panel_or_bridge(np, 1, 0, &imxpd->panel, &imxpd->bridge);
> - if (ret && ret != -ENODEV)
> + if (ret && ret != -ENODEV) {
> + kfree(imxpd->edid);
> return ret;
> + }
>
> imxpd->dev = dev;
Please use a jump target here instead of adding duplicate source code
for the completion of exception handling.
if (ret && ret != -ENODEV)
- return ret;
+ goto free_edid;
…
+free_edid:
+ kfree(imxpd->edid);
+ return ret;
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
kernel@pengutronix.de
Cc: kernel-janitors@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>, Kangjie Lu <kjlu@umn.edu>,
linux-kernel@vger.kernel.org, Navid Emamdoost <emamd001@umn.edu>,
Daniel Vetter <daniel@ffwll.ch>,
Stephen McCamant <smccaman@umn.edu>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] drm/imx: fix memory leak in imx_pd_bind
Date: Sat, 05 Oct 2019 15:02:58 +0000 [thread overview]
Message-ID: <027fde47-86b3-35c8-85e6-ea7c191e772c@web.de> (raw)
In-Reply-To: <20191004190938.15353-1-navid.emamdoost@gmail.com>
> In imx_pd_bind, the duplicated memory for imxpd->edid via kmemdup should
> be released in drm_of_find_panel_or_bridge or imx_pd_register fail.
Please improve this change description.
> +++ b/drivers/gpu/drm/imx/parallel-display.c
> @@ -227,14 +227,18 @@ static int imx_pd_bind(struct device *dev, struct device *master, void *data)
>
> /* port@1 is the output port */
> ret = drm_of_find_panel_or_bridge(np, 1, 0, &imxpd->panel, &imxpd->bridge);
> - if (ret && ret != -ENODEV)
> + if (ret && ret != -ENODEV) {
> + kfree(imxpd->edid);
> return ret;
> + }
>
> imxpd->dev = dev;
Please use a jump target here instead of adding duplicate source code
for the completion of exception handling.
if (ret && ret != -ENODEV)
- return ret;
+ goto free_edid;
…
+free_edid:
+ kfree(imxpd->edid);
+ return ret;
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
kernel@pengutronix.de
Cc: kernel-janitors@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>, Kangjie Lu <kjlu@umn.edu>,
linux-kernel@vger.kernel.org, Navid Emamdoost <emamd001@umn.edu>,
Daniel Vetter <daniel@ffwll.ch>,
Stephen McCamant <smccaman@umn.edu>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] drm/imx: fix memory leak in imx_pd_bind
Date: Sat, 5 Oct 2019 17:02:58 +0200 [thread overview]
Message-ID: <027fde47-86b3-35c8-85e6-ea7c191e772c@web.de> (raw)
In-Reply-To: <20191004190938.15353-1-navid.emamdoost@gmail.com>
> In imx_pd_bind, the duplicated memory for imxpd->edid via kmemdup should
> be released in drm_of_find_panel_or_bridge or imx_pd_register fail.
Please improve this change description.
> +++ b/drivers/gpu/drm/imx/parallel-display.c
> @@ -227,14 +227,18 @@ static int imx_pd_bind(struct device *dev, struct device *master, void *data)
>
> /* port@1 is the output port */
> ret = drm_of_find_panel_or_bridge(np, 1, 0, &imxpd->panel, &imxpd->bridge);
> - if (ret && ret != -ENODEV)
> + if (ret && ret != -ENODEV) {
> + kfree(imxpd->edid);
> return ret;
> + }
>
> imxpd->dev = dev;
Please use a jump target here instead of adding duplicate source code
for the completion of exception handling.
if (ret && ret != -ENODEV)
- return ret;
+ goto free_edid;
…
+free_edid:
+ kfree(imxpd->edid);
+ return ret;
Regards,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-05 15:03 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 19:09 [PATCH] drm/imx: fix memory leak in imx_pd_bind Navid Emamdoost
2019-10-04 19:09 ` Navid Emamdoost
2019-10-04 19:09 ` Navid Emamdoost
2019-10-05 15:02 ` Markus Elfring [this message]
2019-10-05 15:02 ` Markus Elfring
2019-10-05 15:02 ` Markus Elfring
2019-10-12 11:54 ` Markus Elfring
2019-10-12 11:54 ` Markus Elfring
2019-10-12 11:54 ` Markus Elfring
2019-10-12 19:22 ` Navid Emamdoost
2019-10-12 19:22 ` Navid Emamdoost
2019-10-12 19:22 ` Navid Emamdoost
2019-10-06 9:33 ` drm/imx: Checking a kmemdup() call in imx_pd_bind() Markus Elfring
2019-10-06 9:33 ` Markus Elfring
2019-10-06 9:33 ` Markus Elfring
2019-10-07 4:26 ` Navid Emamdoost
2019-10-07 4:26 ` Navid Emamdoost
2019-10-07 4:26 ` Navid Emamdoost
2019-10-07 7:44 ` Markus Elfring
2019-10-07 7:44 ` Markus Elfring
2019-10-07 7:44 ` Markus Elfring
2019-10-07 7:44 ` Markus Elfring
2019-10-12 9:04 ` [PATCH 0/2] drm/imx: Adjustments for two functions Markus Elfring
2019-10-12 9:04 ` Markus Elfring
2019-10-12 9:04 ` Markus Elfring
2019-10-12 9:04 ` Markus Elfring
2019-10-12 9:07 ` [PATCH 1/2] drm/imx: Fix error handling for a kmemdup() call in imx_pd_bind() Markus Elfring
2019-10-12 9:07 ` Markus Elfring
2019-10-12 9:07 ` Markus Elfring
2019-10-12 19:16 ` Navid Emamdoost
2019-10-12 19:16 ` Navid Emamdoost
2019-10-12 19:16 ` Navid Emamdoost
2019-10-12 19:24 ` Julia Lawall
2019-10-12 19:24 ` Julia Lawall
2019-10-12 19:24 ` Julia Lawall
2019-10-12 9:10 ` [PATCH 2/2] drm/imx: Fix error handling for a kmemdup() call in imx_ldb_panel_ddc() Markus Elfring
2019-10-12 9:10 ` Markus Elfring
2019-10-12 9:10 ` Markus Elfring
2019-11-21 18:31 ` [PATCH] drm/imx: fix memory leak in imx_pd_bind Navid Emamdoost
2019-11-21 18:31 ` Navid Emamdoost
2019-11-21 18:31 ` Navid Emamdoost
2019-11-22 7:22 ` Marco Felsch
2019-11-22 7:22 ` Marco Felsch
2019-11-22 7:22 ` Marco Felsch
2019-11-22 17:43 ` Navid Emamdoost
2019-11-22 17:43 ` Navid Emamdoost
2019-11-22 17:43 ` Navid Emamdoost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=027fde47-86b3-35c8-85e6-ea7c191e772c@web.de \
--to=markus.elfring@web.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emamd001@umn.edu \
--cc=festevam@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.