From: Navid Emamdoost <navid.emamdoost@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Fabio Estevam <festevam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/imx: fix memory leak in imx_pd_bind
Date: Sat, 12 Oct 2019 14:22:18 -0500 [thread overview]
Message-ID: <CAEkB2EQUrHpfCXDQ9HV9_hw7Ke5DmX3SvKWJd+wSwXB1Uqaf5g@mail.gmail.com> (raw)
In-Reply-To: <f90d7b4a-c4af-eac1-f326-211e932dbd22@web.de>
No, that is not correct! You should not try to free imxpd here as it
is a resource-managed allocation via devm_kzalloc(). It means memory
allocated with this function is automatically freed on driver detach.
So, this patch introduces a double-free.
On Sat, Oct 12, 2019 at 6:54 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > +free_edid:
> > + kfree(imxpd->edid);
> > + return ret;
>
> I have taken another look at this change idea.
> Can the function call “devm_kfree(dev, imxpd)” become relevant
> also at this place?
>
> Would you like to combine it with the update suggestion
> “Fix error handling for a kmemdup() call in imx_pd_bind()”?
> https://lore.kernel.org/r/3fd6aa8b-2529-7ff5-3e19-05267101b2a4@web.de/
> https://lore.kernel.org/patchwork/patch/1138912/
> https://lkml.org/lkml/2019/10/12/87
>
> Regards,
> Markus
--
Navid.
WARNING: multiple messages have this Message-ID (diff)
From: Navid Emamdoost <navid.emamdoost@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Fabio Estevam <festevam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/imx: fix memory leak in imx_pd_bind
Date: Sat, 12 Oct 2019 19:22:18 +0000 [thread overview]
Message-ID: <CAEkB2EQUrHpfCXDQ9HV9_hw7Ke5DmX3SvKWJd+wSwXB1Uqaf5g@mail.gmail.com> (raw)
In-Reply-To: <f90d7b4a-c4af-eac1-f326-211e932dbd22@web.de>
No, that is not correct! You should not try to free imxpd here as it
is a resource-managed allocation via devm_kzalloc(). It means memory
allocated with this function is automatically freed on driver detach.
So, this patch introduces a double-free.
On Sat, Oct 12, 2019 at 6:54 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > +free_edid:
> > + kfree(imxpd->edid);
> > + return ret;
>
> I have taken another look at this change idea.
> Can the function call “devm_kfree(dev, imxpd)” become relevant
> also at this place?
>
> Would you like to combine it with the update suggestion
> “Fix error handling for a kmemdup() call in imx_pd_bind()”?
> https://lore.kernel.org/r/3fd6aa8b-2529-7ff5-3e19-05267101b2a4@web.de/
> https://lore.kernel.org/patchwork/patch/1138912/
> https://lkml.org/lkml/2019/10/12/87
>
> Regards,
> Markus
--
Navid.
WARNING: multiple messages have this Message-ID (diff)
From: Navid Emamdoost <navid.emamdoost@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kernel-janitors@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@linux.ie>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>, Kangjie Lu <kjlu@umn.edu>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Navid Emamdoost <emamd001@umn.edu>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Stephen McCamant <smccaman@umn.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/imx: fix memory leak in imx_pd_bind
Date: Sat, 12 Oct 2019 14:22:18 -0500 [thread overview]
Message-ID: <CAEkB2EQUrHpfCXDQ9HV9_hw7Ke5DmX3SvKWJd+wSwXB1Uqaf5g@mail.gmail.com> (raw)
In-Reply-To: <f90d7b4a-c4af-eac1-f326-211e932dbd22@web.de>
No, that is not correct! You should not try to free imxpd here as it
is a resource-managed allocation via devm_kzalloc(). It means memory
allocated with this function is automatically freed on driver detach.
So, this patch introduces a double-free.
On Sat, Oct 12, 2019 at 6:54 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > +free_edid:
> > + kfree(imxpd->edid);
> > + return ret;
>
> I have taken another look at this change idea.
> Can the function call “devm_kfree(dev, imxpd)” become relevant
> also at this place?
>
> Would you like to combine it with the update suggestion
> “Fix error handling for a kmemdup() call in imx_pd_bind()”?
> https://lore.kernel.org/r/3fd6aa8b-2529-7ff5-3e19-05267101b2a4@web.de/
> https://lore.kernel.org/patchwork/patch/1138912/
> https://lkml.org/lkml/2019/10/12/87
>
> Regards,
> Markus
--
Navid.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-12 19:22 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 19:09 [PATCH] drm/imx: fix memory leak in imx_pd_bind Navid Emamdoost
2019-10-04 19:09 ` Navid Emamdoost
2019-10-04 19:09 ` Navid Emamdoost
2019-10-05 15:02 ` Markus Elfring
2019-10-05 15:02 ` Markus Elfring
2019-10-05 15:02 ` Markus Elfring
2019-10-12 11:54 ` Markus Elfring
2019-10-12 11:54 ` Markus Elfring
2019-10-12 11:54 ` Markus Elfring
2019-10-12 19:22 ` Navid Emamdoost [this message]
2019-10-12 19:22 ` Navid Emamdoost
2019-10-12 19:22 ` Navid Emamdoost
2019-10-06 9:33 ` drm/imx: Checking a kmemdup() call in imx_pd_bind() Markus Elfring
2019-10-06 9:33 ` Markus Elfring
2019-10-06 9:33 ` Markus Elfring
2019-10-07 4:26 ` Navid Emamdoost
2019-10-07 4:26 ` Navid Emamdoost
2019-10-07 4:26 ` Navid Emamdoost
2019-10-07 7:44 ` Markus Elfring
2019-10-07 7:44 ` Markus Elfring
2019-10-07 7:44 ` Markus Elfring
2019-10-07 7:44 ` Markus Elfring
2019-10-12 9:04 ` [PATCH 0/2] drm/imx: Adjustments for two functions Markus Elfring
2019-10-12 9:04 ` Markus Elfring
2019-10-12 9:04 ` Markus Elfring
2019-10-12 9:04 ` Markus Elfring
2019-10-12 9:07 ` [PATCH 1/2] drm/imx: Fix error handling for a kmemdup() call in imx_pd_bind() Markus Elfring
2019-10-12 9:07 ` Markus Elfring
2019-10-12 9:07 ` Markus Elfring
2019-10-12 19:16 ` Navid Emamdoost
2019-10-12 19:16 ` Navid Emamdoost
2019-10-12 19:16 ` Navid Emamdoost
2019-10-12 19:24 ` Julia Lawall
2019-10-12 19:24 ` Julia Lawall
2019-10-12 19:24 ` Julia Lawall
2019-10-12 9:10 ` [PATCH 2/2] drm/imx: Fix error handling for a kmemdup() call in imx_ldb_panel_ddc() Markus Elfring
2019-10-12 9:10 ` Markus Elfring
2019-10-12 9:10 ` Markus Elfring
2019-11-21 18:31 ` [PATCH] drm/imx: fix memory leak in imx_pd_bind Navid Emamdoost
2019-11-21 18:31 ` Navid Emamdoost
2019-11-21 18:31 ` Navid Emamdoost
2019-11-22 7:22 ` Marco Felsch
2019-11-22 7:22 ` Marco Felsch
2019-11-22 7:22 ` Marco Felsch
2019-11-22 17:43 ` Navid Emamdoost
2019-11-22 17:43 ` Navid Emamdoost
2019-11-22 17:43 ` Navid Emamdoost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEkB2EQUrHpfCXDQ9HV9_hw7Ke5DmX3SvKWJd+wSwXB1Uqaf5g@mail.gmail.com \
--to=navid.emamdoost@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emamd001@umn.edu \
--cc=festevam@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.