From: mickib1@gmail.com To: jkosina@suse.cz, rafi@seas.upenn.edu, chatty@enac.fr, peterhuewe@gmx.de, micki@n-trig.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] HID: N-trig MTM Driver fix And cleanup patch 5 Date: Mon, 8 Mar 2010 23:13:45 +0200 [thread overview] Message-ID: <1268082827-2680-5-git-send-email-micki@n-trig.com> (raw) In-Reply-To: <1268082827-2680-4-git-send-email-micki@n-trig.com> From: micki <micki@micki-laptop.(none)> udpate ntrig_probe - add call to ntrig_send_report function to initialize firmware to switch to Multi-touch mode. Delete input-name our driver don't distinguish pen and touch. Will be inserted in next version. N-trig is changing the way people interact with computers by providing a dual-mode pen and true multi-touch input device, specifically designed for today's advanced computing world. N-trig DuoSense® solution provides a real Hands-on computing® experience, and sets the stage for OEMs and ISVs to introduce innovative computer products and applications for an intuitive, Hands-on® experience directly onscreen. DuoSense digitizers are easily integrated into existing technologies, support all LCDs, keep devices slim and light, and can be implemented in a broad range of products, ranging from small notebooks to large LCDs. N-trig has offices in Israel, the US, Taiwan and Japan. Signed-off-by: Micki Balanga <micki@n-trig.com> --- drivers/hid/hid-ntrig.c | 41 ++++++----------------------------------- 1 files changed, 6 insertions(+), 35 deletions(-) diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c index 8cdb3c2..8bf796c 100644 --- a/drivers/hid/hid-ntrig.c +++ b/drivers/hid/hid-ntrig.c @@ -19,6 +19,8 @@ * 1.3 - N-trig - Change ntrig_input_mapped * 1.4 - N-trig - Add ntrig_send_report function * send set feature command to firmware + * 1.5 - N-trig udpate ntrig_probe + * add call to ntrig_send_report function */ /* @@ -415,11 +417,6 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id) { int ret; struct ntrig_data *nd; - struct hid_input *hidinput; - struct input_dev *input; - - if (id->driver_data) - hdev->quirks |= HID_QUIRK_MULTI_INPUT; nd = kmalloc(sizeof(struct ntrig_data), GFP_KERNEL); if (!nd) { @@ -427,7 +424,6 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id) return -ENOMEM; } - nd->reading_mt = 0; hid_set_drvdata(hdev, nd); ret = hid_parse(hdev); @@ -442,35 +438,10 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id) goto err_free; } - - list_for_each_entry(hidinput, &hdev->inputs, list) { - input = hidinput->input; - switch (hidinput->report->field[0]->application) { - case HID_DG_PEN: - input->name = "N-Trig Pen"; - break; - case HID_DG_TOUCHSCREEN: - __clear_bit(BTN_TOOL_PEN, input->keybit); - /* - * A little something special to enable - * two and three finger taps. - */ - __set_bit(BTN_TOOL_DOUBLETAP, input->keybit); - __set_bit(BTN_TOOL_TRIPLETAP, input->keybit); - __set_bit(BTN_TOOL_QUADTAP, input->keybit); - /* - * The physical touchscreen (single touch) - * input has a value for physical, whereas - * the multitouch only has logical input - * fields. - */ - input->name = - (hidinput->report->field[0] - ->physical) ? - "N-Trig Touchscreen" : - "N-Trig MultiTouch"; - break; - } + ret = ntrig_send_report(hdev); + if (ret) { + dev_err(&hdev->dev, "send set feature failed\n"); + goto err_free; } return 0; -- 1.6.3.3
WARNING: multiple messages have this Message-ID (diff)
From: mickib1@gmail.com To: jkosina@suse.cz, rafi@seas.upenn.edu, chatty@enac.fr, peterhuewe@gmx.de, micki@n-trig.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] HID: N-trig MTM Driver fix And cleanup patch 5 Date: Mon, 8 Mar 2010 23:13:45 +0200 [thread overview] Message-ID: <1268082827-2680-5-git-send-email-micki@n-trig.com> (raw) In-Reply-To: <1268082827-2680-4-git-send-email-micki@n-trig.com> From: micki <micki@micki-laptop.(none)> udpate ntrig_probe - add call to ntrig_send_report function to initialize firmware to switch to Multi-touch mode. Delete input-name our driver don't distinguish pen and touch. Will be inserted in next version. N-trig is changing the way people interact with computers by providing a dual-mode pen and true multi-touch input device, specifically designed for today's advanced computing world. N-trig DuoSense® solution provides a real Hands-on computing® experience, and sets the stage for OEMs and ISVs to introduce innovative computer products and applications for an intuitive, Hands-on® experience directly onscreen. DuoSense digitizers are easily integrated into existing technologies, support all LCDs, keep devices slim and light, and can be implemented in a broad range of products, ranging from small notebooks to large LCDs. N-trig has offices in Israel, the US, Taiwan and Japan. Signed-off-by: Micki Balanga <micki@n-trig.com> --- drivers/hid/hid-ntrig.c | 41 ++++++----------------------------------- 1 files changed, 6 insertions(+), 35 deletions(-) diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c index 8cdb3c2..8bf796c 100644 --- a/drivers/hid/hid-ntrig.c +++ b/drivers/hid/hid-ntrig.c @@ -19,6 +19,8 @@ * 1.3 - N-trig - Change ntrig_input_mapped * 1.4 - N-trig - Add ntrig_send_report function * send set feature command to firmware + * 1.5 - N-trig udpate ntrig_probe + * add call to ntrig_send_report function */ /* @@ -415,11 +417,6 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id) { int ret; struct ntrig_data *nd; - struct hid_input *hidinput; - struct input_dev *input; - - if (id->driver_data) - hdev->quirks |= HID_QUIRK_MULTI_INPUT; nd = kmalloc(sizeof(struct ntrig_data), GFP_KERNEL); if (!nd) { @@ -427,7 +424,6 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id) return -ENOMEM; } - nd->reading_mt = 0; hid_set_drvdata(hdev, nd); ret = hid_parse(hdev); @@ -442,35 +438,10 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id) goto err_free; } - - list_for_each_entry(hidinput, &hdev->inputs, list) { - input = hidinput->input; - switch (hidinput->report->field[0]->application) { - case HID_DG_PEN: - input->name = "N-Trig Pen"; - break; - case HID_DG_TOUCHSCREEN: - __clear_bit(BTN_TOOL_PEN, input->keybit); - /* - * A little something special to enable - * two and three finger taps. - */ - __set_bit(BTN_TOOL_DOUBLETAP, input->keybit); - __set_bit(BTN_TOOL_TRIPLETAP, input->keybit); - __set_bit(BTN_TOOL_QUADTAP, input->keybit); - /* - * The physical touchscreen (single touch) - * input has a value for physical, whereas - * the multitouch only has logical input - * fields. - */ - input->name = - (hidinput->report->field[0] - ->physical) ? - "N-Trig Touchscreen" : - "N-Trig MultiTouch"; - break; - } + ret = ntrig_send_report(hdev); + if (ret) { + dev_err(&hdev->dev, "send set feature failed\n"); + goto err_free; } return 0; -- 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-08 21:14 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-03-08 21:13 [PATCH 1/7] HID: N-trig MTM Driver fix and cleanup patch 1 mickib1 2010-03-08 21:13 ` mickib1 2010-03-08 21:13 ` [PATCH 2/7] HID: N-trig MTM Driver fix and cleanup patch 2 mickib1 2010-03-08 21:13 ` [PATCH 3/7] HID: N-trig MTM Driver fix And cleanup patch 3 mickib1 2010-03-08 21:13 ` [PATCH 4/7] HID: N-trig MTM Driver fix And cleanup Patch 4 mickib1 2010-03-08 21:13 ` mickib1 2010-03-08 21:13 ` mickib1 [this message] 2010-03-08 21:13 ` [PATCH 5/7] HID: N-trig MTM Driver fix And cleanup patch 5 mickib1 2010-03-08 21:13 ` [PATCH 6/7] HID: N-trig MTM Driver fix And cleanup patch 6 mickib1 2010-03-08 21:13 ` mickib1 2010-03-09 1:20 ` Rafi Rubin 2010-03-09 10:15 ` Jiri Kosina 2010-03-09 1:29 ` [PATCH 5/7] HID: N-trig MTM Driver fix And cleanup patch 5 Rafi Rubin 2010-03-09 1:10 ` [PATCH 4/7] HID: N-trig MTM Driver fix And cleanup Patch 4 Rafi Rubin 2010-03-09 1:07 ` [PATCH 2/7] HID: N-trig MTM Driver fix and cleanup patch 2 Rafi Rubin 2010-03-09 15:43 ` Stéphane Chatty 2010-03-09 15:43 ` Stéphane Chatty 2010-03-09 0:34 ` [PATCH 1/7] HID: N-trig MTM Driver fix and cleanup patch 1 Rafi Rubin 2010-03-09 0:50 ` Rafi Rubin 2010-03-09 10:11 ` Jiri Kosina 2010-03-09 8:43 ` Dmitry Torokhov 2010-03-09 8:43 ` Dmitry Torokhov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1268082827-2680-5-git-send-email-micki@n-trig.com \ --to=mickib1@gmail.com \ --cc=chatty@enac.fr \ --cc=jkosina@suse.cz \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=micki@n-trig.com \ --cc=peterhuewe@gmx.de \ --cc=rafi@seas.upenn.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.