All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: linux-erofs@lists.ozlabs.org
Cc: gaoxiang25@huawei.com, linux-fsdevel@vger.kernel.org,
	yuchao0@huawei.com, linux-kernel <linux-kernel@vger.kernel.org>
Subject: erofs: Question on unused fields in on-disk structs
Date: Mon, 19 Aug 2019 19:10:33 +0200 (CEST)	[thread overview]
Message-ID: <1323459733.69859.1566234633793.JavaMail.zimbra@nod.at> (raw)

Hi!

struct erofs_super_block has "checksum" and "features" fields,
but they are not used in the source.
What is the plan for these?

Same for i_checksum in erofs_inode_v1 and erofs_inode_v2.

At least the "features" field in the super block is something I'd
expect to be used.
...such that you can have new filesystem features in future.

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: richard@nod.at (Richard Weinberger)
Subject: erofs: Question on unused fields in on-disk structs
Date: Mon, 19 Aug 2019 19:10:33 +0200 (CEST)	[thread overview]
Message-ID: <1323459733.69859.1566234633793.JavaMail.zimbra@nod.at> (raw)

Hi!

struct erofs_super_block has "checksum" and "features" fields,
but they are not used in the source.
What is the plan for these?

Same for i_checksum in erofs_inode_v1 and erofs_inode_v2.

At least the "features" field in the super block is something I'd
expect to be used.
...such that you can have new filesystem features in future.

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: linux-erofs@lists.ozlabs.org
Cc: linux-fsdevel@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: erofs: Question on unused fields in on-disk structs
Date: Mon, 19 Aug 2019 19:10:33 +0200 (CEST)	[thread overview]
Message-ID: <1323459733.69859.1566234633793.JavaMail.zimbra@nod.at> (raw)
Message-ID: <20190819171033.vyK-HYi-v-w4r5lbVUGu6A3LGspOYXxO6KFGlKNvgZs@z> (raw)

Hi!

struct erofs_super_block has "checksum" and "features" fields,
but they are not used in the source.
What is the plan for these?

Same for i_checksum in erofs_inode_v1 and erofs_inode_v2.

At least the "features" field in the super block is something I'd
expect to be used.
...such that you can have new filesystem features in future.

Thanks,
//richard

             reply	other threads:[~2019-08-19 17:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 17:10 Richard Weinberger [this message]
2019-08-19 17:10 ` erofs: Question on unused fields in on-disk structs Richard Weinberger
2019-08-19 17:10 ` Richard Weinberger
2019-08-19 20:45 ` Gao Xiang
2019-08-19 20:45   ` Gao Xiang via Linux-erofs
2019-08-21 21:37   ` Richard Weinberger
2019-08-21 21:37     ` Richard Weinberger
2019-08-21 22:03     ` Gao Xiang
2019-08-21 22:03       ` Gao Xiang via Linux-erofs
2019-08-22  8:33       ` Richard Weinberger
2019-08-22  8:33         ` Richard Weinberger
2019-08-22  9:05         ` Gao Xiang
2019-08-22  9:05           ` Gao Xiang
2019-08-22  9:08           ` Gao Xiang
2019-08-22  9:08             ` Gao Xiang
2019-08-22 14:21         ` Theodore Y. Ts'o
2019-08-22 14:21           ` Theodore Y. Ts'o
2019-08-22 14:29           ` Richard Weinberger
2019-08-22 14:29             ` Richard Weinberger
2019-08-22 14:38             ` Gao Xiang
2019-08-22 14:38               ` Gao Xiang
2019-08-22 14:34           ` Gao Xiang
2019-08-22 14:34             ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323459733.69859.1566234633793.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=gaoxiang25@huawei.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.