From: Richard Weinberger <richard.weinberger@gmail.com>
To: Gao Xiang <hsiangkao@aol.com>
Cc: Richard Weinberger <richard@nod.at>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-erofs@lists.ozlabs.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: erofs: Question on unused fields in on-disk structs
Date: Wed, 21 Aug 2019 23:37:30 +0200 [thread overview]
Message-ID: <CAFLxGvxr2UMeVa29M9pjLtWMFPz7w6udRV38CRxEF1moyA9_Rw@mail.gmail.com> (raw)
In-Reply-To: <20190819204504.GB10075@hsiangkao-HP-ZHAN-66-Pro-G1>
Gao Xiang,
On Mon, Aug 19, 2019 at 10:45 PM Gao Xiang via Linux-erofs
<linux-erofs@lists.ozlabs.org> wrote:
> > struct erofs_super_block has "checksum" and "features" fields,
> > but they are not used in the source.
> > What is the plan for these?
>
> Yes, both will be used laterly (features is used for compatible
> features, we already have some incompatible features in 5.3).
Good. :-)
I suggest to check the fields being 0 right now.
Otherwise you are in danger that they get burned if an mkfs.erofs does not
initialize the fields.
--
Thanks,
//richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard.weinberger@gmail.com>
To: Gao Xiang <hsiangkao@aol.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Richard Weinberger <richard@nod.at>,
linux-erofs@lists.ozlabs.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: erofs: Question on unused fields in on-disk structs
Date: Wed, 21 Aug 2019 23:37:30 +0200 [thread overview]
Message-ID: <CAFLxGvxr2UMeVa29M9pjLtWMFPz7w6udRV38CRxEF1moyA9_Rw@mail.gmail.com> (raw)
In-Reply-To: <20190819204504.GB10075@hsiangkao-HP-ZHAN-66-Pro-G1>
Gao Xiang,
On Mon, Aug 19, 2019 at 10:45 PM Gao Xiang via Linux-erofs
<linux-erofs@lists.ozlabs.org> wrote:
> > struct erofs_super_block has "checksum" and "features" fields,
> > but they are not used in the source.
> > What is the plan for these?
>
> Yes, both will be used laterly (features is used for compatible
> features, we already have some incompatible features in 5.3).
Good. :-)
I suggest to check the fields being 0 right now.
Otherwise you are in danger that they get burned if an mkfs.erofs does not
initialize the fields.
--
Thanks,
//richard
next prev parent reply other threads:[~2019-08-21 21:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 17:10 erofs: Question on unused fields in on-disk structs Richard Weinberger
2019-08-19 17:10 ` Richard Weinberger
2019-08-19 17:10 ` Richard Weinberger
2019-08-19 20:45 ` Gao Xiang
2019-08-19 20:45 ` Gao Xiang via Linux-erofs
2019-08-21 21:37 ` Richard Weinberger [this message]
2019-08-21 21:37 ` Richard Weinberger
2019-08-21 22:03 ` Gao Xiang
2019-08-21 22:03 ` Gao Xiang via Linux-erofs
2019-08-22 8:33 ` Richard Weinberger
2019-08-22 8:33 ` Richard Weinberger
2019-08-22 9:05 ` Gao Xiang
2019-08-22 9:05 ` Gao Xiang
2019-08-22 9:08 ` Gao Xiang
2019-08-22 9:08 ` Gao Xiang
2019-08-22 14:21 ` Theodore Y. Ts'o
2019-08-22 14:21 ` Theodore Y. Ts'o
2019-08-22 14:29 ` Richard Weinberger
2019-08-22 14:29 ` Richard Weinberger
2019-08-22 14:38 ` Gao Xiang
2019-08-22 14:38 ` Gao Xiang
2019-08-22 14:34 ` Gao Xiang
2019-08-22 14:34 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLxGvxr2UMeVa29M9pjLtWMFPz7w6udRV38CRxEF1moyA9_Rw@mail.gmail.com \
--to=richard.weinberger@gmail.com \
--cc=hsiangkao@aol.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.