All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: Johannes Berg <johannes@sipsolutions.net>,
	"David S. Miller" <davem@davemloft.net>
Cc: Chen-Yu Tsai <wens@csie.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	linux-wireless@vger.kernel.org
Subject: [PATCH RFC 2/6] net: rfkill: gpio: use clk_prepare_enable/clk_disable_unprepare
Date: Fri, 17 Jan 2014 14:47:27 +0800	[thread overview]
Message-ID: <1389941251-32692-3-git-send-email-wens@csie.org> (raw)
In-Reply-To: <1389941251-32692-1-git-send-email-wens@csie.org>

rfkill-gpio calls clk_enable() without first calling clk_prepare(),
resulting in a warning and no effect. Switch to clk_prepare_enable()
and clk_disable_unprepare.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 net/rfkill/rfkill-gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index 97ec12a..c7081b7 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -51,10 +51,10 @@ static int rfkill_gpio_set_power(void *data, bool blocked)
 		gpiod_set_value(rfkill->shutdown_gpio, 0);
 		gpiod_set_value(rfkill->reset_gpio, 0);
 		if (!IS_ERR(rfkill->clk) && rfkill->clk_enabled)
-			clk_disable(rfkill->clk);
+			clk_disable_unprepare(rfkill->clk);
 	} else {
 		if (!IS_ERR(rfkill->clk) && !rfkill->clk_enabled)
-			clk_enable(rfkill->clk);
+			clk_prepare_enable(rfkill->clk);
 		gpiod_set_value(rfkill->reset_gpio, 1);
 		gpiod_set_value(rfkill->shutdown_gpio, 1);
 	}
-- 
1.8.5.2


WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH RFC 2/6] net: rfkill: gpio: use clk_prepare_enable/clk_disable_unprepare
Date: Fri, 17 Jan 2014 14:47:27 +0800	[thread overview]
Message-ID: <1389941251-32692-3-git-send-email-wens@csie.org> (raw)
In-Reply-To: <1389941251-32692-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>

rfkill-gpio calls clk_enable() without first calling clk_prepare(),
resulting in a warning and no effect. Switch to clk_prepare_enable()
and clk_disable_unprepare.

Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
---
 net/rfkill/rfkill-gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index 97ec12a..c7081b7 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -51,10 +51,10 @@ static int rfkill_gpio_set_power(void *data, bool blocked)
 		gpiod_set_value(rfkill->shutdown_gpio, 0);
 		gpiod_set_value(rfkill->reset_gpio, 0);
 		if (!IS_ERR(rfkill->clk) && rfkill->clk_enabled)
-			clk_disable(rfkill->clk);
+			clk_disable_unprepare(rfkill->clk);
 	} else {
 		if (!IS_ERR(rfkill->clk) && !rfkill->clk_enabled)
-			clk_enable(rfkill->clk);
+			clk_prepare_enable(rfkill->clk);
 		gpiod_set_value(rfkill->reset_gpio, 1);
 		gpiod_set_value(rfkill->shutdown_gpio, 1);
 	}
-- 
1.8.5.2

WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 2/6] net: rfkill: gpio: use clk_prepare_enable/clk_disable_unprepare
Date: Fri, 17 Jan 2014 14:47:27 +0800	[thread overview]
Message-ID: <1389941251-32692-3-git-send-email-wens@csie.org> (raw)
In-Reply-To: <1389941251-32692-1-git-send-email-wens@csie.org>

rfkill-gpio calls clk_enable() without first calling clk_prepare(),
resulting in a warning and no effect. Switch to clk_prepare_enable()
and clk_disable_unprepare.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 net/rfkill/rfkill-gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index 97ec12a..c7081b7 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -51,10 +51,10 @@ static int rfkill_gpio_set_power(void *data, bool blocked)
 		gpiod_set_value(rfkill->shutdown_gpio, 0);
 		gpiod_set_value(rfkill->reset_gpio, 0);
 		if (!IS_ERR(rfkill->clk) && rfkill->clk_enabled)
-			clk_disable(rfkill->clk);
+			clk_disable_unprepare(rfkill->clk);
 	} else {
 		if (!IS_ERR(rfkill->clk) && !rfkill->clk_enabled)
-			clk_enable(rfkill->clk);
+			clk_prepare_enable(rfkill->clk);
 		gpiod_set_value(rfkill->reset_gpio, 1);
 		gpiod_set_value(rfkill->shutdown_gpio, 1);
 	}
-- 
1.8.5.2

  parent reply	other threads:[~2014-01-17  6:55 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-17  6:47 [PATCH RFC 0/6] net: rfkill: gpio: Add device tree support Chen-Yu Tsai
2014-01-17  6:47 ` Chen-Yu Tsai
2014-01-17  6:47 ` Chen-Yu Tsai
2014-01-17  6:47 ` [PATCH RFC 1/6] net: rfkill: gpio: fix gpio name buffer size off by 1 Chen-Yu Tsai
2014-01-17  6:47   ` Chen-Yu Tsai
2014-01-17  6:47   ` Chen-Yu Tsai
2014-01-17  9:46   ` David Laight
2014-01-17  9:46     ` David Laight
2014-01-17  9:46     ` David Laight
2014-01-17  9:59     ` Chen-Yu Tsai
2014-01-17  9:59       ` Chen-Yu Tsai
2014-01-17  9:59       ` Chen-Yu Tsai
2014-01-17  9:59       ` Chen-Yu Tsai
2014-01-17  6:47 ` Chen-Yu Tsai [this message]
2014-01-17  6:47   ` [PATCH RFC 2/6] net: rfkill: gpio: use clk_prepare_enable/clk_disable_unprepare Chen-Yu Tsai
2014-01-17  6:47   ` Chen-Yu Tsai
2014-01-17  6:47 ` [PATCH RFC 3/6] net: rfkill: gpio: fix reversed clock enable state Chen-Yu Tsai
2014-01-17  6:47   ` Chen-Yu Tsai
2014-01-17  6:47   ` Chen-Yu Tsai
2014-01-17  6:47 ` [PATCH RFC 4/6] net: rfkill: gpio: add device tree support Chen-Yu Tsai
2014-01-17  6:47   ` Chen-Yu Tsai
2014-01-17  6:47   ` Chen-Yu Tsai
2014-01-17 16:47   ` Arnd Bergmann
2014-01-17 16:47     ` Arnd Bergmann
2014-01-17 16:47     ` Arnd Bergmann
2014-01-17 17:43     ` Chen-Yu Tsai
2014-01-17 17:43       ` Chen-Yu Tsai
2014-01-17 17:43       ` Chen-Yu Tsai
2014-01-17 20:13       ` Arnd Bergmann
2014-01-17 20:13         ` Arnd Bergmann
2014-01-17 20:13         ` Arnd Bergmann
2014-01-17 23:11       ` Linus Walleij
2014-01-17 23:11         ` Linus Walleij
2014-01-17 23:11         ` Linus Walleij
2014-01-18  4:41         ` Chen-Yu Tsai
2014-01-18  4:41           ` Chen-Yu Tsai
2014-01-18  4:41           ` Chen-Yu Tsai
2014-01-20  8:10         ` Heikki Krogerus
2014-01-20  8:10           ` Heikki Krogerus
2014-01-20  8:10           ` Heikki Krogerus
2014-01-21  3:11         ` Alexandre Courbot
2014-01-21  3:11           ` Alexandre Courbot
2014-01-21  9:35           ` Linus Walleij
2014-01-21  9:35             ` Linus Walleij
2014-01-21  9:35             ` Linus Walleij
2014-01-21 12:35             ` Arnd Bergmann
2014-01-21 12:35               ` Arnd Bergmann
2014-01-21 12:35               ` Arnd Bergmann
2014-01-21 14:53               ` Alexandre Courbot
2014-01-21 14:53                 ` Alexandre Courbot
2014-01-21 14:53                 ` Alexandre Courbot
2014-01-21 14:53                 ` Alexandre Courbot
2014-01-21 15:25                 ` Mika Westerberg
2014-01-21 15:25                   ` Mika Westerberg
2014-01-21 15:25                   ` Mika Westerberg
2014-01-21 18:50                 ` Arnd Bergmann
2014-01-21 18:50                   ` Arnd Bergmann
2014-01-21 18:50                   ` Arnd Bergmann
2014-01-21 18:50                   ` Arnd Bergmann
2014-01-22 12:38                   ` Mark Brown
2014-01-22 12:38                     ` Mark Brown
2014-01-22 12:38                     ` Mark Brown
2014-01-22 12:38                     ` Mark Brown
2014-01-22  9:54                 ` Linus Walleij
2014-01-22  9:54                   ` Linus Walleij
2014-01-22  9:54                   ` Linus Walleij
2014-01-22  9:54                   ` Linus Walleij
2014-01-22  9:58                 ` Linus Walleij
2014-01-22  9:58                   ` Linus Walleij
2014-01-22  9:58                   ` Linus Walleij
2014-01-22  9:58                   ` Linus Walleij
2014-01-22 11:00                   ` Mika Westerberg
2014-01-22 11:00                     ` Mika Westerberg
2014-01-22 11:00                     ` Mika Westerberg
2014-01-22 11:00                     ` Mika Westerberg
2014-01-27 14:24   ` Maxime Ripard
2014-01-27 14:24     ` Maxime Ripard
2014-01-27 14:24     ` Maxime Ripard
2014-01-29  4:01     ` [linux-sunxi] " Chen-Yu Tsai
2014-01-29  4:01       ` Chen-Yu Tsai
2014-01-29  4:01       ` Chen-Yu Tsai
2014-01-17  6:47 ` [PATCH RFC 5/6] net: rfkill: gpio: add clock-frequency device tree property Chen-Yu Tsai
2014-01-17  6:47   ` Chen-Yu Tsai
2014-01-17  6:47   ` Chen-Yu Tsai
2014-01-17  6:47 ` [PATCH RFC 6/6] ARM: sun7i: cubietruck: enable bluetooth module Chen-Yu Tsai
2014-01-17  6:47   ` Chen-Yu Tsai
2014-01-17  6:47   ` Chen-Yu Tsai
2014-01-17 20:26 ` [PATCH RFC 0/6] net: rfkill: gpio: Add device tree support Johannes Berg
2014-01-17 20:26   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389941251-32692-3-git-send-email-wens@csie.org \
    --to=wens@csie.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.