From: Namjae Jeon <linkinjeon@gmail.com> To: david@fromorbit.com, tytso@mit.edu Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, a.sangwan@samsung.com, bfoster@redhat.com, Namjae Jeon <linkinjeon@gmail.com>, Namjae Jeon <namjae.jeon@samsung.com> Subject: [PATCH v9 1/11] fs: Add support FALLOC_FL_INSERT_RANGE for fallocate Date: Thu, 22 Jan 2015 00:11:56 +0900 [thread overview] Message-ID: <1421853126-4505-2-git-send-email-linkinjeon@gmail.com> (raw) In-Reply-To: <1421853126-4505-1-git-send-email-linkinjeon@gmail.com> From: Namjae Jeon <namjae.jeon@samsung.com> FALLOC_FL_INSERT_RANGE command is the opposite command of FALLOC_FL_COLLAPSE_RANGE that is needed for advertisers or someone who want to add some data in the middle of file. FALLOC_FL_INSERT_RANGE will create space for writing new data within a file after shifting extents to right as given length. and this command also has same limitation as FALLOC_FL_COLLAPSE_RANGE, that is block boundary and use ftruncate(2) for crosses EOF. Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com> Cc: Brian Foster<bfoster@redhat.com> --- fs/open.c | 8 +++++++- include/uapi/linux/falloc.h | 17 +++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/fs/open.c b/fs/open.c index 813be03..762fb45 100644 --- a/fs/open.c +++ b/fs/open.c @@ -232,7 +232,8 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) /* Return error if mode is not supported */ if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | - FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE)) + FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE | + FALLOC_FL_INSERT_RANGE)) return -EOPNOTSUPP; /* Punch hole and zero range are mutually exclusive */ @@ -250,6 +251,11 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) (mode & ~FALLOC_FL_COLLAPSE_RANGE)) return -EINVAL; + /* Insert range should only be used exclusively. */ + if ((mode & FALLOC_FL_INSERT_RANGE) && + (mode & ~FALLOC_FL_INSERT_RANGE)) + return -EINVAL; + if (!(file->f_mode & FMODE_WRITE)) return -EBADF; diff --git a/include/uapi/linux/falloc.h b/include/uapi/linux/falloc.h index d1197ae..3e445a7 100644 --- a/include/uapi/linux/falloc.h +++ b/include/uapi/linux/falloc.h @@ -41,4 +41,21 @@ */ #define FALLOC_FL_ZERO_RANGE 0x10 +/* + * FALLOC_FL_INSERT_RANGE is use to insert space within the file size without + * overwriting any existing data. The contents of the file beyond offset are + * shifted towards right by len bytes to create a hole. As such, this + * operation will increase the size of the file by len bytes. + * + * Different filesystems may implement different limitations on the granularity + * of the operation. Most will limit operations to filesystem block size + * boundaries, but this boundary may be larger or smaller depending on + * the filesystem and/or the configuration of the filesystem or file. + * + * Attempting to insert space using this flag at OR beyond the end of + * the file is considered an illegal operation - just use ftruncate(2) or + * fallocate(2) with mode 0 for such type of operations. + */ +#define FALLOC_FL_INSERT_RANGE 0x20 + #endif /* _UAPI_FALLOC_H_ */ -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Namjae Jeon <linkinjeon@gmail.com> To: david@fromorbit.com, tytso@mit.edu Cc: Namjae Jeon <linkinjeon@gmail.com>, Namjae Jeon <namjae.jeon@samsung.com>, bfoster@redhat.com, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, a.sangwan@samsung.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: [PATCH v9 1/11] fs: Add support FALLOC_FL_INSERT_RANGE for fallocate Date: Thu, 22 Jan 2015 00:11:56 +0900 [thread overview] Message-ID: <1421853126-4505-2-git-send-email-linkinjeon@gmail.com> (raw) In-Reply-To: <1421853126-4505-1-git-send-email-linkinjeon@gmail.com> From: Namjae Jeon <namjae.jeon@samsung.com> FALLOC_FL_INSERT_RANGE command is the opposite command of FALLOC_FL_COLLAPSE_RANGE that is needed for advertisers or someone who want to add some data in the middle of file. FALLOC_FL_INSERT_RANGE will create space for writing new data within a file after shifting extents to right as given length. and this command also has same limitation as FALLOC_FL_COLLAPSE_RANGE, that is block boundary and use ftruncate(2) for crosses EOF. Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com> Cc: Brian Foster<bfoster@redhat.com> --- fs/open.c | 8 +++++++- include/uapi/linux/falloc.h | 17 +++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/fs/open.c b/fs/open.c index 813be03..762fb45 100644 --- a/fs/open.c +++ b/fs/open.c @@ -232,7 +232,8 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) /* Return error if mode is not supported */ if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | - FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE)) + FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE | + FALLOC_FL_INSERT_RANGE)) return -EOPNOTSUPP; /* Punch hole and zero range are mutually exclusive */ @@ -250,6 +251,11 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len) (mode & ~FALLOC_FL_COLLAPSE_RANGE)) return -EINVAL; + /* Insert range should only be used exclusively. */ + if ((mode & FALLOC_FL_INSERT_RANGE) && + (mode & ~FALLOC_FL_INSERT_RANGE)) + return -EINVAL; + if (!(file->f_mode & FMODE_WRITE)) return -EBADF; diff --git a/include/uapi/linux/falloc.h b/include/uapi/linux/falloc.h index d1197ae..3e445a7 100644 --- a/include/uapi/linux/falloc.h +++ b/include/uapi/linux/falloc.h @@ -41,4 +41,21 @@ */ #define FALLOC_FL_ZERO_RANGE 0x10 +/* + * FALLOC_FL_INSERT_RANGE is use to insert space within the file size without + * overwriting any existing data. The contents of the file beyond offset are + * shifted towards right by len bytes to create a hole. As such, this + * operation will increase the size of the file by len bytes. + * + * Different filesystems may implement different limitations on the granularity + * of the operation. Most will limit operations to filesystem block size + * boundaries, but this boundary may be larger or smaller depending on + * the filesystem and/or the configuration of the filesystem or file. + * + * Attempting to insert space using this flag at OR beyond the end of + * the file is considered an illegal operation - just use ftruncate(2) or + * fallocate(2) with mode 0 for such type of operations. + */ +#define FALLOC_FL_INSERT_RANGE 0x20 + #endif /* _UAPI_FALLOC_H_ */ -- 1.7.9.5 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-01-21 15:13 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-21 15:11 [PATCH v9 0/11] fs: Introduce FALLOC_FL_INSERT_RANGE for fallocate Namjae Jeon 2015-01-21 15:11 ` Namjae Jeon 2015-01-21 15:11 ` Namjae Jeon [this message] 2015-01-21 15:11 ` [PATCH v9 1/11] fs: Add support " Namjae Jeon 2015-01-21 15:11 ` [PATCH v9 2/11] xfs: " Namjae Jeon 2015-01-21 15:11 ` Namjae Jeon 2015-01-21 15:11 ` [PATCH v9 3/11] ext4: " Namjae Jeon 2015-01-21 15:11 ` Namjae Jeon 2015-01-21 15:11 ` [PATCH v9 4/11] xfsprogs: xfs_io: add finsert command for insert range Namjae Jeon 2015-01-21 15:11 ` Namjae Jeon 2015-02-05 23:40 ` Dave Chinner 2015-02-05 23:40 ` Dave Chinner 2015-02-06 3:11 ` Dave Chinner 2015-02-06 3:11 ` Dave Chinner 2015-02-06 4:27 ` Namjae Jeon 2015-02-06 4:27 ` Namjae Jeon 2015-01-21 15:12 ` [PATCH v9 5/11] xfstests: generic/039: Standard insert range tests Namjae Jeon 2015-01-21 15:12 ` Namjae Jeon 2015-01-21 15:12 ` [PATCH v9 6/11] xfstests: generic/040: Delayed allocation insert range Namjae Jeon 2015-01-21 15:12 ` Namjae Jeon 2015-01-21 15:12 ` [PATCH v9 7/11] xfstests: generic/041: Multi insert range tests Namjae Jeon 2015-01-21 15:12 ` Namjae Jeon 2015-01-21 15:12 ` [PATCH v9 8/11] xfstests: generic/042: Delayed allocation multi insert Namjae Jeon 2015-01-21 15:12 ` Namjae Jeon 2015-01-21 15:12 ` [PATCH v9 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls Namjae Jeon 2015-01-21 15:12 ` Namjae Jeon 2015-01-21 15:12 ` [PATCH v9 10/11] xfstests: fsstress: Add fallocate insert range operation Namjae Jeon 2015-01-21 15:12 ` Namjae Jeon 2015-01-21 15:12 ` [PATCH v9 11/11] xfstests: fsx: " Namjae Jeon 2015-01-21 15:12 ` Namjae Jeon 2015-01-22 8:16 ` [PATCH v9 0/11] fs: Introduce FALLOC_FL_INSERT_RANGE for fallocate Michael Kerrisk 2015-01-22 8:16 ` Michael Kerrisk 2015-01-22 8:52 ` Namjae Jeon 2015-01-22 8:52 ` Namjae Jeon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1421853126-4505-2-git-send-email-linkinjeon@gmail.com \ --to=linkinjeon@gmail.com \ --cc=a.sangwan@samsung.com \ --cc=bfoster@redhat.com \ --cc=david@fromorbit.com \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=namjae.jeon@samsung.com \ --cc=tytso@mit.edu \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.