All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sameer Pujar <spujar@nvidia.com>
To: <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
	<kuninori.morimoto.gx@renesas.com>, <robh+dt@kernel.org>,
	<lgirdwood@gmail.com>
Cc: <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
	<alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
	<mkumard@nvidia.com>, <viswanathl@nvidia.com>,
	<rlokhande@nvidia.com>, <dramesh@nvidia.com>,
	<atalambedu@nvidia.com>, <nwartikar@nvidia.com>,
	<swarren@nvidia.com>, <nicoleotsuka@gmail.com>,
	Sameer Pujar <spujar@nvidia.com>
Subject: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM
Date: Wed, 5 Aug 2020 10:54:18 +0530	[thread overview]
Message-ID: <1596605064-27748-4-git-send-email-spujar@nvidia.com> (raw)
In-Reply-To: <1596605064-27748-1-git-send-email-spujar@nvidia.com>

PCM devices are created for FE dai links with 'no-pcm' flag as '0'.
Such DAI links have CPU component which implement either pcm_construct()
or pcm_new() at component or dai level respectively. Based on this,
current patch exposes a helper function to identify such components
and populate 'no_pcm' flag for DPCM DAI link.

This helps to have BE<->BE component links where PCM devices need
not be created for CPU component involved in such links.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
 sound/soc/generic/audio-graph-card.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
index 1e20562..93bddf6 100644
--- a/sound/soc/generic/audio-graph-card.c
+++ b/sound/soc/generic/audio-graph-card.c
@@ -111,6 +111,17 @@ static int graph_get_dai_id(struct device_node *ep)
 	return id;
 }
 
+static bool soc_component_is_pcm(struct snd_soc_dai_link_component *dlc)
+{
+	struct snd_soc_dai *dai = snd_soc_find_dai(dlc);
+
+	if (dai && (dai->component->driver->pcm_construct ||
+		    dai->driver->pcm_new))
+		return true;
+
+	return false;
+}
+
 static int asoc_simple_parse_dai(struct device_node *ep,
 				 struct snd_soc_dai_link_component *dlc,
 				 int *is_single_link)
@@ -259,6 +270,16 @@ static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv,
 		if (ret < 0)
 			goto out_put_node;
 
+		/*
+		 * In BE<->BE connections it is not required to create
+		 * PCM devices at CPU end of the dai link and thus 'no_pcm'
+		 * flag needs to be set. It is useful when there are many
+		 * BE components and some of these have to be connected to
+		 * form a valid audio path.
+		 */
+		if (!soc_component_is_pcm(cpus))
+			dai_link->no_pcm = 1;
+
 		/* card->num_links includes Codec */
 		asoc_simple_canonicalize_cpu(dai_link, is_single_links);
 	} else {
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Sameer Pujar <spujar@nvidia.com>
To: <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
	<kuninori.morimoto.gx@renesas.com>, <robh+dt@kernel.org>,
	<lgirdwood@gmail.com>
Cc: nicoleotsuka@gmail.com, alsa-devel@alsa-project.org,
	swarren@nvidia.com, Sameer Pujar <spujar@nvidia.com>,
	nwartikar@nvidia.com, linux-kernel@vger.kernel.org,
	jonathanh@nvidia.com, viswanathl@nvidia.com, sharadg@nvidia.com,
	thierry.reding@gmail.com, atalambedu@nvidia.com,
	linux-tegra@vger.kernel.org, rlokhande@nvidia.com,
	mkumard@nvidia.com, dramesh@nvidia.com
Subject: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM
Date: Wed, 5 Aug 2020 10:54:18 +0530	[thread overview]
Message-ID: <1596605064-27748-4-git-send-email-spujar@nvidia.com> (raw)
In-Reply-To: <1596605064-27748-1-git-send-email-spujar@nvidia.com>

PCM devices are created for FE dai links with 'no-pcm' flag as '0'.
Such DAI links have CPU component which implement either pcm_construct()
or pcm_new() at component or dai level respectively. Based on this,
current patch exposes a helper function to identify such components
and populate 'no_pcm' flag for DPCM DAI link.

This helps to have BE<->BE component links where PCM devices need
not be created for CPU component involved in such links.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
 sound/soc/generic/audio-graph-card.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
index 1e20562..93bddf6 100644
--- a/sound/soc/generic/audio-graph-card.c
+++ b/sound/soc/generic/audio-graph-card.c
@@ -111,6 +111,17 @@ static int graph_get_dai_id(struct device_node *ep)
 	return id;
 }
 
+static bool soc_component_is_pcm(struct snd_soc_dai_link_component *dlc)
+{
+	struct snd_soc_dai *dai = snd_soc_find_dai(dlc);
+
+	if (dai && (dai->component->driver->pcm_construct ||
+		    dai->driver->pcm_new))
+		return true;
+
+	return false;
+}
+
 static int asoc_simple_parse_dai(struct device_node *ep,
 				 struct snd_soc_dai_link_component *dlc,
 				 int *is_single_link)
@@ -259,6 +270,16 @@ static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv,
 		if (ret < 0)
 			goto out_put_node;
 
+		/*
+		 * In BE<->BE connections it is not required to create
+		 * PCM devices at CPU end of the dai link and thus 'no_pcm'
+		 * flag needs to be set. It is useful when there are many
+		 * BE components and some of these have to be connected to
+		 * form a valid audio path.
+		 */
+		if (!soc_component_is_pcm(cpus))
+			dai_link->no_pcm = 1;
+
 		/* card->num_links includes Codec */
 		asoc_simple_canonicalize_cpu(dai_link, is_single_links);
 	} else {
-- 
2.7.4


  parent reply	other threads:[~2020-08-05  5:25 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05  5:24 [PATCH v2 0/9] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-08-05  5:24 ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 1/9] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 2/9] ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-18  2:39   ` Kuninori Morimoto
2020-08-18  2:39     ` Kuninori Morimoto
2020-08-05  5:24 ` Sameer Pujar [this message]
2020-08-05  5:24   ` [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-08-18  2:41   ` Kuninori Morimoto
2020-08-18  2:41     ` Kuninori Morimoto
2020-08-18  8:06     ` Sameer Pujar
2020-08-18  8:06       ` Sameer Pujar
2020-08-18  5:23   ` Kuninori Morimoto
2020-08-18  5:23     ` Kuninori Morimoto
2020-08-18  8:04     ` Sameer Pujar
2020-08-18  8:04       ` Sameer Pujar
2020-08-25  3:25       ` Sameer Pujar
2020-08-25  4:54         ` Kuninori Morimoto
2020-08-25  4:54           ` Kuninori Morimoto
2020-08-25  5:15           ` Sameer Pujar
2020-08-25  5:15             ` Sameer Pujar
2020-08-25  5:40             ` Kuninori Morimoto
2020-08-25  5:40               ` Kuninori Morimoto
2020-08-25  5:53               ` Sameer Pujar
2020-08-25  5:53                 ` Sameer Pujar
2020-08-25  6:46                 ` Kuninori Morimoto
2020-08-25  6:46                   ` Kuninori Morimoto
2020-08-25  7:18                   ` Sameer Pujar
2020-08-25  7:18                     ` Sameer Pujar
2020-08-26 23:12                     ` Kuninori Morimoto
2020-08-26 23:12                       ` Kuninori Morimoto
2020-08-29 10:52                       ` Sameer Pujar
2020-08-29 10:52                         ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 4/9] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 5/9] ASoC: dt-bindings: audio-graph-card: Support for component chaining Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 6/9] ASoC: audio-graph: Add support " Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 7/9] ASoC: audio-graph: Support empty Codec endpoint Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 8/9] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 9/9] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-17  1:53 ` [PATCH v2 0/9] Audio graph card updates and usage with Tegra210 audio Kuninori Morimoto
2020-08-17  1:53   ` Kuninori Morimoto
2020-08-20  9:02   ` Sameer Pujar
2020-08-20  9:02     ` Sameer Pujar
2020-08-20 23:00     ` Kuninori Morimoto
2020-08-20 23:00       ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1596605064-27748-4-git-send-email-spujar@nvidia.com \
    --to=spujar@nvidia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=atalambedu@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=dramesh@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkumard@nvidia.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=nwartikar@nvidia.com \
    --cc=perex@perex.cz \
    --cc=rlokhande@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=sharadg@nvidia.com \
    --cc=swarren@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    --cc=viswanathl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.