All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Zhu <hongxing.zhu@nxp.com>
To: p.zabel@pengutronix.de, l.stach@pengutronix.de,
	bhelgaas@google.com, lorenzo.pieralisi@arm.com, robh@kernel.org,
	shawnguo@kernel.org, vkoul@kernel.org,
	alexander.stein@ew.tq-group.com, marex@denx.de,
	richard.leitner@linux.dev
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	linux-imx@nxp.com, Richard Zhu <hongxing.zhu@nxp.com>
Subject: [PATCH v5 4/7] reset: imx7: Fix the iMX8MP PCIe PHY PERST support
Date: Tue, 30 Aug 2022 15:46:01 +0800	[thread overview]
Message-ID: <1661845564-11373-5-git-send-email-hongxing.zhu@nxp.com> (raw)
In-Reply-To: <1661845564-11373-1-git-send-email-hongxing.zhu@nxp.com>

On i.MX7/iMX8MM/iMX8MQ, the initialized default value of PERST bit(BIT3)
of SRC_PCIEPHY_RCR is 1b'1.
But i.MX8MP has one inversed default value 1b'0 of PERST bit.

And the PERST bit should be kept 1b'1 after power and clocks are stable.
So fix the i.MX8MP PCIe PHY PERST support here.

Fixes: e08672c03981 ("reset: imx7: Add support for i.MX8MP SoC")
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Tested-by: Marek Vasut <marex@denx.de>
Tested-by: Richard Leitner <richard.leitner@skidata.com>
Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/reset/reset-imx7.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c
index 185a333df66c..d2408725eb2c 100644
--- a/drivers/reset/reset-imx7.c
+++ b/drivers/reset/reset-imx7.c
@@ -329,6 +329,7 @@ static int imx8mp_reset_set(struct reset_controller_dev *rcdev,
 		break;
 
 	case IMX8MP_RESET_PCIE_CTRL_APPS_EN:
+	case IMX8MP_RESET_PCIEPHY_PERST:
 		value = assert ? 0 : bit;
 		break;
 	}
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Richard Zhu <hongxing.zhu@nxp.com>
To: p.zabel@pengutronix.de, l.stach@pengutronix.de,
	bhelgaas@google.com, lorenzo.pieralisi@arm.com, robh@kernel.org,
	shawnguo@kernel.org, vkoul@kernel.org,
	alexander.stein@ew.tq-group.com, marex@denx.de,
	richard.leitner@linux.dev
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	linux-imx@nxp.com, Richard Zhu <hongxing.zhu@nxp.com>
Subject: [PATCH v5 4/7] reset: imx7: Fix the iMX8MP PCIe PHY PERST support
Date: Tue, 30 Aug 2022 15:46:01 +0800	[thread overview]
Message-ID: <1661845564-11373-5-git-send-email-hongxing.zhu@nxp.com> (raw)
In-Reply-To: <1661845564-11373-1-git-send-email-hongxing.zhu@nxp.com>

On i.MX7/iMX8MM/iMX8MQ, the initialized default value of PERST bit(BIT3)
of SRC_PCIEPHY_RCR is 1b'1.
But i.MX8MP has one inversed default value 1b'0 of PERST bit.

And the PERST bit should be kept 1b'1 after power and clocks are stable.
So fix the i.MX8MP PCIe PHY PERST support here.

Fixes: e08672c03981 ("reset: imx7: Add support for i.MX8MP SoC")
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Tested-by: Marek Vasut <marex@denx.de>
Tested-by: Richard Leitner <richard.leitner@skidata.com>
Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/reset/reset-imx7.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c
index 185a333df66c..d2408725eb2c 100644
--- a/drivers/reset/reset-imx7.c
+++ b/drivers/reset/reset-imx7.c
@@ -329,6 +329,7 @@ static int imx8mp_reset_set(struct reset_controller_dev *rcdev,
 		break;
 
 	case IMX8MP_RESET_PCIE_CTRL_APPS_EN:
+	case IMX8MP_RESET_PCIEPHY_PERST:
 		value = assert ? 0 : bit;
 		break;
 	}
-- 
2.25.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Richard Zhu <hongxing.zhu@nxp.com>
To: p.zabel@pengutronix.de, l.stach@pengutronix.de,
	bhelgaas@google.com, lorenzo.pieralisi@arm.com, robh@kernel.org,
	shawnguo@kernel.org, vkoul@kernel.org,
	alexander.stein@ew.tq-group.com, marex@denx.de,
	richard.leitner@linux.dev
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	linux-imx@nxp.com, Richard Zhu <hongxing.zhu@nxp.com>
Subject: [PATCH v5 4/7] reset: imx7: Fix the iMX8MP PCIe PHY PERST support
Date: Tue, 30 Aug 2022 15:46:01 +0800	[thread overview]
Message-ID: <1661845564-11373-5-git-send-email-hongxing.zhu@nxp.com> (raw)
In-Reply-To: <1661845564-11373-1-git-send-email-hongxing.zhu@nxp.com>

On i.MX7/iMX8MM/iMX8MQ, the initialized default value of PERST bit(BIT3)
of SRC_PCIEPHY_RCR is 1b'1.
But i.MX8MP has one inversed default value 1b'0 of PERST bit.

And the PERST bit should be kept 1b'1 after power and clocks are stable.
So fix the i.MX8MP PCIe PHY PERST support here.

Fixes: e08672c03981 ("reset: imx7: Add support for i.MX8MP SoC")
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Tested-by: Marek Vasut <marex@denx.de>
Tested-by: Richard Leitner <richard.leitner@skidata.com>
Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/reset/reset-imx7.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c
index 185a333df66c..d2408725eb2c 100644
--- a/drivers/reset/reset-imx7.c
+++ b/drivers/reset/reset-imx7.c
@@ -329,6 +329,7 @@ static int imx8mp_reset_set(struct reset_controller_dev *rcdev,
 		break;
 
 	case IMX8MP_RESET_PCIE_CTRL_APPS_EN:
+	case IMX8MP_RESET_PCIEPHY_PERST:
 		value = assert ? 0 : bit;
 		break;
 	}
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-08-30  8:04 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30  7:45 [PATCH v5 0/7] Add the iMX8MP PCIe support Richard Zhu
2022-08-30  7:45 ` Richard Zhu
2022-08-30  7:45 ` Richard Zhu
2022-08-30  7:45 ` [PATCH v5 1/7] dt-binding: phy: Add iMX8MP PCIe PHY binding Richard Zhu
2022-08-30  7:45   ` Richard Zhu
2022-08-30  7:45   ` Richard Zhu
2022-08-30  7:45 ` [PATCH v5 2/7] arm64: dts: imx8mp: Add iMX8MP PCIe support Richard Zhu
2022-08-30  7:45   ` Richard Zhu
2022-08-30  7:45   ` Richard Zhu
2022-08-30  7:46 ` [PATCH v5 3/7] arm64: dts: imx8mp-evk: Add " Richard Zhu
2022-08-30  7:46   ` Richard Zhu
2022-08-30  7:46   ` Richard Zhu
2022-08-31 10:18   ` Marcel Ziswiler
2022-08-31 10:18     ` Marcel Ziswiler
2022-08-31 10:18     ` Marcel Ziswiler
2022-09-01  1:28     ` Hongxing Zhu
2022-09-01  1:28       ` Hongxing Zhu
2022-09-01  1:28       ` Hongxing Zhu
2022-08-30  7:46 ` Richard Zhu [this message]
2022-08-30  7:46   ` [PATCH v5 4/7] reset: imx7: Fix the iMX8MP PCIe PHY PERST support Richard Zhu
2022-08-30  7:46   ` Richard Zhu
2022-08-30 16:46   ` Philipp Zabel
2022-08-30 16:46     ` Philipp Zabel
2022-08-30 16:46     ` Philipp Zabel
2022-08-31  0:38     ` Hongxing Zhu
2022-08-31  0:38       ` Hongxing Zhu
2022-08-31  0:38       ` Hongxing Zhu
2022-08-30  7:46 ` [PATCH v5 5/7] soc: imx: imx8mp-blk-ctrl: handle PCIe PHY resets Richard Zhu
2022-08-30  7:46   ` Richard Zhu
2022-08-30  7:46   ` Richard Zhu
2022-08-31  8:36   ` Lucas Stach
2022-08-31  8:36     ` Lucas Stach
2022-08-31  8:36     ` Lucas Stach
2022-09-01  1:28     ` Hongxing Zhu
2022-09-01  1:28       ` Hongxing Zhu
2022-09-01  1:28       ` Hongxing Zhu
2022-08-30  7:46 ` [PATCH v5 6/7] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY support Richard Zhu
2022-08-30  7:46   ` Richard Zhu
2022-08-30  7:46   ` Richard Zhu
2022-08-30 13:07   ` Lucas Stach
2022-08-30 13:07     ` Lucas Stach
2022-08-30 13:07     ` Lucas Stach
2022-08-31  6:16     ` Hongxing Zhu
2022-08-31  6:16       ` Hongxing Zhu
2022-08-31  6:16       ` Hongxing Zhu
2022-08-31  8:34       ` Lucas Stach
2022-08-31  8:34         ` Lucas Stach
2022-08-31  8:34         ` Lucas Stach
2022-09-01  1:28         ` Hongxing Zhu
2022-09-01  1:28           ` Hongxing Zhu
2022-09-01  1:28           ` Hongxing Zhu
2022-08-30  7:46 ` [PATCH v5 7/7] PCI: imx6: Add iMX8MP PCIe support Richard Zhu
2022-08-30  7:46   ` Richard Zhu
2022-08-30  7:46   ` Richard Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1661845564-11373-5-git-send-email-hongxing.zhu@nxp.com \
    --to=hongxing.zhu@nxp.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=marex@denx.de \
    --cc=p.zabel@pengutronix.de \
    --cc=richard.leitner@linux.dev \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.