All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@akamai.com>
To: mcgrof@kernel.org
Cc: jim.cromie@gmail.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org
Subject: [PATCH v3 1/2] dyndbg: remove unused 'base' arg from __ddebug_add_module()
Date: Fri,  3 Mar 2023 11:50:55 -0500	[thread overview]
Message-ID: <16bcadc508cae9c93249d16a499fb714edb1f64d.1677861177.git.jbaron@akamai.com> (raw)
In-Reply-To: <cover.1677861177.git.jbaron@akamai.com>
In-Reply-To: <cover.1677861177.git.jbaron@akamai.com>

The 'base' parameter to __ddebug_add_module() is no longer in use
after: Commit b7b4eebdba7b ("dyndbg: gather __dyndbg[] state into
struct _ddebug_info").

Cc: Jim Cromie <jim.cromie@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tested-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Jason Baron <jbaron@akamai.com>
---
 lib/dynamic_debug.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 009f2ead09c1..8136e5236b7b 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1223,8 +1223,7 @@ static void ddebug_attach_module_classes(struct ddebug_table *dt,
  * Allocate a new ddebug_table for the given module
  * and add it to the global list.
  */
-static int __ddebug_add_module(struct _ddebug_info *di, unsigned int base,
-			       const char *modname)
+static int __ddebug_add_module(struct _ddebug_info *di, const char *modname)
 {
 	struct ddebug_table *dt;
 
@@ -1265,7 +1264,7 @@ static int __ddebug_add_module(struct _ddebug_info *di, unsigned int base,
 
 int ddebug_add_module(struct _ddebug_info *di, const char *modname)
 {
-	return __ddebug_add_module(di, 0, modname);
+	return __ddebug_add_module(di, modname);
 }
 
 /* helper for ddebug_dyndbg_(boot|module)_param_cb */
@@ -1408,7 +1407,7 @@ static int __init dynamic_debug_init(void)
 			mod_ct++;
 			di.num_descs = mod_sites;
 			di.descs = iter_mod_start;
-			ret = __ddebug_add_module(&di, i - mod_sites, modname);
+			ret = __ddebug_add_module(&di, modname);
 			if (ret)
 				goto out_err;
 
@@ -1419,7 +1418,7 @@ static int __init dynamic_debug_init(void)
 	}
 	di.num_descs = mod_sites;
 	di.descs = iter_mod_start;
-	ret = __ddebug_add_module(&di, i - mod_sites, modname);
+	ret = __ddebug_add_module(&di, modname);
 	if (ret)
 		goto out_err;
 
-- 
2.17.1


  reply	other threads:[~2023-03-03 16:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 16:50 [PATCH v3 0/2] dyndbg: let's use the module notifier callback Jason Baron
2023-03-03 16:50 ` Jason Baron [this message]
2023-03-06 17:56   ` [PATCH v3 1/2] dyndbg: remove unused 'base' arg from __ddebug_add_module() Vincenzo Palazzo
2023-03-03 16:50 ` [PATCH v3 2/2] dyndbg: use the module notifier callbacks Jason Baron
2023-03-04  6:51   ` kernel test robot
2023-03-06 17:57   ` Vincenzo Palazzo
2023-03-09 20:58     ` Luis Chamberlain
2023-03-03 22:06 ` [PATCH v3 0/2] dyndbg: let's use the module notifier callback Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16bcadc508cae9c93249d16a499fb714edb1f64d.1677861177.git.jbaron@akamai.com \
    --to=jbaron@akamai.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.