From: "Michael S. Tsirkin" <mst@redhat.com> To: Paul Brook <paul@codesourcery.com> Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>, virtualization@lists.linux-foundation.org, Christian Borntraeger <borntraeger@de.ibm.com>, Blue Swirl <blauwirbel@gmail.com> Subject: Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions Date: Wed, 10 Jun 2009 17:25:08 +0300 [thread overview] Message-ID: <20090610142508.GA28409@redhat.com> (raw) In-Reply-To: <200906101507.39823.paul@codesourcery.com> On Wed, Jun 10, 2009 at 03:07:34PM +0100, Paul Brook wrote: > > > > Note that platform must set a flag to declare MSI supported. > > > > For PC this will be set by APIC. > > > > > > This sounds wrong. The device shouldn't know or care whether the system > > > has a MSI capable interrupt controller. That's for the guest OS to figure > > > out. > > > > You are right of course. In theory there's nothing that breaks if I > > set this flag to on, on all platforms. OTOH if qemu emulates some > > controller incorrectly, guest might misdetect MSI support in the > > controller, and things will break horribly. > > > > It seems safer to have a flag that can be enabled by people > > that know about a specific platform. > > No. The solution is to fix whatever is broken. That's easy enough then. Patch below. > > If we really need to avoid MSI-X capable devices then that should be done > explicity per-device. i.e. you have a different virtio-net device that does > not use MSI-X. > > Paul Why should it be done per-device? ---> Don't add an option for platforms to disable MSI-X in all devices. Paul Brook will find and fix all platforms that have broken MSI-X emulation. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- diff --git a/hw/apic.c b/hw/apic.c index ed03a36..9d44061 100644 --- a/hw/apic.c +++ b/hw/apic.c @@ -945,7 +945,6 @@ int apic_init(CPUState *env) s->cpu_env = env; apic_reset(s); - msix_supported = 1; /* XXX: mapping more APICs at the same memory location */ if (apic_io_memory == 0) { diff --git a/hw/msix.c b/hw/msix.c index ce4e6ba..16efb27 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -62,9 +62,6 @@ /* Flag to globally disable MSI-X support */ int msix_disable; -/* Flag for interrupt controller to declare MSI-X support */ -int msix_supported; - /* Add MSI-X capability to the config space for the device. */ /* Given a bar and its size, add MSI-X table on top of it * and fill MSI-X capability in the config space. @@ -232,10 +229,7 @@ void msix_mmio_map(PCIDevice *d, int region_num, int msix_init(struct PCIDevice *dev, unsigned short nentries, unsigned bar_nr, unsigned bar_size) { - int ret = -ENOMEM; - /* Nothing to do if MSI is not supported by interrupt controller */ - if (!msix_supported) - return -ENOTTY; + int ret; if (nentries > MSIX_MAX_ENTRIES) return -EINVAL; diff --git a/hw/msix.h b/hw/msix.h index 79e84a3..2fcadd3 100644 --- a/hw/msix.h +++ b/hw/msix.h @@ -30,6 +30,5 @@ void msix_notify(PCIDevice *dev, unsigned vector); void msix_reset(PCIDevice *dev); extern int msix_disable; -extern int msix_supported; #endif -- MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Paul Brook <paul@codesourcery.com> Cc: Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl <blauwirbel@gmail.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Avi Kivity <avi@redhat.com> Subject: Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions Date: Wed, 10 Jun 2009 17:25:08 +0300 [thread overview] Message-ID: <20090610142508.GA28409@redhat.com> (raw) In-Reply-To: <200906101507.39823.paul@codesourcery.com> On Wed, Jun 10, 2009 at 03:07:34PM +0100, Paul Brook wrote: > > > > Note that platform must set a flag to declare MSI supported. > > > > For PC this will be set by APIC. > > > > > > This sounds wrong. The device shouldn't know or care whether the system > > > has a MSI capable interrupt controller. That's for the guest OS to figure > > > out. > > > > You are right of course. In theory there's nothing that breaks if I > > set this flag to on, on all platforms. OTOH if qemu emulates some > > controller incorrectly, guest might misdetect MSI support in the > > controller, and things will break horribly. > > > > It seems safer to have a flag that can be enabled by people > > that know about a specific platform. > > No. The solution is to fix whatever is broken. That's easy enough then. Patch below. > > If we really need to avoid MSI-X capable devices then that should be done > explicity per-device. i.e. you have a different virtio-net device that does > not use MSI-X. > > Paul Why should it be done per-device? ---> Don't add an option for platforms to disable MSI-X in all devices. Paul Brook will find and fix all platforms that have broken MSI-X emulation. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- diff --git a/hw/apic.c b/hw/apic.c index ed03a36..9d44061 100644 --- a/hw/apic.c +++ b/hw/apic.c @@ -945,7 +945,6 @@ int apic_init(CPUState *env) s->cpu_env = env; apic_reset(s); - msix_supported = 1; /* XXX: mapping more APICs at the same memory location */ if (apic_io_memory == 0) { diff --git a/hw/msix.c b/hw/msix.c index ce4e6ba..16efb27 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -62,9 +62,6 @@ /* Flag to globally disable MSI-X support */ int msix_disable; -/* Flag for interrupt controller to declare MSI-X support */ -int msix_supported; - /* Add MSI-X capability to the config space for the device. */ /* Given a bar and its size, add MSI-X table on top of it * and fill MSI-X capability in the config space. @@ -232,10 +229,7 @@ void msix_mmio_map(PCIDevice *d, int region_num, int msix_init(struct PCIDevice *dev, unsigned short nentries, unsigned bar_nr, unsigned bar_size) { - int ret = -ENOMEM; - /* Nothing to do if MSI is not supported by interrupt controller */ - if (!msix_supported) - return -ENOTTY; + int ret; if (nentries > MSIX_MAX_ENTRIES) return -EINVAL; diff --git a/hw/msix.h b/hw/msix.h index 79e84a3..2fcadd3 100644 --- a/hw/msix.h +++ b/hw/msix.h @@ -30,6 +30,5 @@ void msix_notify(PCIDevice *dev, unsigned vector); void msix_reset(PCIDevice *dev); extern int msix_disable; -extern int msix_supported; #endif -- MST
next prev parent reply other threads:[~2009-06-10 14:28 UTC|newest] Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <cover.1243253205.git.mst@redhat.com> 2009-05-25 12:12 ` [PATCHv2] qemu: make default_write_config use mask table Michael S. Tsirkin 2009-05-25 12:12 ` Michael S. Tsirkin 2009-05-25 12:12 ` [Qemu-devel] " Michael S. Tsirkin 2009-05-25 12:24 ` [PATCH 01/11] " Michael S. Tsirkin 2009-05-25 12:24 ` [Qemu-devel] " Michael S. Tsirkin 2009-05-25 12:24 ` Michael S. Tsirkin 2009-05-25 12:25 ` [PATCH 02/11] qemu: capability bits in pci save/restore Michael S. Tsirkin 2009-05-25 12:25 ` [Qemu-devel] " Michael S. Tsirkin 2009-05-25 12:25 ` Michael S. Tsirkin 2009-05-25 12:25 ` [PATCH 03/11] qemu: add routines to manage PCI capabilities Michael S. Tsirkin 2009-05-25 12:25 ` Michael S. Tsirkin 2009-05-25 12:25 ` [Qemu-devel] " Michael S. Tsirkin 2009-05-26 8:49 ` Isaku Yamahata 2009-05-26 8:49 ` Isaku Yamahata 2009-05-26 9:22 ` Michael S. Tsirkin 2009-05-26 9:22 ` Michael S. Tsirkin 2009-05-26 9:22 ` Michael S. Tsirkin 2009-05-26 8:49 ` Isaku Yamahata 2009-05-26 9:30 ` [PATCH] qemu: fix pci_find_capability for multiple caps Michael S. Tsirkin 2009-05-26 9:30 ` Michael S. Tsirkin 2009-05-26 9:30 ` [Qemu-devel] " Michael S. Tsirkin 2009-05-25 12:25 ` [PATCH 04/11] qemu: helper routines for pci access Michael S. Tsirkin 2009-05-25 12:25 ` Michael S. Tsirkin 2009-05-25 12:25 ` [Qemu-devel] " Michael S. Tsirkin 2009-05-26 2:33 ` Isaku Yamahata 2009-05-26 2:33 ` Isaku Yamahata 2009-05-26 6:41 ` Michael S. Tsirkin 2009-05-26 6:41 ` Michael S. Tsirkin 2009-05-26 8:07 ` Avi Kivity 2009-05-26 8:07 ` Avi Kivity 2009-05-26 8:49 ` Michael S. Tsirkin 2009-05-26 8:49 ` Michael S. Tsirkin 2009-05-26 8:49 ` Michael S. Tsirkin 2009-05-26 8:07 ` Avi Kivity 2009-05-26 6:41 ` Michael S. Tsirkin 2009-05-26 2:33 ` Isaku Yamahata 2009-05-25 12:25 ` [PATCH 05/11] qemu: MSI-X support functions Michael S. Tsirkin 2009-05-25 12:25 ` [Qemu-devel] " Michael S. Tsirkin 2009-06-09 23:19 ` Paul Brook 2009-06-09 23:19 ` Paul Brook 2009-06-10 9:46 ` Michael S. Tsirkin 2009-06-10 9:46 ` Michael S. Tsirkin 2009-06-10 9:46 ` Michael S. Tsirkin 2009-06-10 14:07 ` Paul Brook 2009-06-10 14:07 ` Paul Brook 2009-06-10 14:25 ` Michael S. Tsirkin 2009-06-10 14:25 ` Michael S. Tsirkin [this message] 2009-06-10 14:25 ` Michael S. Tsirkin 2009-06-10 14:39 ` Paul Brook 2009-06-10 14:39 ` Paul Brook 2009-06-10 14:47 ` Michael S. Tsirkin 2009-06-10 14:47 ` Michael S. Tsirkin 2009-06-10 14:47 ` Michael S. Tsirkin 2009-06-10 15:15 ` Paul Brook 2009-06-10 15:15 ` Paul Brook 2009-06-10 15:52 ` Michael S. Tsirkin 2009-06-10 15:52 ` Michael S. Tsirkin 2009-06-10 15:52 ` Michael S. Tsirkin 2009-06-10 16:08 ` Paul Brook 2009-06-10 16:08 ` Paul Brook 2009-06-10 16:26 ` Michael S. Tsirkin 2009-06-10 16:26 ` Michael S. Tsirkin 2009-06-10 16:46 ` Paul Brook 2009-06-10 16:46 ` Paul Brook 2009-06-10 17:03 ` Michael S. Tsirkin 2009-06-10 17:03 ` Michael S. Tsirkin 2009-06-10 17:30 ` Paul Brook 2009-06-10 17:30 ` Paul Brook 2009-06-10 17:30 ` Paul Brook 2009-06-10 18:07 ` Michael S. Tsirkin 2009-06-10 18:07 ` Michael S. Tsirkin 2009-06-10 18:07 ` Michael S. Tsirkin 2009-06-10 19:04 ` Paul Brook 2009-06-10 19:04 ` Paul Brook 2009-06-11 8:29 ` Michael S. Tsirkin 2009-06-11 8:29 ` Michael S. Tsirkin 2009-06-11 8:29 ` Michael S. Tsirkin 2009-06-10 19:04 ` Paul Brook 2009-06-10 17:03 ` Michael S. Tsirkin 2009-06-10 16:46 ` Paul Brook 2009-06-10 16:26 ` Michael S. Tsirkin 2009-06-10 16:08 ` Paul Brook 2009-06-10 15:15 ` Paul Brook 2009-06-10 14:39 ` Paul Brook 2009-06-10 14:07 ` Paul Brook 2009-06-09 23:19 ` Paul Brook 2009-05-25 12:25 ` Michael S. Tsirkin 2009-05-25 12:25 ` [PATCH 06/11] qemu: add flag to disable MSI-X by default Michael S. Tsirkin 2009-05-25 12:25 ` Michael S. Tsirkin 2009-05-25 12:25 ` [Qemu-devel] " Michael S. Tsirkin 2009-05-25 12:25 ` [PATCH 07/11] qemu: minimal MSI/MSI-X implementation for PC Michael S. Tsirkin 2009-05-25 12:25 ` [Qemu-devel] " Michael S. Tsirkin 2009-05-25 12:25 ` Michael S. Tsirkin 2009-05-25 12:26 ` [PATCH 08/11] qemu: add support for resizing regions Michael S. Tsirkin 2009-05-25 12:26 ` [Qemu-devel] " Michael S. Tsirkin 2009-05-25 12:26 ` Michael S. Tsirkin 2009-05-25 12:26 ` [PATCH 09/11] qemu: virtio support for many interrupt vectors Michael S. Tsirkin 2009-05-25 12:26 ` [Qemu-devel] " Michael S. Tsirkin 2009-05-25 12:26 ` Michael S. Tsirkin 2009-05-25 12:26 ` [PATCH 10/11] qemu: MSI-X support in virtio PCI Michael S. Tsirkin 2009-05-25 12:26 ` [Qemu-devel] " Michael S. Tsirkin 2009-05-25 12:26 ` Michael S. Tsirkin 2009-05-25 12:26 ` [PATCH 11/11] qemu: request 3 vectors in virtio-net Michael S. Tsirkin 2009-05-25 12:26 ` Michael S. Tsirkin 2009-05-25 12:26 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090610142508.GA28409@redhat.com \ --to=mst@redhat.com \ --cc=avi@redhat.com \ --cc=blauwirbel@gmail.com \ --cc=borntraeger@de.ibm.com \ --cc=cotte@de.ibm.com \ --cc=kvm@vger.kernel.org \ --cc=paul@codesourcery.com \ --cc=qemu-devel@nongnu.org \ --cc=rusty@rustcorp.com.au \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.