From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 4/4] drm/vc4: Don't use drm_put_dev
Date: Thu, 8 Dec 2016 12:07:39 +0100 [thread overview]
Message-ID: <20161208110739.24417-4-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20161208110739.24417-1-daniel.vetter@ffwll.ch>
vc4 already has a proper load sequence, but the unload one needed some
fixups: First unregister, and last drop the final ref.
Cc: Eric Anholt <eric@anholt.net>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/vc4/vc4_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 1dab9e5b3689..bfaf4e36f7ae 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -277,12 +277,14 @@ static void vc4_drm_unbind(struct device *dev)
struct drm_device *drm = platform_get_drvdata(pdev);
struct vc4_dev *vc4 = to_vc4_dev(drm);
+ drm_dev_unregister(drm);
+
if (vc4->fbdev)
drm_fbdev_cma_fini(vc4->fbdev);
drm_mode_config_cleanup(drm);
- drm_put_dev(drm);
+ drm_dev_unref(drm);
}
static const struct component_master_ops vc4_drm_ops = {
--
2.10.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-08 11:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 11:07 [PATCH 1/4] drm/etnaviv: Use drm_dev_unref, not drm_put_dev Daniel Vetter
2016-12-08 11:07 ` [PATCH 2/4] drm/fsl: don't use drm_put_dev Daniel Vetter
2016-12-13 10:53 ` Lucas Stach
2016-12-13 17:12 ` Daniel Vetter
2016-12-13 17:54 ` [PATCH] " Daniel Vetter
2016-12-13 17:57 ` Lucas Stach
2016-12-13 21:26 ` Daniel Vetter
2016-12-13 23:29 ` Stefan Agner
2016-12-08 11:07 ` [PATCH 3/4] drm/mediatek: " Daniel Vetter
2016-12-13 10:55 ` Lucas Stach
2016-12-13 17:14 ` Daniel Vetter
2016-12-08 11:07 ` Daniel Vetter [this message]
2016-12-09 23:44 ` [PATCH 4/4] drm/vc4: Don't " Eric Anholt
2016-12-13 10:52 ` [PATCH 1/4] drm/etnaviv: Use drm_dev_unref, not drm_put_dev Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208110739.24417-4-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.