All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: anish kumar <yesanishhere@gmail.com>
Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com,
	tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org
Subject: Applied "ASoC: dapm: fix error path in snd_soc_dapm_new_pcm" to the asoc tree
Date: Wed, 20 Sep 2017 04:42:25 -0700 (PDT)	[thread overview]
Message-ID: <20170920114225.C9C3B4400D3@finisterre.ee.mobilebroadband> (raw)
In-Reply-To: <1505896116-43310-2-git-send-email-yesanishhere@gmail.com>

The patch

   ASoC: dapm: fix error path in snd_soc_dapm_new_pcm

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From e5af4f9fb3d405e6145f0d019ce11a97a8930915 Mon Sep 17 00:00:00 2001
From: anish kumar <yesanishhere@gmail.com>
Date: Wed, 20 Sep 2017 01:28:33 -0700
Subject: [PATCH] ASoC: dapm: fix error path in snd_soc_dapm_new_pcm

w_param_text[count] is freed in the wrong error path.
Fix it by shifting the outfree_w_param label.

Signed-off-by: anish kumar <yesanishhere@gmail.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/soc-dapm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index dcef67a9bd48..f51f61340f9c 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3907,9 +3907,9 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card,
 	devm_kfree(card->dev, (void *)private_value);
 outfree_link_name:
 	devm_kfree(card->dev, link_name);
-outfree_w_param:
 	for (count = 0 ; count < num_params; count++)
 		devm_kfree(card->dev, (void *)w_param_text[count]);
+outfree_w_param:
 	devm_kfree(card->dev, w_param_text);
 
 	return ret;
-- 
2.13.2

  parent reply	other threads:[~2017-09-20 11:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20  8:28 [Resend] [PATCH 0/4] ASoC: dapm: Avoid creating kcontrol for params yesanishhere
2017-09-20  8:28 ` [Resend] [PATCH 1/4] ASoC: dapm: fix error path in snd_soc_dapm_new_pcm yesanishhere
2017-09-20 11:02   ` Charles Keepax
2017-09-20 11:42   ` Mark Brown [this message]
2017-09-20  8:28 ` [Resend] [PATCH 2/4] ASoC: dapm: Refactor the code " yesanishhere
2017-09-20 11:02   ` Charles Keepax
2017-09-20  8:28 ` [Resend] [PATCH 3/4] ASoC: dapm: Avoid creating kcontrol for params yesanishhere
2017-09-20 11:05   ` Charles Keepax
2017-09-20  8:28 ` [Resend] [PATCH 4/4] ASoC: dapm: Remove the redundant check yesanishhere

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170920114225.C9C3B4400D3@finisterre.ee.mobilebroadband \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=tiwai@suse.com \
    --cc=yesanishhere@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.