All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: [PATCH 0/5] cec/adv/omap: fixes and new status flags
Date: Thu,  4 Oct 2018 11:08:55 +0200	[thread overview]
Message-ID: <20181004090900.32915-1-hverkuil@xs4all.nl> (raw)

From: Hans Verkuil <hans.verkuil@cisco.com>

The first patch adds new status flags to indicate when a pending
message is aborted because the CEC adapter is unconfigured, and when
a transmit times out (this indicates a driver bug).

The second and third patch fix a minor issue with the adv HDMI receivers:
if the EDID goes away, then the physical address also becomes invalid.

The fourth patch fixes a race condition in the omap4 CEC driver that
causes a transmit time out. The final patch drops the code in the omap4
CEC driver that attempts to set the number of retransmits: those register
bits are read-only, so the code is pointless.

There are no dependencies between these patches, although the first
and fourth patch relate to the same problem. With the new transmit
TIMEOUT status I hope that it will be easier to catch driver bugs like
that earlier since this bug remained hidden for too long.

Regards,

	Hans

Hans Verkuil (5):
  cec: add new tx/rx status bits to detect aborts/timeouts
  adv7604: when the EDID is cleared, unconfigure CEC as well
  adv7842: when the EDID is cleared, unconfigure CEC as well
  omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done
  omapdrm/dss/hdmi4_cec.c: don't set the retransmit count

 .../media/uapi/cec/cec-ioc-receive.rst        | 25 ++++++-
 drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c       | 38 +++++------
 drivers/media/cec/cec-adap.c                  | 66 +++++--------------
 drivers/media/i2c/adv7604.c                   |  4 +-
 drivers/media/i2c/adv7842.c                   |  4 +-
 include/uapi/linux/cec.h                      |  3 +
 6 files changed, 67 insertions(+), 73 deletions(-)

-- 
2.18.0

WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, dri-devel@lists.freedesktop.org
Subject: [PATCH 0/5] cec/adv/omap: fixes and new status flags
Date: Thu,  4 Oct 2018 11:08:55 +0200	[thread overview]
Message-ID: <20181004090900.32915-1-hverkuil@xs4all.nl> (raw)

From: Hans Verkuil <hans.verkuil@cisco.com>

The first patch adds new status flags to indicate when a pending
message is aborted because the CEC adapter is unconfigured, and when
a transmit times out (this indicates a driver bug).

The second and third patch fix a minor issue with the adv HDMI receivers:
if the EDID goes away, then the physical address also becomes invalid.

The fourth patch fixes a race condition in the omap4 CEC driver that
causes a transmit time out. The final patch drops the code in the omap4
CEC driver that attempts to set the number of retransmits: those register
bits are read-only, so the code is pointless.

There are no dependencies between these patches, although the first
and fourth patch relate to the same problem. With the new transmit
TIMEOUT status I hope that it will be easier to catch driver bugs like
that earlier since this bug remained hidden for too long.

Regards,

	Hans

Hans Verkuil (5):
  cec: add new tx/rx status bits to detect aborts/timeouts
  adv7604: when the EDID is cleared, unconfigure CEC as well
  adv7842: when the EDID is cleared, unconfigure CEC as well
  omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done
  omapdrm/dss/hdmi4_cec.c: don't set the retransmit count

 .../media/uapi/cec/cec-ioc-receive.rst        | 25 ++++++-
 drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c       | 38 +++++------
 drivers/media/cec/cec-adap.c                  | 66 +++++--------------
 drivers/media/i2c/adv7604.c                   |  4 +-
 drivers/media/i2c/adv7842.c                   |  4 +-
 include/uapi/linux/cec.h                      |  3 +
 6 files changed, 67 insertions(+), 73 deletions(-)

-- 
2.18.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2018-10-04 16:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04  9:08 Hans Verkuil [this message]
2018-10-04  9:08 ` [PATCH 0/5] cec/adv/omap: fixes and new status flags Hans Verkuil
2018-10-04  9:08 ` [PATCH 1/5] cec: add new tx/rx status bits to detect aborts/timeouts Hans Verkuil
2018-10-04  9:08   ` Hans Verkuil
2018-10-04  9:08 ` [PATCH 2/5] adv7604: when the EDID is cleared, unconfigure CEC as well Hans Verkuil
2018-10-04  9:08   ` Hans Verkuil
2018-10-04  9:08 ` [PATCH 3/5] adv7842: " Hans Verkuil
2018-10-04  9:08   ` Hans Verkuil
2018-10-04  9:08 ` [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done Hans Verkuil
2018-10-04  9:08   ` Hans Verkuil
2018-10-05 14:13   ` Hans Verkuil
2018-10-05 14:13     ` Hans Verkuil
2018-10-08 12:52     ` Tomi Valkeinen
2018-10-08 12:52       ` Tomi Valkeinen
2018-10-08 12:58       ` Hans Verkuil
2018-10-08 12:58         ` Hans Verkuil
2018-10-08 12:45   ` Tomi Valkeinen
2018-10-08 12:45     ` Tomi Valkeinen
2018-10-08 12:55     ` Hans Verkuil
2018-10-08 12:55       ` Hans Verkuil
2018-10-08 13:03       ` Tomi Valkeinen
2018-10-08 13:03         ` Tomi Valkeinen
2018-10-04  9:09 ` [PATCH 5/5] omapdrm/dss/hdmi4_cec.c: don't set the retransmit count Hans Verkuil
2018-10-04  9:09   ` Hans Verkuil
2018-10-08 12:47   ` Tomi Valkeinen
2018-10-08 12:47     ` Tomi Valkeinen
2018-10-08 13:01     ` Hans Verkuil
2018-10-08 13:01       ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181004090900.32915-1-hverkuil@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-media@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.