From: Miquel Raynal <miquel.raynal@bootlin.com> To: Boris Brezillon <bbrezillon@kernel.org>, Richard Weinberger <richard@nod.at>, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Marek Vasut <marek.vasut@gmail.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com> Cc: Vignesh R <vigneshr@ti.com>, Tudor Ambarus <tudor.ambarus@microchip.com>, Julien Su <juliensu@mxic.com.tw>, Schrempf Frieder <frieder.schrempf@kontron.de>, Paul Cercueil <paul@crapouillou.net>, linux-mtd@lists.infradead.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Mason Yang <masonccyang@mxic.com.tw>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 27/36] mtd: nand: Let software ECC engines be retrieved from the NAND core Date: Mon, 4 Mar 2019 23:28:32 +0100 [thread overview] Message-ID: <20190304222841.13899-28-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20190304222841.13899-1-miquel.raynal@bootlin.com> Before making use of the ECC engines, we must retrieve them. Add the boilerplate for the ones already available: software engines (Hamming and BCH). Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/ecc/engine.c | 20 ++++++++++++++++++++ include/linux/mtd/nand-ecc-sw-bch.h | 3 +++ include/linux/mtd/nand-ecc-sw-hamming.h | 3 +++ include/linux/mtd/nand.h | 3 +++ 4 files changed, 29 insertions(+) diff --git a/drivers/mtd/nand/ecc/engine.c b/drivers/mtd/nand/ecc/engine.c index c6779acc936d..4345124e01bf 100644 --- a/drivers/mtd/nand/ecc/engine.c +++ b/drivers/mtd/nand/ecc/engine.c @@ -450,6 +450,26 @@ bool nand_ecc_correction_is_enough(struct nand_device *nand) } EXPORT_SYMBOL(nand_ecc_correction_is_enough); +struct nand_ecc_engine *nand_ecc_get_sw_engine(struct nand_device *nand) +{ + unsigned int algo = nand->ecc.user_conf.algo; + + if (algo == NAND_ECC_UNKNOWN) + algo = nand->ecc.defaults.algo; + + switch (algo) { + case NAND_ECC_HAMMING: + return nand_ecc_sw_hamming_get_engine(); + case NAND_ECC_BCH: + return nand_ecc_sw_bch_get_engine(); + default: + break; + } + + return NULL; +} +EXPORT_SYMBOL(nand_ecc_get_sw_engine); + MODULE_LICENSE("GPL"); MODULE_AUTHOR("Miquel Raynal <miquel.raynal@bootlin.com>"); MODULE_DESCRIPTION("Generic ECC engine"); diff --git a/include/linux/mtd/nand-ecc-sw-bch.h b/include/linux/mtd/nand-ecc-sw-bch.h index cd9044d293f8..e4f9b4aee3cd 100644 --- a/include/linux/mtd/nand-ecc-sw-bch.h +++ b/include/linux/mtd/nand-ecc-sw-bch.h @@ -11,6 +11,9 @@ #include <linux/mtd/nand.h> #include <linux/bch.h> +/* Needed for cross inclusion with nand.h */ +struct nand_device; + /** * struct nand_ecc_sw_bch_conf - private software BCH ECC engine structure * @reqooblen: Save the actual user OOB length requested before overwriting it diff --git a/include/linux/mtd/nand-ecc-sw-hamming.h b/include/linux/mtd/nand-ecc-sw-hamming.h index 9ea096aaf230..75bf80529fe9 100644 --- a/include/linux/mtd/nand-ecc-sw-hamming.h +++ b/include/linux/mtd/nand-ecc-sw-hamming.h @@ -12,6 +12,9 @@ #include <linux/mtd/nand.h> +/* Needed for cross inclusion with nand.h */ +struct nand_device; + /** * struct nand_ecc_sw_hamming_conf - private software Hamming ECC engine structure * @reqooblen: Save the actual user OOB length requested before overwriting it diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index 5db24fa073f2..c68060cebc86 100644 --- a/include/linux/mtd/nand.h +++ b/include/linux/mtd/nand.h @@ -11,6 +11,8 @@ #define __LINUX_MTD_NAND_H #include <linux/mtd/mtd.h> +#include <linux/mtd/nand-ecc-sw-hamming.h> +#include <linux/mtd/nand-ecc-sw-bch.h> struct nand_device; @@ -245,6 +247,7 @@ int nand_ecc_prepare_io_req(struct nand_device *nand, int nand_ecc_finish_io_req(struct nand_device *nand, struct nand_page_io_req *req, void *oobbuf); bool nand_ecc_correction_is_enough(struct nand_device *nand); +struct nand_ecc_engine *nand_ecc_get_sw_engine(struct nand_device *nand); /** * struct nand_ecc - High-level ECC object -- 2.19.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Boris Brezillon <bbrezillon@kernel.org>, Richard Weinberger <richard@nod.at>, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Marek Vasut <marek.vasut@gmail.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com> Cc: Vignesh R <vigneshr@ti.com>, Tudor Ambarus <tudor.ambarus@microchip.com>, Julien Su <juliensu@mxic.com.tw>, Schrempf Frieder <frieder.schrempf@kontron.de>, Paul Cercueil <paul@crapouillou.net>, linux-mtd@lists.infradead.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Mason Yang <masonccyang@mxic.com.tw>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 27/36] mtd: nand: Let software ECC engines be retrieved from the NAND core Date: Mon, 4 Mar 2019 23:28:32 +0100 [thread overview] Message-ID: <20190304222841.13899-28-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20190304222841.13899-1-miquel.raynal@bootlin.com> Before making use of the ECC engines, we must retrieve them. Add the boilerplate for the ones already available: software engines (Hamming and BCH). Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/ecc/engine.c | 20 ++++++++++++++++++++ include/linux/mtd/nand-ecc-sw-bch.h | 3 +++ include/linux/mtd/nand-ecc-sw-hamming.h | 3 +++ include/linux/mtd/nand.h | 3 +++ 4 files changed, 29 insertions(+) diff --git a/drivers/mtd/nand/ecc/engine.c b/drivers/mtd/nand/ecc/engine.c index c6779acc936d..4345124e01bf 100644 --- a/drivers/mtd/nand/ecc/engine.c +++ b/drivers/mtd/nand/ecc/engine.c @@ -450,6 +450,26 @@ bool nand_ecc_correction_is_enough(struct nand_device *nand) } EXPORT_SYMBOL(nand_ecc_correction_is_enough); +struct nand_ecc_engine *nand_ecc_get_sw_engine(struct nand_device *nand) +{ + unsigned int algo = nand->ecc.user_conf.algo; + + if (algo == NAND_ECC_UNKNOWN) + algo = nand->ecc.defaults.algo; + + switch (algo) { + case NAND_ECC_HAMMING: + return nand_ecc_sw_hamming_get_engine(); + case NAND_ECC_BCH: + return nand_ecc_sw_bch_get_engine(); + default: + break; + } + + return NULL; +} +EXPORT_SYMBOL(nand_ecc_get_sw_engine); + MODULE_LICENSE("GPL"); MODULE_AUTHOR("Miquel Raynal <miquel.raynal@bootlin.com>"); MODULE_DESCRIPTION("Generic ECC engine"); diff --git a/include/linux/mtd/nand-ecc-sw-bch.h b/include/linux/mtd/nand-ecc-sw-bch.h index cd9044d293f8..e4f9b4aee3cd 100644 --- a/include/linux/mtd/nand-ecc-sw-bch.h +++ b/include/linux/mtd/nand-ecc-sw-bch.h @@ -11,6 +11,9 @@ #include <linux/mtd/nand.h> #include <linux/bch.h> +/* Needed for cross inclusion with nand.h */ +struct nand_device; + /** * struct nand_ecc_sw_bch_conf - private software BCH ECC engine structure * @reqooblen: Save the actual user OOB length requested before overwriting it diff --git a/include/linux/mtd/nand-ecc-sw-hamming.h b/include/linux/mtd/nand-ecc-sw-hamming.h index 9ea096aaf230..75bf80529fe9 100644 --- a/include/linux/mtd/nand-ecc-sw-hamming.h +++ b/include/linux/mtd/nand-ecc-sw-hamming.h @@ -12,6 +12,9 @@ #include <linux/mtd/nand.h> +/* Needed for cross inclusion with nand.h */ +struct nand_device; + /** * struct nand_ecc_sw_hamming_conf - private software Hamming ECC engine structure * @reqooblen: Save the actual user OOB length requested before overwriting it diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index 5db24fa073f2..c68060cebc86 100644 --- a/include/linux/mtd/nand.h +++ b/include/linux/mtd/nand.h @@ -11,6 +11,8 @@ #define __LINUX_MTD_NAND_H #include <linux/mtd/mtd.h> +#include <linux/mtd/nand-ecc-sw-hamming.h> +#include <linux/mtd/nand-ecc-sw-bch.h> struct nand_device; @@ -245,6 +247,7 @@ int nand_ecc_prepare_io_req(struct nand_device *nand, int nand_ecc_finish_io_req(struct nand_device *nand, struct nand_page_io_req *req, void *oobbuf); bool nand_ecc_correction_is_enough(struct nand_device *nand); +struct nand_ecc_engine *nand_ecc_get_sw_engine(struct nand_device *nand); /** * struct nand_ecc - High-level ECC object -- 2.19.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-04 22:47 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-04 22:28 [PATCH v2 00/36] Introduce the generic ECC engine abstraction Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 01/36] mtd: nand: Move nand_device forward declaration to the top Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-31 11:12 ` Boris Brezillon 2019-03-31 11:12 ` Boris Brezillon 2019-03-04 22:28 ` [PATCH v2 02/36] mtd: nand: Add an extra level in the Kconfig hierarchy Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-31 11:13 ` Boris Brezillon 2019-03-31 11:13 ` Boris Brezillon 2019-03-04 22:28 ` [PATCH v2 03/36] mtd: nand: Drop useless 'depends on' in Kconfig Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-31 11:15 ` Boris Brezillon 2019-03-31 11:15 ` Boris Brezillon 2019-03-04 22:28 ` [PATCH v2 04/36] mtd: rawnand: Use the NAND core Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-31 11:21 ` Boris Brezillon 2019-03-31 11:21 ` Boris Brezillon 2019-03-04 22:28 ` [PATCH v2 05/36] mtd: nand: Add a NAND page I/O request type Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-31 11:23 ` Boris Brezillon 2019-03-31 11:23 ` Boris Brezillon 2019-03-04 22:28 ` [PATCH v2 06/36] mtd: nand: Rename a core structure Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-31 11:30 ` Boris Brezillon 2019-03-31 11:30 ` Boris Brezillon 2019-05-03 8:26 ` Miquel Raynal 2019-05-03 8:26 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 07/36] mtd: rawnand: Avoid a typedef Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-31 11:55 ` Boris Brezillon 2019-03-31 11:55 ` Boris Brezillon 2019-05-03 12:40 ` Miquel Raynal 2019-05-03 12:40 ` Miquel Raynal 2019-05-03 12:50 ` Boris Brezillon 2019-05-03 12:50 ` Boris Brezillon 2019-05-06 15:13 ` Miquel Raynal 2019-05-06 15:13 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 08/36] mtd: rawnand: Add an invalid ECC mode to discriminate with valid ones Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 09/36] mtd: rawnand: Clarify the values for invalid ECC mode/algo Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-31 11:57 ` Boris Brezillon 2019-03-31 11:57 ` Boris Brezillon 2019-03-04 22:28 ` [PATCH v2 10/36] mtd: nand: Introduce the ECC engine abstraction Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-31 12:10 ` Boris Brezillon 2019-03-31 12:10 ` Boris Brezillon 2019-05-03 14:34 ` Miquel Raynal 2019-05-03 14:34 ` Miquel Raynal 2019-05-03 15:54 ` Boris Brezillon 2019-05-03 15:54 ` Boris Brezillon 2019-05-06 15:49 ` Miquel Raynal 2019-05-06 15:49 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 11/36] mtd: Fix typo in mtd_ooblayout_set_databytes() description Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-31 11:32 ` Boris Brezillon 2019-03-31 11:32 ` Boris Brezillon 2019-05-03 8:18 ` Miquel Raynal 2019-05-03 8:18 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 12/36] mtd: nand: Move standard OOB layouts to the generic ECC core Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 13/36] mtd: nand: Move ECC specific functions to ecc/engine.c Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 14/36] mtd: nand: ecc: Move BCH code into the ecc/ directory Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 15/36] mtd: nand: ecc: Use SPDX license identifier for the software BCH code Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 16/36] mtd: nand: ecc: Turn the software BCH implementation generic Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 17/36] mtd: rawnand: Get rid of chip->ecc.priv Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 18/36] mtd: nand: ecc: Move Hamming code into the ecc/ directory Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 19/36] mtd: nand: ecc: Use SPDX license identifier for the software Hamming code Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 20/36] mtd: nand: ecc: Clarify the software Hamming introductory line Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 21/36] mtd: nand: ecc: Turn the software Hamming implementation generic Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 22/36] mtd: nand: Remove useless include about software Hamming ECC Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 23/36] mtd: nand: ecc: Let the software BCH ECC engine be a module Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 24/36] mtd: nand: ecc: Let the software Hamming ECC engine be unselected Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 25/36] mtd: nand: ecc: Create the software BCH engine instance Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 26/36] mtd: nand: ecc: Create the software Hamming " Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal [this message] 2019-03-04 22:28 ` [PATCH v2 27/36] mtd: nand: Let software ECC engines be retrieved from the NAND core Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 28/36] mtd: spinand: Fix typo in comment Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 29/36] mtd: spinand: Move ECC related definitions earlier in the driver Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 30/36] mtd: spinand: Instantiate a SPI-NAND on-die ECC engine Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 31/36] mtd: nand: Let on-die ECC engines be retrieved from the NAND core Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 32/36] mtd: rawnand: Fill a default ECC provider/algorithm Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 33/36] mtd: spinand: " Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 34/36] mtd: nand: Add helpers to manage ECC engines and configurations Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 35/36] mtd: spinand: Use the external ECC engine logic Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal 2019-03-04 22:28 ` [PATCH v2 36/36] mtd: spinand: Propagate ECC information to the MTD structure Miquel Raynal 2019-03-04 22:28 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190304222841.13899-28-miquel.raynal@bootlin.com \ --to=miquel.raynal@bootlin.com \ --cc=Tudor.Ambarus@microchip.com \ --cc=bbrezillon@kernel.org \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=frieder.schrempf@kontron.de \ --cc=juliensu@mxic.com.tw \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=masonccyang@mxic.com.tw \ --cc=paul@crapouillou.net \ --cc=richard@nod.at \ --cc=thomas.petazzoni@bootlin.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.