All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: axboe@fb.com
Cc: Matias Bjorling <mb@lightnvm.io>,
	linux-block@vger.kernel.org,
	Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: [PATCH 6/6] block: mark blk_rq_bio_prep as inline
Date: Thu,  6 Jun 2019 12:29:04 +0200	[thread overview]
Message-ID: <20190606102904.4024-7-hch@lst.de> (raw)
In-Reply-To: <20190606102904.4024-1-hch@lst.de>

This function just has a few trivial assignments, has two callers with
one of them being in the fastpath.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
 block/blk-core.c | 11 -----------
 block/blk.h      | 13 ++++++++++++-
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index 2287b8c2979c..42f8f09dacf0 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1415,17 +1415,6 @@ bool blk_update_request(struct request *req, blk_status_t error,
 }
 EXPORT_SYMBOL_GPL(blk_update_request);
 
-void blk_rq_bio_prep(struct request *rq, struct bio *bio, unsigned int nr_segs)
-{
-	rq->nr_phys_segments = nr_segs;
-	rq->__data_len = bio->bi_iter.bi_size;
-	rq->bio = rq->biotail = bio;
-	rq->ioprio = bio_prio(bio);
-
-	if (bio->bi_disk)
-		rq->rq_disk = bio->bi_disk;
-}
-
 #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
 /**
  * rq_flush_dcache_pages - Helper function to flush all pages in a request
diff --git a/block/blk.h b/block/blk.h
index befdab456209..2097b1905dc7 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -50,7 +50,6 @@ struct blk_flush_queue *blk_alloc_flush_queue(struct request_queue *q,
 		int node, int cmd_size, gfp_t flags);
 void blk_free_flush_queue(struct blk_flush_queue *q);
 
-void blk_rq_bio_prep(struct request *rq, struct bio *bio, unsigned int nr_segs);
 void blk_freeze_queue(struct request_queue *q);
 
 static inline void blk_queue_enter_live(struct request_queue *q)
@@ -99,6 +98,18 @@ static inline bool bvec_gap_to_prev(struct request_queue *q,
 	return __bvec_gap_to_prev(q, bprv, offset);
 }
 
+static inline void blk_rq_bio_prep(struct request *rq, struct bio *bio,
+		unsigned int nr_segs)
+{
+	rq->nr_phys_segments = nr_segs;
+	rq->__data_len = bio->bi_iter.bi_size;
+	rq->bio = rq->biotail = bio;
+	rq->ioprio = bio_prio(bio);
+
+	if (bio->bi_disk)
+		rq->rq_disk = bio->bi_disk;
+}
+
 #ifdef CONFIG_BLK_DEV_INTEGRITY
 void blk_flush_integrity(void);
 bool __bio_integrity_endio(struct bio *);
-- 
2.20.1


  parent reply	other threads:[~2019-06-06 10:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06 10:28 remove bi_phys_segments and related cleanups Christoph Hellwig
2019-06-06 10:28 ` [PATCH 1/6] block: initialize the write priority in blk_rq_bio_prep Christoph Hellwig
2019-06-07  5:58   ` Hannes Reinecke
2019-06-07 12:20   ` Minwoo Im
2019-06-20 13:40   ` Minwoo Im
2019-06-06 10:29 ` [PATCH 2/6] block: remove blk_init_request_from_bio Christoph Hellwig
2019-06-07  5:59   ` Hannes Reinecke
2019-06-07 12:23   ` Minwoo Im
2019-06-07 12:57   ` Javier González
2019-06-09 19:51   ` Matias Bjørling
2019-06-06 10:29 ` [PATCH 3/6] block: remove the bi_phys_segments field in struct bio Christoph Hellwig
2019-06-07  6:02   ` Hannes Reinecke
2019-06-07 16:45     ` Christoph Hellwig
2019-06-09 22:17     ` Nikolay Borisov
2019-06-10 18:30   ` Bart Van Assche
2019-06-06 10:29 ` [PATCH 4/6] block: simplify blk_recalc_rq_segments Christoph Hellwig
2019-06-07  6:03   ` Hannes Reinecke
2019-06-06 10:29 ` [PATCH 5/6] block: untangle the end of blk_bio_segment_split Christoph Hellwig
2019-06-07  6:04   ` Hannes Reinecke
2019-06-06 10:29 ` Christoph Hellwig [this message]
2019-06-07  6:04   ` [PATCH 6/6] block: mark blk_rq_bio_prep as inline Hannes Reinecke
2019-06-20  9:44 ` remove bi_phys_segments and related cleanups Christoph Hellwig
2019-06-20 16:33 ` Jens Axboe
2019-07-01 16:46   ` Jens Axboe
2019-07-02 13:34     ` Christoph Hellwig
     [not found]       ` <bfe8a4b5-901e-5ac4-e11c-0e6ccc4faec2@kernel.dk>
2019-07-02 18:29         ` Christoph Hellwig
2019-07-02 18:37           ` Jens Axboe
2019-07-03  0:00             ` Christoph Hellwig
2019-07-03  1:10               ` Jens Axboe
2019-07-03  1:32                 ` Jens Axboe
2019-07-03  1:35                   ` Christoph Hellwig
2019-07-03 12:16                     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190606102904.4024-7-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.