From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>,
ksummit-discuss@lists.linuxfoundation.org,
linux-nvdimm@lists.01.org,
Vishal Verma <vishal.l.verma@intel.com>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile
Date: Wed, 11 Sep 2019 21:43:33 +0300 [thread overview]
Message-ID: <20190911184332.GL20699@kadam> (raw)
In-Reply-To: <156821693963.2951081.11214256396118531359.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, Sep 11, 2019 at 08:48:59AM -0700, Dan Williams wrote:
> +Coding Style Addendum
> +---------------------
> +libnvdimm expects multi-line statements to be double indented. I.e.
> +
> + if (x...
> + && ...y) {
That looks horrible and it causes a checkpatch warning. :( Why not
do it the same way that everyone else does it.
if (blah_blah_x && <-- && has to be on the first line for checkpatch
blah_blah_y) { <-- [tab][space][space][space][space]blah
Now all the conditions are aligned visually which makes it readable.
They aren't aligned with the indent block so it's easy to tell the
inside from the if condition.
I kind of hate all this extra documentation because now everyone thinks
they can invent new hoops to jump through.
Speaking of hoops, the BPF documentation says that you have to figure
out which tree a patch applies to instead of just working against
linux-next. Is there an automated way to do that? I looked through my
inbox and there are a bunch of patches marked as going through the
bpf-next tree but about half were marked incorrectly so it looks like
everyone who tries to tag their patches is going to do it badly anyway.
regards,
dan carpenter
_______________________________________________
Ksummit-discuss mailing list
Ksummit-discuss@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: ksummit-discuss@lists.linuxfoundation.org,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile
Date: Wed, 11 Sep 2019 21:43:33 +0300 [thread overview]
Message-ID: <20190911184332.GL20699@kadam> (raw)
In-Reply-To: <156821693963.2951081.11214256396118531359.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, Sep 11, 2019 at 08:48:59AM -0700, Dan Williams wrote:
> +Coding Style Addendum
> +---------------------
> +libnvdimm expects multi-line statements to be double indented. I.e.
> +
> + if (x...
> + && ...y) {
That looks horrible and it causes a checkpatch warning. :( Why not
do it the same way that everyone else does it.
if (blah_blah_x && <-- && has to be on the first line for checkpatch
blah_blah_y) { <-- [tab][space][space][space][space]blah
Now all the conditions are aligned visually which makes it readable.
They aren't aligned with the indent block so it's easy to tell the
inside from the if condition.
I kind of hate all this extra documentation because now everyone thinks
they can invent new hoops to jump through.
Speaking of hoops, the BPF documentation says that you have to figure
out which tree a patch applies to instead of just working against
linux-next. Is there an automated way to do that? I looked through my
inbox and there are a bunch of patches marked as going through the
bpf-next tree but about half were marked incorrectly so it looks like
everyone who tries to tag their patches is going to do it badly anyway.
regards,
dan carpenter
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-kernel@vger.kernel.org,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
ksummit-discuss@lists.linuxfoundation.org,
linux-nvdimm@lists.01.org, bpf@vger.kernel.org
Subject: Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile
Date: Wed, 11 Sep 2019 21:43:33 +0300 [thread overview]
Message-ID: <20190911184332.GL20699@kadam> (raw)
In-Reply-To: <156821693963.2951081.11214256396118531359.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, Sep 11, 2019 at 08:48:59AM -0700, Dan Williams wrote:
> +Coding Style Addendum
> +---------------------
> +libnvdimm expects multi-line statements to be double indented. I.e.
> +
> + if (x...
> + && ...y) {
That looks horrible and it causes a checkpatch warning. :( Why not
do it the same way that everyone else does it.
if (blah_blah_x && <-- && has to be on the first line for checkpatch
blah_blah_y) { <-- [tab][space][space][space][space]blah
Now all the conditions are aligned visually which makes it readable.
They aren't aligned with the indent block so it's easy to tell the
inside from the if condition.
I kind of hate all this extra documentation because now everyone thinks
they can invent new hoops to jump through.
Speaking of hoops, the BPF documentation says that you have to figure
out which tree a patch applies to instead of just working against
linux-next. Is there an automated way to do that? I looked through my
inbox and there are a bunch of patches marked as going through the
bpf-next tree but about half were marked incorrectly so it looks like
everyone who tries to tag their patches is going to do it badly anyway.
regards,
dan carpenter
next prev parent reply other threads:[~2019-09-11 18:43 UTC|newest]
Thread overview: 227+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 15:48 [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles Dan Williams
2019-09-11 15:48 ` Dan Williams
2019-09-11 15:48 ` Dan Williams
2019-09-11 15:48 ` [Ksummit-discuss] [PATCH v2 1/3] MAINTAINERS: Reclaim the P: tag for Maintainer Entry Profile Dan Williams
2019-09-11 15:48 ` Dan Williams
2019-09-11 15:48 ` Dan Williams
2019-09-13 15:37 ` [Ksummit-discuss] " Mauro Carvalho Chehab
2019-09-13 15:37 ` Mauro Carvalho Chehab
2019-09-13 15:37 ` Mauro Carvalho Chehab
2019-09-11 15:48 ` [Ksummit-discuss] [PATCH v2 2/3] Maintainer Handbook: " Dan Williams
2019-09-11 15:48 ` Dan Williams
2019-09-11 15:48 ` Dan Williams
2019-09-11 17:34 ` [Ksummit-discuss] " Verma, Vishal L
2019-09-11 17:34 ` Verma, Vishal L
2019-09-16 12:35 ` Jani Nikula
2019-09-16 12:35 ` Jani Nikula
2019-09-16 12:35 ` Jani Nikula
2019-10-01 13:55 ` Jonathan Corbet
2019-10-01 13:55 ` Jonathan Corbet
2019-10-01 13:55 ` Jonathan Corbet
2019-10-01 18:17 ` [Ksummit-discuss] " Martin K. Petersen
2019-10-01 18:17 ` Martin K. Petersen
2019-10-01 18:17 ` Martin K. Petersen
2019-11-07 20:13 ` [Ksummit-discuss] " Jonathan Corbet
2019-11-07 20:13 ` Jonathan Corbet
2019-11-07 20:13 ` Jonathan Corbet
2019-11-08 2:41 ` [Ksummit-discuss] " Dan Williams
2019-11-08 2:41 ` Dan Williams
2019-11-08 2:41 ` Dan Williams
2019-09-11 15:48 ` [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: " Dan Williams
2019-09-11 15:48 ` Dan Williams
2019-09-11 15:48 ` Dan Williams
2019-09-11 17:42 ` [Ksummit-discuss] " Vishal Verma
2019-09-11 17:42 ` Vishal Verma
2019-09-11 17:42 ` Vishal Verma
2019-09-11 17:45 ` Dave Jiang
2019-09-11 17:45 ` Dave Jiang
2019-09-11 18:43 ` Dan Carpenter [this message]
2019-09-11 18:43 ` [Ksummit-discuss] " Dan Carpenter
2019-09-11 18:43 ` Dan Carpenter
2019-09-11 22:11 ` Jens Axboe
2019-09-11 22:11 ` Jens Axboe
2019-09-11 22:11 ` Jens Axboe
2019-09-12 7:41 ` Dan Williams
2019-09-12 7:41 ` Dan Williams
2019-09-12 7:41 ` Dan Williams
2019-09-12 8:24 ` Miguel Ojeda
2019-09-12 8:24 ` Miguel Ojeda
2019-09-12 10:18 ` Joe Perches
2019-09-12 10:18 ` Joe Perches
2019-09-12 10:18 ` Joe Perches
2019-09-12 11:02 ` Joe Perches
2019-09-12 11:02 ` Joe Perches
2019-09-12 14:17 ` Dan Williams
2019-09-12 14:17 ` Dan Williams
2019-09-12 14:51 ` Joe Perches
2019-09-12 14:51 ` Joe Perches
2019-09-12 14:42 ` Miguel Ojeda
2019-09-12 14:42 ` Miguel Ojeda
2019-09-13 7:09 ` Jonathan Corbet
2019-09-13 7:09 ` Jonathan Corbet
2019-09-13 7:09 ` Jonathan Corbet
2019-09-13 11:48 ` Dan Carpenter
2019-09-13 11:48 ` Dan Carpenter
2019-09-13 11:48 ` Dan Carpenter
2019-09-13 12:18 ` Dan Williams
2019-09-13 12:18 ` Dan Williams
2019-09-13 12:18 ` Dan Williams
2019-09-13 15:00 ` Randy Dunlap
2019-09-13 15:00 ` Randy Dunlap
2019-09-13 15:00 ` Randy Dunlap
2019-09-13 15:46 ` Rob Herring
2019-09-13 15:46 ` Rob Herring
2019-09-13 15:46 ` Rob Herring
2019-09-13 16:42 ` Joe Perches
2019-09-13 16:42 ` Joe Perches
2019-09-13 16:42 ` Joe Perches
2019-09-13 19:32 ` Rob Herring
2019-09-13 19:32 ` Rob Herring
2019-09-13 19:32 ` Rob Herring
2019-09-13 17:57 ` Geert Uytterhoeven
2019-09-13 17:57 ` Geert Uytterhoeven
2019-09-13 17:57 ` Geert Uytterhoeven
2019-09-16 12:42 ` Jani Nikula
2019-09-16 12:42 ` Jani Nikula
2019-09-16 12:42 ` Jani Nikula
2019-09-17 16:16 ` Jason Gunthorpe
2019-09-17 21:59 ` Dan Williams
2019-09-17 21:59 ` Dan Williams
2019-09-17 21:59 ` Dan Williams
2019-09-13 21:44 ` Martin K. Petersen
2019-09-13 21:44 ` Martin K. Petersen
2019-09-13 21:44 ` Martin K. Petersen
2019-09-16 7:01 ` Dan Carpenter
2019-09-16 7:01 ` Dan Carpenter
2019-09-16 7:01 ` Dan Carpenter
2019-09-16 17:08 ` Martin K. Petersen
2019-09-16 17:08 ` Martin K. Petersen
2019-09-16 17:08 ` Martin K. Petersen
2019-09-16 17:15 ` Mark Brown
2019-09-16 17:15 ` Mark Brown
2019-09-13 2:11 ` Aneesh Kumar K.V
2019-09-13 2:11 ` Aneesh Kumar K.V
2019-09-13 5:00 ` Greg KH
2019-09-13 5:00 ` Greg KH
2019-09-11 20:30 ` Joe Perches
2019-09-11 20:30 ` Joe Perches
2019-09-11 20:30 ` Joe Perches
2019-09-13 16:19 ` [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation Mauro Carvalho Chehab
2019-09-13 16:19 ` Mauro Carvalho Chehab
2019-09-13 16:19 ` [Ksummit-discuss] " Mauro Carvalho Chehab
2019-09-17 3:35 ` [Ksummit-discuss] single maintainer profile directory (was Re: [PATCH] media: add a subsystem profile documentation) Kees Cook
2019-09-17 3:35 ` single maintainer profile directory (was Re: [Ksummit-discuss] " Kees Cook
2019-09-17 13:28 ` [Ksummit-discuss] single maintainer profile directory (was " Mauro Carvalho Chehab
2019-09-17 13:28 ` single maintainer profile directory (was Re: [Ksummit-discuss] " Mauro Carvalho Chehab
2019-09-17 16:33 ` [Ksummit-discuss] single maintainer profile directory (was " Kees Cook
2019-09-17 16:33 ` single maintainer profile directory (was Re: [Ksummit-discuss] " Kees Cook
2019-09-18 11:23 ` [Ksummit-discuss] single maintainer profile directory (was " Mauro Carvalho Chehab
2019-09-18 11:23 ` Mauro Carvalho Chehab
2019-09-18 17:39 ` Kees Cook
2019-09-18 17:39 ` Kees Cook
2019-09-18 18:35 ` Mauro Carvalho Chehab
2019-09-18 18:35 ` Mauro Carvalho Chehab
2019-09-21 19:13 ` Jonathan Corbet
2019-09-21 19:13 ` Jonathan Corbet
2019-09-21 19:45 ` Mauro Carvalho Chehab
2019-09-21 19:45 ` Mauro Carvalho Chehab
2019-09-23 22:45 ` Kees Cook
2019-09-23 22:45 ` Kees Cook
2019-09-18 12:36 ` [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation Laurent Pinchart
2019-09-18 12:36 ` Laurent Pinchart
2019-09-18 13:57 ` Mauro Carvalho Chehab
2019-09-18 13:57 ` Mauro Carvalho Chehab
2019-09-18 17:27 ` Laurent Pinchart
2019-09-18 17:27 ` Laurent Pinchart
2019-09-18 18:48 ` Mauro Carvalho Chehab
2019-09-18 18:48 ` Mauro Carvalho Chehab
2019-09-19 7:08 ` Dan Carpenter
2019-09-19 7:08 ` Dan Carpenter
2019-09-20 5:29 ` Joe Perches
2019-09-20 5:29 ` Joe Perches
2019-09-20 14:09 ` Daniel Vetter
2019-09-20 14:09 ` Daniel Vetter
2019-09-19 6:56 ` Dan Carpenter
2019-09-19 6:56 ` Dan Carpenter
2019-09-19 7:22 ` Geert Uytterhoeven
2019-09-19 7:22 ` Geert Uytterhoeven
2019-09-19 8:49 ` Jani Nikula
2019-09-19 8:49 ` Jani Nikula
2019-09-19 8:58 ` Geert Uytterhoeven
2019-09-19 8:58 ` Geert Uytterhoeven
2019-09-19 9:52 ` Jani Nikula
2019-09-19 9:52 ` Jani Nikula
2019-09-20 14:53 ` Laurent Pinchart
2019-09-20 14:53 ` Laurent Pinchart
2019-09-20 14:59 ` Doug Anderson
2019-09-20 14:59 ` Doug Anderson
2019-09-21 8:56 ` Jani Nikula
2019-09-21 8:56 ` Jani Nikula
2019-09-23 15:58 ` Doug Anderson
2019-09-23 15:58 ` Doug Anderson
2019-09-23 16:04 ` Jonathan Corbet
2019-09-23 16:04 ` Jonathan Corbet
2019-09-19 9:52 ` Mauro Carvalho Chehab
2019-09-19 9:52 ` Mauro Carvalho Chehab
2019-09-25 17:13 ` Joe Perches
2019-09-25 17:13 ` Joe Perches
2019-09-25 18:40 ` Kees Cook
2019-09-25 18:40 ` Kees Cook
2019-09-26 15:14 ` Joe Perches
2019-09-26 15:14 ` Joe Perches
2019-09-26 15:53 ` Kees Cook
2019-09-26 15:53 ` Kees Cook
2019-09-26 16:02 ` Joe Perches
2019-09-26 16:02 ` Joe Perches
2019-09-26 16:24 ` Kees Cook
2019-09-26 16:24 ` Kees Cook
2019-09-26 10:25 ` Geert Uytterhoeven
2019-09-26 10:25 ` Geert Uytterhoeven
2019-09-18 13:59 ` [Ksummit-discuss] [PATCH v2] " Mauro Carvalho Chehab
2019-09-18 13:59 ` Mauro Carvalho Chehab
2019-09-18 14:07 ` André Almeida
2019-09-18 14:11 ` [Ksummit-discuss] " Mauro Carvalho Chehab
2019-09-18 14:11 ` Mauro Carvalho Chehab
2019-09-11 16:40 ` [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles Martin K. Petersen
2019-09-11 16:40 ` Martin K. Petersen
2019-09-11 16:40 ` Martin K. Petersen
2019-09-12 13:31 ` [Ksummit-discuss] " Bart Van Assche
2019-09-12 13:31 ` Bart Van Assche
2019-09-12 13:31 ` Bart Van Assche
2019-09-12 15:34 ` Joe Perches
2019-09-12 15:34 ` Joe Perches
2019-09-12 15:34 ` Joe Perches
2019-09-12 20:01 ` Bart Van Assche
2019-09-12 20:01 ` Bart Van Assche
2019-09-12 20:01 ` Bart Van Assche
2019-09-12 20:34 ` Joe Perches
2019-09-12 20:34 ` Joe Perches
2019-09-12 20:34 ` Joe Perches
2019-09-13 14:26 ` Rob Herring
2019-09-13 14:26 ` Rob Herring
2019-09-13 14:26 ` Rob Herring
2019-09-13 18:42 ` Joe Perches
2019-09-13 18:42 ` Joe Perches
2019-09-13 18:42 ` Joe Perches
2019-09-13 19:17 ` Mauro Carvalho Chehab
2019-09-13 19:17 ` Mauro Carvalho Chehab
2019-09-13 19:17 ` Mauro Carvalho Chehab
2019-09-13 20:33 ` Joe Perches
2019-09-13 20:33 ` Joe Perches
2019-09-13 20:33 ` Joe Perches
2019-09-13 12:56 ` Matthew Wilcox
2019-09-13 12:56 ` Matthew Wilcox
2019-09-13 13:54 ` Mauro Carvalho Chehab
2019-09-13 13:54 ` Mauro Carvalho Chehab
2019-09-13 13:54 ` Mauro Carvalho Chehab
2019-09-13 14:59 ` Guenter Roeck
2019-09-13 14:59 ` Guenter Roeck
2019-09-13 14:59 ` Guenter Roeck
2019-09-13 22:03 ` Martin K. Petersen
2019-09-13 22:03 ` Martin K. Petersen
2019-09-13 22:03 ` Martin K. Petersen
2020-04-29 13:55 ` Roman Bolshakov
2020-04-29 13:55 ` Roman Bolshakov
2019-09-12 13:10 ` Bart Van Assche
2019-09-12 13:10 ` Bart Van Assche
2019-09-12 13:10 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911184332.GL20699@kadam \
--to=dan.carpenter@oracle.com \
--cc=bpf@vger.kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.