From: Joe Perches <joe@perches.com> To: Kees Cook <keescook@chromium.org> Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, ksummit-discuss@lists.linuxfoundation.org, Dan Carpenter <dan.carpenter@oracle.com>, Linux Media Mailing List <linux-media@vger.kernel.org> Subject: Re: [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation Date: Thu, 26 Sep 2019 09:02:07 -0700 [thread overview] Message-ID: <b2e180a2d2d1d205c426ec02051a002f2c77832e.camel@perches.com> (raw) In-Reply-To: <201909260848.B429B7DF@keescook> On Thu, 2019-09-26 at 08:53 -0700, Kees Cook wrote: > On Thu, Sep 26, 2019 at 08:14:03AM -0700, Joe Perches wrote: > > On Wed, 2019-09-25 at 11:40 -0700, Kees Cook wrote: > > > Is "6" a safe lower bound here? I thought 12 was the way to go? > > [] > > > $ git log | egrep 'Fixes: [a-f0-9]{1,40}' | col2 | awk '{print length }' | sort | uniq -c | sort -n | tail > > > 238 8 > > > 300 7 > > > 330 14 > > > 344 6 > > > 352 11 > > > 408 40 > > > 425 10 > > > 735 16 > > > 1866 13 > > > 31446 12 > > > > > > Hmpf, 6 is pretty high up there... > > > > Yes, but your grep then col2 isn't right. > > You are counting all the 'Fixes: commit <foo>' output > > as 6 because that's the length of 'commit'. > > the [a-f0-9]{1,40} already excludes "commit". No it doesn't as commit starts with c which matches [a-f0-9]{1,40} Try your original egrep command line yourself. Maybe use: $ git log | egrep 'Fixes: [a-f0-9]{1,40}' | awk '{ if (length($2) == 6) { print $0;} }' The first few matches are the commit referenced in Fixes: below replaced the call to Fixes: commit 18a992787896 ("ARM: ux500: move soc_id driver to drivers/soc") Fixes: commit 0580dde59438 ("ASoC: simple-card-utils: add asoc_simple_debug_info()") Since Fixes: 8c5421c016a4 ("perf pmu: Display pmu name when printing Fixes: commit 961fb3c206dc ("ASoC: rockchip: rk3399_gru_sound: don't select unnecessary Platform") > > I also think the length of the hex commit value doesn't > > matter much as it's got to be a specific single commit > > SHA1 anyway, otherwise the commit id lookup will fail. > > Fail enough. We do already have 6-digit SHA1 collisions, so it seemed > like using more than 6 would be nicer? *shrug* I don't have a strong > opinion. :) > > > > > > @@ -1031,6 +1040,7 @@ MAINTAINER field selection options: > > > > --roles => show roles (status:subsystem, git-signer, list, etc...) > > > > --rolestats => show roles and statistics (commits/total_commits, %) > > > > --file-emails => add email addresses found in -f file (default: 0 (off)) > > > > + --fixes => for patches, add signatures of commits with 'Fixes: <commit>' (default: 1 (on)) > > > > > > Should "Tested-by" and "Co-developed-by" get added to @signature_tags ? > > > > All "<foo>-by:" signatures are added. > > Ah, I'd missed where that happened. I do note that's only when > git-all-signature-types is set, which is default 0. (/me goes to add > this to his invocations...) > > my $email_git_all_signature_types = 0; > ... > if ($email_git_all_signature_types) { > $signature_pattern = "(.+?)[Bb][Yy]:"; > } else { > $signature_pattern = "\(" . join("|", @signature_tags) . "\)"; > } > > > > @commit_authors is unused? > > > > Yes, authors are already required to sign-off so > > it's just duplicating already existing signatures. > > Sure, it just seemed odd to populate it if it wasn't going to be used. It's a generic function. _______________________________________________ Ksummit-discuss mailing list Ksummit-discuss@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Kees Cook <keescook@chromium.org> Cc: Dan Carpenter <dan.carpenter@oracle.com>, Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, ksummit-discuss@lists.linuxfoundation.org, Linux Media Mailing List <linux-media@vger.kernel.org> Subject: Re: [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation Date: Thu, 26 Sep 2019 09:02:07 -0700 [thread overview] Message-ID: <b2e180a2d2d1d205c426ec02051a002f2c77832e.camel@perches.com> (raw) In-Reply-To: <201909260848.B429B7DF@keescook> On Thu, 2019-09-26 at 08:53 -0700, Kees Cook wrote: > On Thu, Sep 26, 2019 at 08:14:03AM -0700, Joe Perches wrote: > > On Wed, 2019-09-25 at 11:40 -0700, Kees Cook wrote: > > > Is "6" a safe lower bound here? I thought 12 was the way to go? > > [] > > > $ git log | egrep 'Fixes: [a-f0-9]{1,40}' | col2 | awk '{print length }' | sort | uniq -c | sort -n | tail > > > 238 8 > > > 300 7 > > > 330 14 > > > 344 6 > > > 352 11 > > > 408 40 > > > 425 10 > > > 735 16 > > > 1866 13 > > > 31446 12 > > > > > > Hmpf, 6 is pretty high up there... > > > > Yes, but your grep then col2 isn't right. > > You are counting all the 'Fixes: commit <foo>' output > > as 6 because that's the length of 'commit'. > > the [a-f0-9]{1,40} already excludes "commit". No it doesn't as commit starts with c which matches [a-f0-9]{1,40} Try your original egrep command line yourself. Maybe use: $ git log | egrep 'Fixes: [a-f0-9]{1,40}' | awk '{ if (length($2) == 6) { print $0;} }' The first few matches are the commit referenced in Fixes: below replaced the call to Fixes: commit 18a992787896 ("ARM: ux500: move soc_id driver to drivers/soc") Fixes: commit 0580dde59438 ("ASoC: simple-card-utils: add asoc_simple_debug_info()") Since Fixes: 8c5421c016a4 ("perf pmu: Display pmu name when printing Fixes: commit 961fb3c206dc ("ASoC: rockchip: rk3399_gru_sound: don't select unnecessary Platform") > > I also think the length of the hex commit value doesn't > > matter much as it's got to be a specific single commit > > SHA1 anyway, otherwise the commit id lookup will fail. > > Fail enough. We do already have 6-digit SHA1 collisions, so it seemed > like using more than 6 would be nicer? *shrug* I don't have a strong > opinion. :) > > > > > > @@ -1031,6 +1040,7 @@ MAINTAINER field selection options: > > > > --roles => show roles (status:subsystem, git-signer, list, etc...) > > > > --rolestats => show roles and statistics (commits/total_commits, %) > > > > --file-emails => add email addresses found in -f file (default: 0 (off)) > > > > + --fixes => for patches, add signatures of commits with 'Fixes: <commit>' (default: 1 (on)) > > > > > > Should "Tested-by" and "Co-developed-by" get added to @signature_tags ? > > > > All "<foo>-by:" signatures are added. > > Ah, I'd missed where that happened. I do note that's only when > git-all-signature-types is set, which is default 0. (/me goes to add > this to his invocations...) > > my $email_git_all_signature_types = 0; > ... > if ($email_git_all_signature_types) { > $signature_pattern = "(.+?)[Bb][Yy]:"; > } else { > $signature_pattern = "\(" . join("|", @signature_tags) . "\)"; > } > > > > @commit_authors is unused? > > > > Yes, authors are already required to sign-off so > > it's just duplicating already existing signatures. > > Sure, it just seemed odd to populate it if it wasn't going to be used. It's a generic function.
next prev parent reply other threads:[~2019-09-26 16:11 UTC|newest] Thread overview: 227+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-11 15:48 [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles Dan Williams 2019-09-11 15:48 ` Dan Williams 2019-09-11 15:48 ` Dan Williams 2019-09-11 15:48 ` [Ksummit-discuss] [PATCH v2 1/3] MAINTAINERS: Reclaim the P: tag for Maintainer Entry Profile Dan Williams 2019-09-11 15:48 ` Dan Williams 2019-09-11 15:48 ` Dan Williams 2019-09-13 15:37 ` [Ksummit-discuss] " Mauro Carvalho Chehab 2019-09-13 15:37 ` Mauro Carvalho Chehab 2019-09-13 15:37 ` Mauro Carvalho Chehab 2019-09-11 15:48 ` [Ksummit-discuss] [PATCH v2 2/3] Maintainer Handbook: " Dan Williams 2019-09-11 15:48 ` Dan Williams 2019-09-11 15:48 ` Dan Williams 2019-09-11 17:34 ` [Ksummit-discuss] " Verma, Vishal L 2019-09-11 17:34 ` Verma, Vishal L 2019-09-16 12:35 ` Jani Nikula 2019-09-16 12:35 ` Jani Nikula 2019-09-16 12:35 ` Jani Nikula 2019-10-01 13:55 ` Jonathan Corbet 2019-10-01 13:55 ` Jonathan Corbet 2019-10-01 13:55 ` Jonathan Corbet 2019-10-01 18:17 ` [Ksummit-discuss] " Martin K. Petersen 2019-10-01 18:17 ` Martin K. Petersen 2019-10-01 18:17 ` Martin K. Petersen 2019-11-07 20:13 ` [Ksummit-discuss] " Jonathan Corbet 2019-11-07 20:13 ` Jonathan Corbet 2019-11-07 20:13 ` Jonathan Corbet 2019-11-08 2:41 ` [Ksummit-discuss] " Dan Williams 2019-11-08 2:41 ` Dan Williams 2019-11-08 2:41 ` Dan Williams 2019-09-11 15:48 ` [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: " Dan Williams 2019-09-11 15:48 ` Dan Williams 2019-09-11 15:48 ` Dan Williams 2019-09-11 17:42 ` [Ksummit-discuss] " Vishal Verma 2019-09-11 17:42 ` Vishal Verma 2019-09-11 17:42 ` Vishal Verma 2019-09-11 17:45 ` Dave Jiang 2019-09-11 17:45 ` Dave Jiang 2019-09-11 18:43 ` [Ksummit-discuss] " Dan Carpenter 2019-09-11 18:43 ` Dan Carpenter 2019-09-11 18:43 ` Dan Carpenter 2019-09-11 22:11 ` Jens Axboe 2019-09-11 22:11 ` Jens Axboe 2019-09-11 22:11 ` Jens Axboe 2019-09-12 7:41 ` Dan Williams 2019-09-12 7:41 ` Dan Williams 2019-09-12 7:41 ` Dan Williams 2019-09-12 8:24 ` Miguel Ojeda 2019-09-12 8:24 ` Miguel Ojeda 2019-09-12 10:18 ` Joe Perches 2019-09-12 10:18 ` Joe Perches 2019-09-12 10:18 ` Joe Perches 2019-09-12 11:02 ` Joe Perches 2019-09-12 11:02 ` Joe Perches 2019-09-12 14:17 ` Dan Williams 2019-09-12 14:17 ` Dan Williams 2019-09-12 14:51 ` Joe Perches 2019-09-12 14:51 ` Joe Perches 2019-09-12 14:42 ` Miguel Ojeda 2019-09-12 14:42 ` Miguel Ojeda 2019-09-13 7:09 ` Jonathan Corbet 2019-09-13 7:09 ` Jonathan Corbet 2019-09-13 7:09 ` Jonathan Corbet 2019-09-13 11:48 ` Dan Carpenter 2019-09-13 11:48 ` Dan Carpenter 2019-09-13 11:48 ` Dan Carpenter 2019-09-13 12:18 ` Dan Williams 2019-09-13 12:18 ` Dan Williams 2019-09-13 12:18 ` Dan Williams 2019-09-13 15:00 ` Randy Dunlap 2019-09-13 15:00 ` Randy Dunlap 2019-09-13 15:00 ` Randy Dunlap 2019-09-13 15:46 ` Rob Herring 2019-09-13 15:46 ` Rob Herring 2019-09-13 15:46 ` Rob Herring 2019-09-13 16:42 ` Joe Perches 2019-09-13 16:42 ` Joe Perches 2019-09-13 16:42 ` Joe Perches 2019-09-13 19:32 ` Rob Herring 2019-09-13 19:32 ` Rob Herring 2019-09-13 19:32 ` Rob Herring 2019-09-13 17:57 ` Geert Uytterhoeven 2019-09-13 17:57 ` Geert Uytterhoeven 2019-09-13 17:57 ` Geert Uytterhoeven 2019-09-16 12:42 ` Jani Nikula 2019-09-16 12:42 ` Jani Nikula 2019-09-16 12:42 ` Jani Nikula 2019-09-17 16:16 ` Jason Gunthorpe 2019-09-17 21:59 ` Dan Williams 2019-09-17 21:59 ` Dan Williams 2019-09-17 21:59 ` Dan Williams 2019-09-13 21:44 ` Martin K. Petersen 2019-09-13 21:44 ` Martin K. Petersen 2019-09-13 21:44 ` Martin K. Petersen 2019-09-16 7:01 ` Dan Carpenter 2019-09-16 7:01 ` Dan Carpenter 2019-09-16 7:01 ` Dan Carpenter 2019-09-16 17:08 ` Martin K. Petersen 2019-09-16 17:08 ` Martin K. Petersen 2019-09-16 17:08 ` Martin K. Petersen 2019-09-16 17:15 ` Mark Brown 2019-09-16 17:15 ` Mark Brown 2019-09-13 2:11 ` Aneesh Kumar K.V 2019-09-13 2:11 ` Aneesh Kumar K.V 2019-09-13 5:00 ` Greg KH 2019-09-13 5:00 ` Greg KH 2019-09-11 20:30 ` Joe Perches 2019-09-11 20:30 ` Joe Perches 2019-09-11 20:30 ` Joe Perches 2019-09-13 16:19 ` [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation Mauro Carvalho Chehab 2019-09-13 16:19 ` Mauro Carvalho Chehab 2019-09-13 16:19 ` [Ksummit-discuss] " Mauro Carvalho Chehab 2019-09-17 3:35 ` [Ksummit-discuss] single maintainer profile directory (was Re: [PATCH] media: add a subsystem profile documentation) Kees Cook 2019-09-17 3:35 ` single maintainer profile directory (was Re: [Ksummit-discuss] " Kees Cook 2019-09-17 13:28 ` [Ksummit-discuss] single maintainer profile directory (was " Mauro Carvalho Chehab 2019-09-17 13:28 ` single maintainer profile directory (was Re: [Ksummit-discuss] " Mauro Carvalho Chehab 2019-09-17 16:33 ` [Ksummit-discuss] single maintainer profile directory (was " Kees Cook 2019-09-17 16:33 ` single maintainer profile directory (was Re: [Ksummit-discuss] " Kees Cook 2019-09-18 11:23 ` [Ksummit-discuss] single maintainer profile directory (was " Mauro Carvalho Chehab 2019-09-18 11:23 ` Mauro Carvalho Chehab 2019-09-18 17:39 ` Kees Cook 2019-09-18 17:39 ` Kees Cook 2019-09-18 18:35 ` Mauro Carvalho Chehab 2019-09-18 18:35 ` Mauro Carvalho Chehab 2019-09-21 19:13 ` Jonathan Corbet 2019-09-21 19:13 ` Jonathan Corbet 2019-09-21 19:45 ` Mauro Carvalho Chehab 2019-09-21 19:45 ` Mauro Carvalho Chehab 2019-09-23 22:45 ` Kees Cook 2019-09-23 22:45 ` Kees Cook 2019-09-18 12:36 ` [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation Laurent Pinchart 2019-09-18 12:36 ` Laurent Pinchart 2019-09-18 13:57 ` Mauro Carvalho Chehab 2019-09-18 13:57 ` Mauro Carvalho Chehab 2019-09-18 17:27 ` Laurent Pinchart 2019-09-18 17:27 ` Laurent Pinchart 2019-09-18 18:48 ` Mauro Carvalho Chehab 2019-09-18 18:48 ` Mauro Carvalho Chehab 2019-09-19 7:08 ` Dan Carpenter 2019-09-19 7:08 ` Dan Carpenter 2019-09-20 5:29 ` Joe Perches 2019-09-20 5:29 ` Joe Perches 2019-09-20 14:09 ` Daniel Vetter 2019-09-20 14:09 ` Daniel Vetter 2019-09-19 6:56 ` Dan Carpenter 2019-09-19 6:56 ` Dan Carpenter 2019-09-19 7:22 ` Geert Uytterhoeven 2019-09-19 7:22 ` Geert Uytterhoeven 2019-09-19 8:49 ` Jani Nikula 2019-09-19 8:49 ` Jani Nikula 2019-09-19 8:58 ` Geert Uytterhoeven 2019-09-19 8:58 ` Geert Uytterhoeven 2019-09-19 9:52 ` Jani Nikula 2019-09-19 9:52 ` Jani Nikula 2019-09-20 14:53 ` Laurent Pinchart 2019-09-20 14:53 ` Laurent Pinchart 2019-09-20 14:59 ` Doug Anderson 2019-09-20 14:59 ` Doug Anderson 2019-09-21 8:56 ` Jani Nikula 2019-09-21 8:56 ` Jani Nikula 2019-09-23 15:58 ` Doug Anderson 2019-09-23 15:58 ` Doug Anderson 2019-09-23 16:04 ` Jonathan Corbet 2019-09-23 16:04 ` Jonathan Corbet 2019-09-19 9:52 ` Mauro Carvalho Chehab 2019-09-19 9:52 ` Mauro Carvalho Chehab 2019-09-25 17:13 ` Joe Perches 2019-09-25 17:13 ` Joe Perches 2019-09-25 18:40 ` Kees Cook 2019-09-25 18:40 ` Kees Cook 2019-09-26 15:14 ` Joe Perches 2019-09-26 15:14 ` Joe Perches 2019-09-26 15:53 ` Kees Cook 2019-09-26 15:53 ` Kees Cook 2019-09-26 16:02 ` Joe Perches [this message] 2019-09-26 16:02 ` Joe Perches 2019-09-26 16:24 ` Kees Cook 2019-09-26 16:24 ` Kees Cook 2019-09-26 10:25 ` Geert Uytterhoeven 2019-09-26 10:25 ` Geert Uytterhoeven 2019-09-18 13:59 ` [Ksummit-discuss] [PATCH v2] " Mauro Carvalho Chehab 2019-09-18 13:59 ` Mauro Carvalho Chehab 2019-09-18 14:07 ` André Almeida 2019-09-18 14:11 ` [Ksummit-discuss] " Mauro Carvalho Chehab 2019-09-18 14:11 ` Mauro Carvalho Chehab 2019-09-11 16:40 ` [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles Martin K. Petersen 2019-09-11 16:40 ` Martin K. Petersen 2019-09-11 16:40 ` Martin K. Petersen 2019-09-12 13:31 ` [Ksummit-discuss] " Bart Van Assche 2019-09-12 13:31 ` Bart Van Assche 2019-09-12 13:31 ` Bart Van Assche 2019-09-12 15:34 ` Joe Perches 2019-09-12 15:34 ` Joe Perches 2019-09-12 15:34 ` Joe Perches 2019-09-12 20:01 ` Bart Van Assche 2019-09-12 20:01 ` Bart Van Assche 2019-09-12 20:01 ` Bart Van Assche 2019-09-12 20:34 ` Joe Perches 2019-09-12 20:34 ` Joe Perches 2019-09-12 20:34 ` Joe Perches 2019-09-13 14:26 ` Rob Herring 2019-09-13 14:26 ` Rob Herring 2019-09-13 14:26 ` Rob Herring 2019-09-13 18:42 ` Joe Perches 2019-09-13 18:42 ` Joe Perches 2019-09-13 18:42 ` Joe Perches 2019-09-13 19:17 ` Mauro Carvalho Chehab 2019-09-13 19:17 ` Mauro Carvalho Chehab 2019-09-13 19:17 ` Mauro Carvalho Chehab 2019-09-13 20:33 ` Joe Perches 2019-09-13 20:33 ` Joe Perches 2019-09-13 20:33 ` Joe Perches 2019-09-13 12:56 ` Matthew Wilcox 2019-09-13 12:56 ` Matthew Wilcox 2019-09-13 13:54 ` Mauro Carvalho Chehab 2019-09-13 13:54 ` Mauro Carvalho Chehab 2019-09-13 13:54 ` Mauro Carvalho Chehab 2019-09-13 14:59 ` Guenter Roeck 2019-09-13 14:59 ` Guenter Roeck 2019-09-13 14:59 ` Guenter Roeck 2019-09-13 22:03 ` Martin K. Petersen 2019-09-13 22:03 ` Martin K. Petersen 2019-09-13 22:03 ` Martin K. Petersen 2020-04-29 13:55 ` Roman Bolshakov 2020-04-29 13:55 ` Roman Bolshakov 2019-09-12 13:10 ` Bart Van Assche 2019-09-12 13:10 ` Bart Van Assche 2019-09-12 13:10 ` Bart Van Assche
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b2e180a2d2d1d205c426ec02051a002f2c77832e.camel@perches.com \ --to=joe@perches.com \ --cc=dan.carpenter@oracle.com \ --cc=keescook@chromium.org \ --cc=ksummit-discuss@lists.linuxfoundation.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab+samsung@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.