From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Hyunki Koo <kkoos00@naver.com>, HYUN-KI KOO <hyunki00.koo@samsung.com>, Shinbeom Choi <sbeom.choi@samsung.com>, Jiri Slaby <jslaby@suse.com>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/10] tty: serial: samsung_tty: drop unneded dbg() calls Date: Tue, 10 Dec 2019 15:37:02 +0100 [thread overview] Message-ID: <20191210143706.3928480-6-gregkh@linuxfoundation.org> (raw) In-Reply-To: <20191210143706.3928480-1-gregkh@linuxfoundation.org> Now that the kernel has ftrace, any debugging calls that just do "made it to this function!" and "leaving this function!" can be removed. On the quest to move the samsung_tty driver over to use the standard kernel debugging functions, drop these unneeded calls. Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Hyunki Koo <kkoos00@naver.com> Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> Cc: Shinbeom Choi <sbeom.choi@samsung.com> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/tty/serial/samsung_tty.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 1a3bf5879344..37749f09066d 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -1136,9 +1136,6 @@ static int s3c24xx_serial_startup(struct uart_port *port) struct s3c24xx_uart_port *ourport = to_ourport(port); int ret; - dbg("s3c24xx_serial_startup: port=%p (%08llx,%p)\n", - port, (unsigned long long)port->mapbase, port->membase); - rx_enabled(port) = 1; ret = request_irq(ourport->rx_irq, s3c24xx_serial_rx_chars, 0, @@ -1165,8 +1162,6 @@ static int s3c24xx_serial_startup(struct uart_port *port) ourport->tx_claimed = 1; - dbg("s3c24xx_serial_startup ok\n"); - /* the port reset code should have done the correct * register setup for the port controls */ @@ -1184,9 +1179,6 @@ static int s3c64xx_serial_startup(struct uart_port *port) unsigned int ufcon; int ret; - dbg("s3c64xx_serial_startup: port=%p (%08llx,%p)\n", - port, (unsigned long long)port->mapbase, port->membase); - wr_regl(port, S3C64XX_UINTM, 0xf); if (ourport->dma) { ret = s3c24xx_serial_request_dma(ourport); @@ -1224,7 +1216,6 @@ static int s3c64xx_serial_startup(struct uart_port *port) /* Enable Rx Interrupt */ s3c24xx_clear_bit(port, S3C64XX_UINTM_RXD, S3C64XX_UINTM); - dbg("s3c64xx_serial_startup ok\n"); return ret; } @@ -1870,8 +1861,6 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, struct resource *res; int ret; - dbg("s3c24xx_serial_init_port: port=%p, platdev=%p\n", port, platdev); - if (platdev == NULL) return -ENODEV; @@ -2011,8 +2000,6 @@ static int s3c24xx_serial_probe(struct platform_device *pdev) index = ret; } - dbg("s3c24xx_serial_probe(%p) %d\n", pdev, index); - if (index >= ARRAY_SIZE(s3c24xx_serial_ports)) { dev_err(&pdev->dev, "serial%d out of range\n", index); return -EINVAL; @@ -2273,10 +2260,6 @@ s3c24xx_serial_get_options(struct uart_port *port, int *baud, ucon = rd_regl(port, S3C2410_UCON); ubrdiv = rd_regl(port, S3C2410_UBRDIV); - dbg("s3c24xx_serial_get_options: port=%p\n" - "registers: ulcon=%08x, ucon=%08x, ubdriv=%08x\n", - port, ulcon, ucon, ubrdiv); - if (s3c24xx_port_configured(ucon)) { switch (ulcon & S3C2410_LCON_CSMASK) { case S3C2410_LCON_CS5: @@ -2334,9 +2317,6 @@ s3c24xx_serial_console_setup(struct console *co, char *options) int parity = 'n'; int flow = 'n'; - dbg("s3c24xx_serial_console_setup: co=%p (%d), %s\n", - co, co->index, options); - /* is this a valid port */ if (co->index == -1 || co->index >= CONFIG_SERIAL_SAMSUNG_UARTS) @@ -2351,8 +2331,6 @@ s3c24xx_serial_console_setup(struct console *co, char *options) cons_uart = port; - dbg("s3c24xx_serial_console_setup: port=%p (%d)\n", port, co->index); - /* * Check whether an invalid uart number has been specified, and * if so, search for the first available port that does have -- 2.24.0
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-serial@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>, Shinbeom Choi <sbeom.choi@samsung.com>, Hyunki Koo <kkoos00@naver.com>, Kukjin Kim <kgene@kernel.org>, linux-arm-kernel@lists.infradead.org, Jiri Slaby <jslaby@suse.com>, HYUN-KI KOO <hyunki00.koo@samsung.com> Subject: [PATCH 06/10] tty: serial: samsung_tty: drop unneded dbg() calls Date: Tue, 10 Dec 2019 15:37:02 +0100 [thread overview] Message-ID: <20191210143706.3928480-6-gregkh@linuxfoundation.org> (raw) In-Reply-To: <20191210143706.3928480-1-gregkh@linuxfoundation.org> Now that the kernel has ftrace, any debugging calls that just do "made it to this function!" and "leaving this function!" can be removed. On the quest to move the samsung_tty driver over to use the standard kernel debugging functions, drop these unneeded calls. Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Hyunki Koo <kkoos00@naver.com> Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> Cc: Shinbeom Choi <sbeom.choi@samsung.com> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/tty/serial/samsung_tty.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 1a3bf5879344..37749f09066d 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -1136,9 +1136,6 @@ static int s3c24xx_serial_startup(struct uart_port *port) struct s3c24xx_uart_port *ourport = to_ourport(port); int ret; - dbg("s3c24xx_serial_startup: port=%p (%08llx,%p)\n", - port, (unsigned long long)port->mapbase, port->membase); - rx_enabled(port) = 1; ret = request_irq(ourport->rx_irq, s3c24xx_serial_rx_chars, 0, @@ -1165,8 +1162,6 @@ static int s3c24xx_serial_startup(struct uart_port *port) ourport->tx_claimed = 1; - dbg("s3c24xx_serial_startup ok\n"); - /* the port reset code should have done the correct * register setup for the port controls */ @@ -1184,9 +1179,6 @@ static int s3c64xx_serial_startup(struct uart_port *port) unsigned int ufcon; int ret; - dbg("s3c64xx_serial_startup: port=%p (%08llx,%p)\n", - port, (unsigned long long)port->mapbase, port->membase); - wr_regl(port, S3C64XX_UINTM, 0xf); if (ourport->dma) { ret = s3c24xx_serial_request_dma(ourport); @@ -1224,7 +1216,6 @@ static int s3c64xx_serial_startup(struct uart_port *port) /* Enable Rx Interrupt */ s3c24xx_clear_bit(port, S3C64XX_UINTM_RXD, S3C64XX_UINTM); - dbg("s3c64xx_serial_startup ok\n"); return ret; } @@ -1870,8 +1861,6 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, struct resource *res; int ret; - dbg("s3c24xx_serial_init_port: port=%p, platdev=%p\n", port, platdev); - if (platdev == NULL) return -ENODEV; @@ -2011,8 +2000,6 @@ static int s3c24xx_serial_probe(struct platform_device *pdev) index = ret; } - dbg("s3c24xx_serial_probe(%p) %d\n", pdev, index); - if (index >= ARRAY_SIZE(s3c24xx_serial_ports)) { dev_err(&pdev->dev, "serial%d out of range\n", index); return -EINVAL; @@ -2273,10 +2260,6 @@ s3c24xx_serial_get_options(struct uart_port *port, int *baud, ucon = rd_regl(port, S3C2410_UCON); ubrdiv = rd_regl(port, S3C2410_UBRDIV); - dbg("s3c24xx_serial_get_options: port=%p\n" - "registers: ulcon=%08x, ucon=%08x, ubdriv=%08x\n", - port, ulcon, ucon, ubrdiv); - if (s3c24xx_port_configured(ucon)) { switch (ulcon & S3C2410_LCON_CSMASK) { case S3C2410_LCON_CS5: @@ -2334,9 +2317,6 @@ s3c24xx_serial_console_setup(struct console *co, char *options) int parity = 'n'; int flow = 'n'; - dbg("s3c24xx_serial_console_setup: co=%p (%d), %s\n", - co, co->index, options); - /* is this a valid port */ if (co->index == -1 || co->index >= CONFIG_SERIAL_SAMSUNG_UARTS) @@ -2351,8 +2331,6 @@ s3c24xx_serial_console_setup(struct console *co, char *options) cons_uart = port; - dbg("s3c24xx_serial_console_setup: port=%p (%d)\n", port, co->index); - /* * Check whether an invalid uart number has been specified, and * if so, search for the first available port that does have -- 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-10 14:37 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-10 14:36 [PATCH 01/10] tty: serial: samsung: allow driver to be built by anyone Greg Kroah-Hartman 2019-12-10 14:36 ` Greg Kroah-Hartman 2019-12-10 14:36 ` [PATCH 02/10] tty: serial: samsung_tty: fix build warning Greg Kroah-Hartman 2019-12-10 14:36 ` Greg Kroah-Hartman 2019-12-10 14:48 ` Krzysztof Kozlowski 2019-12-10 14:48 ` Krzysztof Kozlowski 2019-12-11 11:01 ` Enrico Weigelt, metux IT consult 2019-12-11 11:01 ` Enrico Weigelt, metux IT consult 2019-12-11 12:13 ` Greg Kroah-Hartman 2019-12-11 12:13 ` Greg Kroah-Hartman 2019-12-10 14:36 ` [PATCH 03/10] tty: serial: samsung.h: fix up minor comment issues Greg Kroah-Hartman 2019-12-10 14:36 ` Greg Kroah-Hartman 2019-12-10 15:12 ` Krzysztof Kozlowski 2019-12-10 15:12 ` Krzysztof Kozlowski 2019-12-12 11:06 ` Greg Kroah-Hartman 2019-12-12 11:06 ` Greg Kroah-Hartman 2019-12-10 14:37 ` [PATCH 04/10] tty: serial: samsung.h: remove reset_port callback from struct s3c24xx_uart_info Greg Kroah-Hartman 2019-12-10 14:37 ` Greg Kroah-Hartman 2019-12-10 14:50 ` Krzysztof Kozlowski 2019-12-10 14:50 ` Krzysztof Kozlowski 2019-12-10 14:37 ` [PATCH 05/10] tty: serial: samsung_tty: delete samsung.h Greg Kroah-Hartman 2019-12-10 14:37 ` Greg Kroah-Hartman 2019-12-10 14:52 ` Krzysztof Kozlowski 2019-12-10 14:52 ` Krzysztof Kozlowski 2019-12-10 14:37 ` Greg Kroah-Hartman [this message] 2019-12-10 14:37 ` [PATCH 06/10] tty: serial: samsung_tty: drop unneded dbg() calls Greg Kroah-Hartman 2019-12-10 14:53 ` Krzysztof Kozlowski 2019-12-10 14:53 ` Krzysztof Kozlowski 2019-12-10 14:37 ` [PATCH 07/10] tty: serial: samsung_tty: use standard debugging macros Greg Kroah-Hartman 2019-12-10 14:37 ` Greg Kroah-Hartman 2019-12-10 15:10 ` Krzysztof Kozlowski 2019-12-10 15:10 ` Krzysztof Kozlowski 2019-12-10 14:37 ` [PATCH 08/10] tty: serial: samsung_tty: use 'unsigned int' not 'unsigned' Greg Kroah-Hartman 2019-12-10 14:37 ` Greg Kroah-Hartman 2019-12-10 15:10 ` Krzysztof Kozlowski 2019-12-10 15:10 ` Krzysztof Kozlowski 2019-12-10 15:12 ` Marc Gonzalez 2019-12-10 15:12 ` Marc Gonzalez 2019-12-12 11:08 ` Greg Kroah-Hartman 2019-12-12 11:08 ` Greg Kroah-Hartman 2019-12-12 16:09 ` Christoph Hellwig 2019-12-12 16:09 ` Christoph Hellwig 2019-12-12 16:12 ` Greg Kroah-Hartman 2019-12-12 16:12 ` Greg Kroah-Hartman 2019-12-19 9:25 ` Marc Gonzalez 2019-12-19 9:25 ` Marc Gonzalez 2019-12-10 14:37 ` [PATCH 09/10] tty: serial: samsung_tty: fix up minor comment formatting Greg Kroah-Hartman 2019-12-10 14:37 ` Greg Kroah-Hartman 2019-12-10 15:14 ` Krzysztof Kozlowski 2019-12-10 15:14 ` Krzysztof Kozlowski 2019-12-10 14:37 ` [PATCH 10/10] tty: serial: samsung_tty: fix blank line checkpatch warning Greg Kroah-Hartman 2019-12-10 14:37 ` Greg Kroah-Hartman 2019-12-10 15:13 ` Krzysztof Kozlowski 2019-12-10 15:13 ` Krzysztof Kozlowski 2019-12-12 11:09 ` Greg Kroah-Hartman 2019-12-12 11:09 ` Greg Kroah-Hartman 2019-12-10 14:46 ` [PATCH 01/10] tty: serial: samsung: allow driver to be built by anyone Krzysztof Kozlowski 2019-12-10 14:46 ` Krzysztof Kozlowski 2019-12-10 14:54 ` Greg Kroah-Hartman 2019-12-10 14:54 ` Greg Kroah-Hartman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191210143706.3928480-6-gregkh@linuxfoundation.org \ --to=gregkh@linuxfoundation.org \ --cc=hyunki00.koo@samsung.com \ --cc=jslaby@suse.com \ --cc=kgene@kernel.org \ --cc=kkoos00@naver.com \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=sbeom.choi@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.