From: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> To: jani.nikula@linux.intel.com, daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, "Harry Wentland" <harry.wentland@amd.com>, "Leo Li" <sunpeng.li@amd.com>, "Alex Deucher" <alexander.deucher@amd.com>, "Christian König" <christian.koenig@amd.com>, "David (ChunMing) Zhou" <David1.Zhou@amd.com>, "David Airlie" <airlied@linux.ie>, "Mikita Lipski" <mikita.lipski@amd.com>, "Lyude Paul" <lyude@redhat.com>, "Nicholas Kazlauskas" <Nicholas.Kazlauskas@amd.com>, "David Francis" <David.Francis@amd.com>, "Pankaj Bharadiya" <pankaj.laxminarayan.bharadiya@intel.com> Subject: [PATCH 3/9] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls Date: Mon, 2 Mar 2020 18:26:43 +0530 [thread overview] Message-ID: <20200302125649.61443-4-pankaj.laxminarayan.bharadiya@intel.com> (raw) In-Reply-To: <20200302125649.61443-1-pankaj.laxminarayan.bharadiya@intel.com> drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c index 0ef0eeb16778..0c4faba8ed28 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c @@ -440,9 +440,6 @@ dm_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, static void dm_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_connector *connector) { - struct amdgpu_dm_connector *master = container_of(mgr, struct amdgpu_dm_connector, mst_mgr); - struct drm_device *dev = master->base.dev; - struct amdgpu_device *adev = dev->dev_private; struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector); DRM_INFO("DM_MST: Disabling connector: %p [id: %d] [master: %p]\n", @@ -457,21 +454,11 @@ static void dm_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr, } drm_connector_unregister(connector); - if (adev->mode_info.rfbdev) - drm_fb_helper_remove_one_connector(&adev->mode_info.rfbdev->helper, connector); drm_connector_put(connector); } static void dm_dp_mst_register_connector(struct drm_connector *connector) { - struct drm_device *dev = connector->dev; - struct amdgpu_device *adev = dev->dev_private; - - if (adev->mode_info.rfbdev) - drm_fb_helper_add_one_connector(&adev->mode_info.rfbdev->helper, connector); - else - DRM_ERROR("adev->mode_info.rfbdev is NULL\n"); - drm_connector_register(connector); } -- 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> To: jani.nikula@linux.intel.com, daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, "Harry Wentland" <harry.wentland@amd.com>, "Leo Li" <sunpeng.li@amd.com>, "Alex Deucher" <alexander.deucher@amd.com>, "Christian König" <christian.koenig@amd.com>, "David (ChunMing) Zhou" <David1.Zhou@amd.com>, "David Airlie" <airlied@linux.ie>, "Mikita Lipski" <mikita.lipski@amd.com>, "Lyude Paul" <lyude@redhat.com>, "Nicholas Kazlauskas" <Nicholas.Kazlauskas@amd.com>, "David Francis" <David.Francis@amd.com>, "Pankaj Bharadiya" <pankaj.laxminarayan.bharadiya@intel.com> Subject: [Intel-gfx] [PATCH 3/9] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls Date: Mon, 2 Mar 2020 18:26:43 +0530 [thread overview] Message-ID: <20200302125649.61443-4-pankaj.laxminarayan.bharadiya@intel.com> (raw) In-Reply-To: <20200302125649.61443-1-pankaj.laxminarayan.bharadiya@intel.com> drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c index 0ef0eeb16778..0c4faba8ed28 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c @@ -440,9 +440,6 @@ dm_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, static void dm_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_connector *connector) { - struct amdgpu_dm_connector *master = container_of(mgr, struct amdgpu_dm_connector, mst_mgr); - struct drm_device *dev = master->base.dev; - struct amdgpu_device *adev = dev->dev_private; struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector); DRM_INFO("DM_MST: Disabling connector: %p [id: %d] [master: %p]\n", @@ -457,21 +454,11 @@ static void dm_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr, } drm_connector_unregister(connector); - if (adev->mode_info.rfbdev) - drm_fb_helper_remove_one_connector(&adev->mode_info.rfbdev->helper, connector); drm_connector_put(connector); } static void dm_dp_mst_register_connector(struct drm_connector *connector) { - struct drm_device *dev = connector->dev; - struct amdgpu_device *adev = dev->dev_private; - - if (adev->mode_info.rfbdev) - drm_fb_helper_add_one_connector(&adev->mode_info.rfbdev->helper, connector); - else - DRM_ERROR("adev->mode_info.rfbdev is NULL\n"); - drm_connector_register(connector); } -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-02 13:09 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-02 12:56 [PATCH 0/9] drm: drm_fb_helper cleanup Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 12:56 ` [PATCH 1/9] drm: Remove unused arg from drm_fb_helper_init Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 13:44 ` Thomas Zimmermann 2020-03-02 13:44 ` [Intel-gfx] " Thomas Zimmermann 2020-03-02 21:38 ` Alex Deucher 2020-03-02 21:38 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` [PATCH 2/9] drm/radeon: remove radeon_fb_{add, remove}_connector functions Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 21:41 ` Alex Deucher 2020-03-02 21:41 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` Pankaj Bharadiya [this message] 2020-03-02 12:56 ` [Intel-gfx] [PATCH 3/9] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls Pankaj Bharadiya 2020-03-02 21:41 ` Alex Deucher 2020-03-02 21:41 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` [PATCH 4/9] drm/i915/display: " Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 21:42 ` Alex Deucher 2020-03-02 21:42 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` [PATCH 5/9] drm: Remove drm_fb_helper add, add all and remove connector calls Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 21:42 ` Alex Deucher 2020-03-02 21:42 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` [PATCH 6/9] drm/nouveau: Fix unused variable warning Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 13:30 ` Laurent Pinchart 2020-03-02 13:30 ` [Intel-gfx] " Laurent Pinchart 2020-03-03 18:58 ` Lyude Paul 2020-03-03 18:58 ` [Intel-gfx] " Lyude Paul 2020-03-02 12:56 ` [PATCH 7/9] drm/bridge: remove unused variable warning in tc358764_detach Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 13:27 ` Laurent Pinchart 2020-03-02 13:27 ` [Intel-gfx] " Laurent Pinchart 2020-03-02 12:56 ` [PATCH 8/9] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 13:27 ` Laurent Pinchart 2020-03-02 13:27 ` [Intel-gfx] " Laurent Pinchart 2020-03-02 21:43 ` Alex Deucher 2020-03-02 21:43 ` [Intel-gfx] " Alex Deucher 2020-03-02 12:56 ` [PATCH 9/9] drm/todo: Update drm_fb_helper tasks Pankaj Bharadiya 2020-03-02 12:56 ` [Intel-gfx] " Pankaj Bharadiya 2020-03-02 13:29 ` Laurent Pinchart 2020-03-02 13:29 ` [Intel-gfx] " Laurent Pinchart 2020-03-02 21:35 ` Daniel Vetter 2020-03-02 21:35 ` [Intel-gfx] " Daniel Vetter 2020-03-02 14:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: drm_fb_helper cleanup Patchwork 2020-03-02 14:47 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2020-03-02 15:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-03-02 15:58 ` [Intel-gfx] [PATCH 0/9] " Emil Velikov 2020-03-02 15:58 ` Emil Velikov 2020-03-02 16:17 ` Emil Velikov 2020-03-02 16:17 ` Emil Velikov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200302125649.61443-4-pankaj.laxminarayan.bharadiya@intel.com \ --to=pankaj.laxminarayan.bharadiya@intel.com \ --cc=David.Francis@amd.com \ --cc=David1.Zhou@amd.com \ --cc=Nicholas.Kazlauskas@amd.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=christian.koenig@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=harry.wentland@amd.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=lyude@redhat.com \ --cc=mikita.lipski@amd.com \ --cc=sunpeng.li@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.