From: Rob Herring <robh@kernel.org> To: Linus Walleij <linus.walleij@linaro.org>, Liviu Dudau <liviu.dudau@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Sudeep Holla <sudeep.holla@arm.com> Cc: Arnd Bergmann <arnd@arndb.de>, Catalin Marinas <catalin.marinas@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Lee Jones <lee.jones@linaro.org>, Sebastian Reichel <sre@kernel.org>, Stephen Boyd <sboyd@kernel.org>, Will Deacon <will@kernel.org>, Kevin Brodsky <Kevin.Brodsky@arm.com>, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 11/17] mfd: vexpress-sysreg: Use devres API variants Date: Sun, 19 Apr 2020 12:08:04 -0500 [thread overview] Message-ID: <20200419170810.5738-12-robh@kernel.org> (raw) In-Reply-To: <20200419170810.5738-1-robh@kernel.org> Use the managed devm_gpiochip_add_data() and devm_mfd_add_devices() instead of their unmanaged counterparts. With this, no .remove() hook is needed for driver unbind. Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Lee Jones <lee.jones@linaro.org> Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/mfd/vexpress-sysreg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c index 90a4eda2ba2b..9fb37fa689e0 100644 --- a/drivers/mfd/vexpress-sysreg.c +++ b/drivers/mfd/vexpress-sysreg.c @@ -140,9 +140,9 @@ static int vexpress_sysreg_probe(struct platform_device *pdev) bgpio_init(mmc_gpio_chip, &pdev->dev, 0x4, base + SYS_MCI, NULL, NULL, NULL, NULL, 0); mmc_gpio_chip->ngpio = 2; - gpiochip_add_data(mmc_gpio_chip, NULL); + devm_gpiochip_add_data(&pdev->dev, mmc_gpio_chip, NULL); - return mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, + return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, vexpress_sysreg_cells, ARRAY_SIZE(vexpress_sysreg_cells), mem, 0, NULL); } -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Linus Walleij <linus.walleij@linaro.org>, Liviu Dudau <liviu.dudau@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Sudeep Holla <sudeep.holla@arm.com> Cc: Arnd Bergmann <arnd@arndb.de>, linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Kevin Brodsky <Kevin.Brodsky@arm.com>, Sebastian Reichel <sre@kernel.org>, Will Deacon <will@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Lee Jones <lee.jones@linaro.org>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 11/17] mfd: vexpress-sysreg: Use devres API variants Date: Sun, 19 Apr 2020 12:08:04 -0500 [thread overview] Message-ID: <20200419170810.5738-12-robh@kernel.org> (raw) In-Reply-To: <20200419170810.5738-1-robh@kernel.org> Use the managed devm_gpiochip_add_data() and devm_mfd_add_devices() instead of their unmanaged counterparts. With this, no .remove() hook is needed for driver unbind. Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Lee Jones <lee.jones@linaro.org> Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/mfd/vexpress-sysreg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c index 90a4eda2ba2b..9fb37fa689e0 100644 --- a/drivers/mfd/vexpress-sysreg.c +++ b/drivers/mfd/vexpress-sysreg.c @@ -140,9 +140,9 @@ static int vexpress_sysreg_probe(struct platform_device *pdev) bgpio_init(mmc_gpio_chip, &pdev->dev, 0x4, base + SYS_MCI, NULL, NULL, NULL, NULL, 0); mmc_gpio_chip->ngpio = 2; - gpiochip_add_data(mmc_gpio_chip, NULL); + devm_gpiochip_add_data(&pdev->dev, mmc_gpio_chip, NULL); - return mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, + return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, vexpress_sysreg_cells, ARRAY_SIZE(vexpress_sysreg_cells), mem, 0, NULL); } -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-19 17:08 UTC|newest] Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-19 17:07 [PATCH 00/17] Modularizing Versatile Express Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-19 17:07 ` [PATCH 01/17] ARM: vexpress: Move vexpress_flags_set() into arch code Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 15:17 ` Arnd Bergmann 2020-04-20 15:17 ` Arnd Bergmann 2020-04-22 10:15 ` Liviu Dudau 2020-04-22 10:15 ` Liviu Dudau 2020-04-22 19:04 ` Sudeep Holla 2020-04-22 19:04 ` Sudeep Holla 2020-04-19 17:07 ` [PATCH 02/17] arm64: vexpress: Don't select CONFIG_POWER_RESET_VEXPRESS Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 15:18 ` Arnd Bergmann 2020-04-20 15:18 ` Arnd Bergmann 2020-04-22 10:16 ` Liviu Dudau 2020-04-22 10:16 ` Liviu Dudau 2020-04-22 19:08 ` Sudeep Holla 2020-04-22 19:08 ` Sudeep Holla 2020-04-19 17:07 ` [PATCH 03/17] arm64: vexpress: Don't select CONFIG_VEXPRESS_CONFIG Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 15:18 ` Arnd Bergmann 2020-04-20 15:18 ` Arnd Bergmann 2020-04-22 19:09 ` Sudeep Holla 2020-04-22 19:09 ` Sudeep Holla 2020-04-19 17:07 ` [PATCH 04/17] power/reset: vexpress: Support building as a module Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 15:23 ` Arnd Bergmann 2020-04-20 15:23 ` Arnd Bergmann 2020-04-20 17:23 ` Rob Herring 2020-04-20 17:23 ` Rob Herring 2020-04-28 19:31 ` Sebastian Reichel 2020-04-28 19:31 ` Sebastian Reichel 2020-04-22 19:11 ` Sudeep Holla 2020-04-22 19:11 ` Sudeep Holla 2020-04-19 17:07 ` [PATCH 05/17] clk: versatile: Kill CONFIG_COMMON_CLK_VERSATILE Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 6:44 ` Linus Walleij 2020-04-20 6:44 ` Linus Walleij 2020-04-22 9:47 ` Stephen Boyd 2020-04-22 9:47 ` Stephen Boyd 2020-04-22 22:34 ` Rob Herring 2020-04-22 22:34 ` Rob Herring 2020-04-22 19:17 ` Sudeep Holla 2020-04-22 19:17 ` Sudeep Holla 2020-04-19 17:07 ` [PATCH 06/17] clk: versatile: Only enable SP810 on 32-bit by default Rob Herring 2020-04-19 17:07 ` Rob Herring 2020-04-20 15:26 ` Arnd Bergmann 2020-04-20 15:26 ` Arnd Bergmann 2020-04-20 17:48 ` Rob Herring 2020-04-20 17:48 ` Rob Herring 2020-04-20 20:07 ` Arnd Bergmann 2020-04-20 20:07 ` Arnd Bergmann 2020-04-22 9:48 ` Stephen Boyd 2020-04-22 9:48 ` Stephen Boyd 2020-04-22 10:20 ` Liviu Dudau 2020-04-22 10:20 ` Liviu Dudau 2020-04-22 20:52 ` Sudeep Holla 2020-04-22 20:52 ` Sudeep Holla 2020-04-23 15:38 ` Rob Herring 2020-04-23 15:38 ` Rob Herring 2020-04-19 17:08 ` [PATCH 07/17] clk: vexpress-osc: Use the devres clock API variants Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 15:26 ` Arnd Bergmann 2020-04-20 15:26 ` Arnd Bergmann 2020-04-22 9:51 ` Stephen Boyd 2020-04-22 9:51 ` Stephen Boyd 2020-04-22 10:21 ` Liviu Dudau 2020-04-22 10:21 ` Liviu Dudau 2020-04-22 20:56 ` Sudeep Holla 2020-04-22 20:56 ` Sudeep Holla 2020-04-19 17:08 ` [PATCH 08/17] clk: vexpress-osc: Support building as a module Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 15:27 ` Arnd Bergmann 2020-04-20 15:27 ` Arnd Bergmann 2020-04-20 17:18 ` Rob Herring 2020-04-20 17:18 ` Rob Herring 2020-04-22 11:01 ` Liviu Dudau 2020-04-22 11:01 ` Liviu Dudau 2020-04-22 21:08 ` Sudeep Holla 2020-04-22 21:08 ` Sudeep Holla 2020-04-23 13:45 ` Sudeep Holla 2020-04-23 13:45 ` Sudeep Holla 2020-04-23 15:53 ` Rob Herring 2020-04-23 15:53 ` Rob Herring 2020-04-23 16:58 ` Sudeep Holla 2020-04-23 16:58 ` Sudeep Holla 2020-04-19 17:08 ` [PATCH 09/17] mfd: vexpress-sysreg: Drop selecting CONFIG_CLKSRC_MMIO Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 15:29 ` Arnd Bergmann 2020-04-20 15:29 ` Arnd Bergmann 2020-04-22 11:02 ` Liviu Dudau 2020-04-22 11:02 ` Liviu Dudau 2020-04-19 17:08 ` [PATCH 10/17] mfd: vexpress-sysreg: Drop unused syscon child devices Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 15:30 ` Arnd Bergmann 2020-04-20 15:30 ` Arnd Bergmann 2020-04-22 11:18 ` Liviu Dudau 2020-04-22 11:18 ` Liviu Dudau 2020-04-19 17:08 ` Rob Herring [this message] 2020-04-19 17:08 ` [PATCH 11/17] mfd: vexpress-sysreg: Use devres API variants Rob Herring 2020-04-20 15:31 ` Arnd Bergmann 2020-04-20 15:31 ` Arnd Bergmann 2020-04-22 11:18 ` Liviu Dudau 2020-04-22 11:18 ` Liviu Dudau 2020-04-19 17:08 ` [PATCH 12/17] mfd: vexpress-sysreg: Support building as a module Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 15:32 ` Arnd Bergmann 2020-04-20 15:32 ` Arnd Bergmann 2020-04-20 17:05 ` Rob Herring 2020-04-20 17:05 ` Rob Herring 2020-04-19 17:08 ` [PATCH 13/17] bus: vexpress-config: Merge vexpress-syscfg into vexpress-config Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-20 11:45 ` Greg Kroah-Hartman 2020-04-20 11:45 ` Greg Kroah-Hartman 2020-04-22 11:22 ` Liviu Dudau 2020-04-22 11:22 ` Liviu Dudau 2020-04-19 17:08 ` [PATCH 14/17] bus: vexpress-config: simplify config bus probing Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-22 11:58 ` Liviu Dudau 2020-04-22 11:58 ` Liviu Dudau 2020-04-19 17:08 ` [PATCH 15/17] vexpress: Move site master init to vexpress-config bus Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-22 9:51 ` Stephen Boyd 2020-04-22 9:51 ` Stephen Boyd 2020-04-22 12:03 ` Liviu Dudau 2020-04-22 12:03 ` Liviu Dudau 2020-04-23 0:54 ` Rob Herring 2020-04-23 0:54 ` Rob Herring 2020-04-19 17:08 ` [PATCH 16/17] bus: vexpress-config: Support building as module Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-22 12:04 ` Liviu Dudau 2020-04-22 12:04 ` Liviu Dudau 2020-04-19 17:08 ` [PATCH 17/17] ARM: vexpress: Don't select VEXPRESS_CONFIG Rob Herring 2020-04-19 17:08 ` Rob Herring 2020-04-22 12:05 ` Liviu Dudau 2020-04-22 12:05 ` Liviu Dudau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200419170810.5738-12-robh@kernel.org \ --to=robh@kernel.org \ --cc=Kevin.Brodsky@arm.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=gregkh@linuxfoundation.org \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=liviu.dudau@arm.com \ --cc=lorenzo.pieralisi@arm.com \ --cc=sboyd@kernel.org \ --cc=sre@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.