From: Kees Cook <keescook@chromium.org>
To: Will Deacon <will@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Peter Collingbourne <pcc@google.com>,
James Morse <james.morse@arm.com>, Borislav Petkov <bp@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Masahiro Yamada <masahiroy@kernel.org>,
Arvind Sankar <nivedita@alum.mit.edu>,
Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, clang-built-linux@googlegroups.com,
linux-arch@vger.kernel.org, linux-efi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property
Date: Tue, 23 Jun 2020 18:49:34 -0700 [thread overview]
Message-ID: <20200624014940.1204448-4-keescook@chromium.org> (raw)
In-Reply-To: <20200624014940.1204448-1-keescook@chromium.org>
In preparation for adding --orphan-handling=warn to more architectures,
make sure unwanted sections don't end up appearing under the .init
section prefix that libstub adds to itself during objcopy.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/firmware/efi/libstub/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
index 75daaf20374e..9d2d2e784bca 100644
--- a/drivers/firmware/efi/libstub/Makefile
+++ b/drivers/firmware/efi/libstub/Makefile
@@ -66,6 +66,9 @@ lib-$(CONFIG_X86) += x86-stub.o
CFLAGS_arm32-stub.o := -DTEXT_OFFSET=$(TEXT_OFFSET)
CFLAGS_arm64-stub.o := -DTEXT_OFFSET=$(TEXT_OFFSET)
+# Remove unwanted sections first.
+STUBCOPY_FLAGS-y += --remove-section=.note.gnu.property
+
#
# For x86, bootloaders like systemd-boot or grub-efi do not zero-initialize the
# .bss section, so the .bss section of the EFI stub needs to be included in the
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-arch@vger.kernel.org, linux-efi@vger.kernel.org,
Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Masahiro Yamada <masahiroy@kernel.org>,
x86@kernel.org, Nick Desaulniers <ndesaulniers@google.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org,
Nathan Chancellor <natechancellor@gmail.com>,
clang-built-linux@googlegroups.com,
Arvind Sankar <nivedita@alum.mit.edu>,
Ingo Molnar <mingo@redhat.com>, James Morse <james.morse@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@suse.de>,
Peter Collingbourne <pcc@google.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property
Date: Tue, 23 Jun 2020 18:49:34 -0700 [thread overview]
Message-ID: <20200624014940.1204448-4-keescook@chromium.org> (raw)
In-Reply-To: <20200624014940.1204448-1-keescook@chromium.org>
In preparation for adding --orphan-handling=warn to more architectures,
make sure unwanted sections don't end up appearing under the .init
section prefix that libstub adds to itself during objcopy.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/firmware/efi/libstub/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
index 75daaf20374e..9d2d2e784bca 100644
--- a/drivers/firmware/efi/libstub/Makefile
+++ b/drivers/firmware/efi/libstub/Makefile
@@ -66,6 +66,9 @@ lib-$(CONFIG_X86) += x86-stub.o
CFLAGS_arm32-stub.o := -DTEXT_OFFSET=$(TEXT_OFFSET)
CFLAGS_arm64-stub.o := -DTEXT_OFFSET=$(TEXT_OFFSET)
+# Remove unwanted sections first.
+STUBCOPY_FLAGS-y += --remove-section=.note.gnu.property
+
#
# For x86, bootloaders like systemd-boot or grub-efi do not zero-initialize the
# .bss section, so the .bss section of the EFI stub needs to be included in the
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-24 1:49 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 1:49 [PATCH v3 0/9] Warn on orphan section placement Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 1/9] vmlinux.lds.h: Add .gnu.version* to DISCARDS Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 15:39 ` Arvind Sankar
2020-06-24 15:39 ` Arvind Sankar
2020-06-24 15:39 ` Arvind Sankar
2020-06-24 16:16 ` Fangrui Song
2020-06-24 16:16 ` Fangrui Song
2020-06-24 17:11 ` Arvind Sankar
2020-06-24 17:11 ` Arvind Sankar
2020-06-24 17:11 ` Arvind Sankar
2020-06-24 17:26 ` Fangrui Song
2020-06-24 17:26 ` Fangrui Song
2020-06-24 17:35 ` Arvind Sankar
2020-06-24 17:35 ` Arvind Sankar
2020-06-24 17:35 ` Arvind Sankar
2020-06-24 1:49 ` Kees Cook [this message]
2020-06-24 1:49 ` [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property Kees Cook
2020-06-24 3:31 ` Fangrui Song
2020-06-24 3:31 ` Fangrui Song
2020-06-24 4:44 ` Kees Cook
2020-06-24 4:44 ` Kees Cook
2020-06-24 10:43 ` Will Deacon
2020-06-24 10:43 ` Will Deacon
2020-06-24 10:46 ` Ard Biesheuvel
2020-06-24 10:46 ` Ard Biesheuvel
2020-06-24 10:46 ` Ard Biesheuvel
2020-06-24 11:26 ` Will Deacon
2020-06-24 11:26 ` Will Deacon
2020-06-24 11:26 ` Will Deacon
2020-06-24 13:48 ` Dave Martin
2020-06-24 13:48 ` Dave Martin
2020-06-24 13:48 ` Dave Martin
2020-06-24 15:26 ` Will Deacon
2020-06-24 15:26 ` Will Deacon
2020-06-24 15:26 ` Will Deacon
2020-06-24 16:26 ` Dave Martin
2020-06-24 16:26 ` Dave Martin
2020-06-24 16:26 ` Dave Martin
2020-06-24 15:21 ` Kees Cook
2020-06-24 15:21 ` Kees Cook
2020-06-24 15:21 ` Kees Cook
2020-06-24 15:31 ` Ard Biesheuvel
2020-06-24 15:31 ` Ard Biesheuvel
2020-06-24 15:31 ` Ard Biesheuvel
2020-06-24 15:45 ` Kees Cook
2020-06-24 15:45 ` Kees Cook
2020-06-24 15:45 ` Kees Cook
2020-06-24 15:48 ` Ard Biesheuvel
2020-06-24 15:48 ` Ard Biesheuvel
2020-06-24 15:48 ` Ard Biesheuvel
2020-06-24 16:29 ` Dave Martin
2020-06-24 16:29 ` Dave Martin
2020-06-24 16:29 ` Dave Martin
2020-06-24 16:40 ` Ard Biesheuvel
2020-06-24 16:40 ` Ard Biesheuvel
2020-06-24 16:40 ` Ard Biesheuvel
2020-06-24 17:16 ` Dave Martin
2020-06-24 17:16 ` Dave Martin
2020-06-24 17:16 ` Dave Martin
2020-06-24 18:23 ` Ard Biesheuvel
2020-06-24 18:23 ` Ard Biesheuvel
2020-06-24 18:23 ` Ard Biesheuvel
2020-06-24 18:57 ` Ard Biesheuvel
2020-06-24 18:57 ` Ard Biesheuvel
2020-06-24 18:57 ` Ard Biesheuvel
2020-06-24 1:49 ` [PATCH v3 4/9] x86/build: Warn on orphan section placement Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 18:36 ` kernel test robot
2020-06-27 15:44 ` Kees Cook
2020-06-27 15:44 ` Kees Cook
2020-06-29 14:54 ` Marco Elver
2020-06-29 14:54 ` Marco Elver
2020-06-29 15:26 ` Kees Cook
2020-06-29 15:26 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 5/9] x86/boot: " Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 6/9] arm/build: " Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 7/9] arm/boot: " Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 8/9] arm64/build: Use common DISCARDS in linker script Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 1:49 ` [PATCH v3 9/9] arm64/build: Warn on orphan section placement Kees Cook
2020-06-24 1:49 ` Kees Cook
2020-06-24 7:57 ` Will Deacon
2020-06-24 7:57 ` Will Deacon
2020-06-24 15:36 ` Kees Cook
2020-06-24 15:36 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624014940.1204448-4-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=james.morse@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=pcc@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.