All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gurchetan Singh <gurchetansingh@chromium.org>
To: dri-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org
Cc: sebastien.boeuf@intel.com, kraxel@redhat.com, vgoyal@redhat.com,
	mst@redhat.com
Subject: [PATCH 19/24] drm/virtio: implement blob resources: blob display integration
Date: Thu, 13 Aug 2020 19:39:55 -0700	[thread overview]
Message-ID: <20200814024000.2485-20-gurchetansingh@chromium.org> (raw)
In-Reply-To: <20200814024000.2485-1-gurchetansingh@chromium.org>

SCANOUT_BLOB forwards the DRM framebuffer metadata to the host. The
modifier is intentionally left out -- it may be possible to query
the host for that.

We also assume one blob resource per DRM framebuffer.  That too is
an intentional simplification.

Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
Acked-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
 drivers/gpu/drm/virtio/virtgpu_plane.c | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
index 52d24179bcec..1e0754e77723 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -172,12 +172,23 @@ static void virtio_gpu_primary_plane_update(struct drm_plane *plane,
 			  plane->state->src_h >> 16,
 			  plane->state->src_x >> 16,
 			  plane->state->src_y >> 16);
-		virtio_gpu_cmd_set_scanout(vgdev, output->index,
-					   bo->hw_res_handle,
-					   plane->state->src_w >> 16,
-					   plane->state->src_h >> 16,
-					   plane->state->src_x >> 16,
-					   plane->state->src_y >> 16);
+
+		if (bo->host3d_blob || bo->guest_blob) {
+			virtio_gpu_cmd_set_scanout_blob(
+						vgdev, output->index, bo,
+						plane->state->fb,
+						plane->state->src_w >> 16,
+						plane->state->src_h >> 16,
+						plane->state->src_x >> 16,
+						plane->state->src_y >> 16);
+		} else {
+			virtio_gpu_cmd_set_scanout(vgdev, output->index,
+						   bo->hw_res_handle,
+						   plane->state->src_w >> 16,
+						   plane->state->src_h >> 16,
+						   plane->state->src_x >> 16,
+						   plane->state->src_y >> 16);
+		}
 	}
 
 	virtio_gpu_cmd_resource_flush(vgdev, bo->hw_res_handle,
-- 
2.24.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Gurchetan Singh <gurchetansingh@chromium.org>
To: dri-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org
Cc: kraxel@redhat.com, mst@redhat.com, vgoyal@redhat.com,
	sebastien.boeuf@intel.com
Subject: [virtio-dev] [PATCH 19/24] drm/virtio: implement blob resources: blob display integration
Date: Thu, 13 Aug 2020 19:39:55 -0700	[thread overview]
Message-ID: <20200814024000.2485-20-gurchetansingh@chromium.org> (raw)
In-Reply-To: <20200814024000.2485-1-gurchetansingh@chromium.org>

SCANOUT_BLOB forwards the DRM framebuffer metadata to the host. The
modifier is intentionally left out -- it may be possible to query
the host for that.

We also assume one blob resource per DRM framebuffer.  That too is
an intentional simplification.

Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
Acked-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
 drivers/gpu/drm/virtio/virtgpu_plane.c | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
index 52d24179bcec..1e0754e77723 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -172,12 +172,23 @@ static void virtio_gpu_primary_plane_update(struct drm_plane *plane,
 			  plane->state->src_h >> 16,
 			  plane->state->src_x >> 16,
 			  plane->state->src_y >> 16);
-		virtio_gpu_cmd_set_scanout(vgdev, output->index,
-					   bo->hw_res_handle,
-					   plane->state->src_w >> 16,
-					   plane->state->src_h >> 16,
-					   plane->state->src_x >> 16,
-					   plane->state->src_y >> 16);
+
+		if (bo->host3d_blob || bo->guest_blob) {
+			virtio_gpu_cmd_set_scanout_blob(
+						vgdev, output->index, bo,
+						plane->state->fb,
+						plane->state->src_w >> 16,
+						plane->state->src_h >> 16,
+						plane->state->src_x >> 16,
+						plane->state->src_y >> 16);
+		} else {
+			virtio_gpu_cmd_set_scanout(vgdev, output->index,
+						   bo->hw_res_handle,
+						   plane->state->src_w >> 16,
+						   plane->state->src_h >> 16,
+						   plane->state->src_x >> 16,
+						   plane->state->src_y >> 16);
+		}
 	}
 
 	virtio_gpu_cmd_resource_flush(vgdev, bo->hw_res_handle,
-- 
2.24.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2020-08-14  2:40 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14  2:39 [PATCH 00/24] Blob prerequisites + blob resources Gurchetan Singh
2020-08-14  2:39 ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 01/24] drm/virtio: Revert "drm/virtio: Call the right shmem helpers" Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 02/24] virtio: add dma-buf support for exported objects Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 03/24] virtio-gpu: add VIRTIO_GPU_F_RESOURCE_UUID feature Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 04/24] drm/virtio: Support virtgpu exported resources Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 05/24] virtio: Add get_shm_region method Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 06/24] virtio: Implement get_shm_region for PCI transport Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 07/24] virtio: Implement get_shm_region for MMIO transport Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 08/24] drm/virtio: blob prep: refactor getting pages and attaching backing Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 09/24] drm/virtio: blob prep: make CPU responses more generic Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 10/24] virtio-gpu api: blob resources Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 11/24] virtio-gpu api: host visible feature Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 12/24] virtio-gpu api: cross-device feature Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 13/24] drm/virtio: implement blob resources: probe for the feature Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 14/24] drm/virtio: implement blob resources: probe for host visible region Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-16 13:10   ` kernel test robot
2020-08-16 13:10     ` kernel test robot
2020-08-14  2:39 ` [PATCH 15/24] drm/virtio: implement blob resources: expose virtio_gpu_resource_id_get Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 16/24] drm/virtio: implement blob resources: add new fields to internal structs Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 17/24] drm/virtio: implement blob resources: implement vram object Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  5:39   ` kernel test robot
2020-08-14  5:39     ` kernel test robot
2020-08-14  2:39 ` [PATCH 18/24] drm/virtio: implement blob resources: hypercall interface Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  6:12   ` kernel test robot
2020-08-14  6:12     ` kernel test robot
2020-08-14  2:39 ` Gurchetan Singh [this message]
2020-08-14  2:39   ` [virtio-dev] [PATCH 19/24] drm/virtio: implement blob resources: blob display integration Gurchetan Singh
2020-08-14  2:39 ` [PATCH 20/24] drm/virtio: implement blob resources: refactor UUID code somewhat Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 21/24] drm/virtio: implement blob resources: fix stride discrepancy Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 22/24] drm/virtio: implement blob resources: report blob mem to userspace Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-14  2:39 ` [PATCH 23/24] drm/virtio: implement blob resources: resource create blob ioctl Gurchetan Singh
2020-08-14  2:39   ` [virtio-dev] " Gurchetan Singh
2020-08-17 17:46   ` Anthoine Bourgeois
2020-08-14  2:40 ` [PATCH 24/24] drm/virtio: advertise features to userspace Gurchetan Singh
2020-08-14  2:40   ` [virtio-dev] " Gurchetan Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200814024000.2485-20-gurchetansingh@chromium.org \
    --to=gurchetansingh@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=sebastien.boeuf@intel.com \
    --cc=vgoyal@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.