From: Karthik B S <karthik.b.s@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: paulo.r.zanoni@intel.com, michel@daenzer.net,
Karthik B S <karthik.b.s@intel.com>,
dri-devel@lists.freedesktop.org, vandita.kulkarni@intel.com,
uma.shankar@intel.com, daniel.vetter@intel.com,
nicholas.kazlauskas@amd.com
Subject: [PATCH v8 0/8] Asynchronous flip implementation for i915
Date: Mon, 14 Sep 2020 11:26:25 +0530 [thread overview]
Message-ID: <20200914055633.21109-1-karthik.b.s@intel.com> (raw)
Without async flip support in the kernel, fullscreen apps where game
resolution is equal to the screen resolution, must perform an extra blit
per frame prior to flipping.
Asynchronous page flips will also boost the FPS of Mesa benchmarks.
v2: -Few patches have been squashed and patches have been shuffled as
per the reviews on the previous version.
v3: -Few patches have been squashed and patches have been shuffled as
per the reviews on the previous version.
v4: -Made changes to fix the sequence and time stamp issue as per the
comments received on the previous version.
-Timestamps are calculated using the flip done time stamp and current
timestamp. Here I915_MODE_FLAG_GET_SCANLINE_FROM_TIMESTAMP flag is used
for timestamp calculations.
-Event is sent from the interrupt handler immediately using this
updated timestamps and sequence.
-Added more state checks as async flip should only allow change in plane
surface address and nothing else should be allowed to change.
-Added a separate plane hook for async flip.
-Need to find a way to reject fbc enabling if it comes as part of this
flip as bspec states that changes to FBC are not allowed.
v5: -Fixed the Checkpatch and sparse warnings.
v6: -Reverted back to the old timestamping code as per the feedback received.
-Added documentation.
v7: -Changes in intel_atomic_check_async()
-Add vfunc for skl_program_async_surface_address()
v8: -Add WA for older platforms with double buffered
async address update enable bit.
Test-with: <20200908061001.20302-1-karthik.b.s@intel.com>
Karthik B S (8):
drm/i915: Add enable/disable flip done and flip done handler
drm/i915: Add support for async flips in I915
drm/i915: Add checks specific to async flips
drm/i915: Do not call drm_crtc_arm_vblank_event in async flips
drm/i915: Add dedicated plane hook for async flip case
drm/i915: WA for platforms with double buffered adress update enable
bit
Documentation/gpu: Add asynchronous flip documentation for i915
drm/i915: Enable async flips in i915
Documentation/gpu/i915.rst | 6 +
.../gpu/drm/i915/display/intel_atomic_plane.c | 7 +
drivers/gpu/drm/i915/display/intel_display.c | 201 ++++++++++++++++++
.../drm/i915/display/intel_display_types.h | 3 +
drivers/gpu/drm/i915/display/intel_sprite.c | 30 +++
drivers/gpu/drm/i915/i915_irq.c | 52 +++++
drivers/gpu/drm/i915/i915_irq.h | 2 +
drivers/gpu/drm/i915/i915_reg.h | 1 +
8 files changed, 302 insertions(+)
--
2.22.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Karthik B S <karthik.b.s@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: paulo.r.zanoni@intel.com, michel@daenzer.net,
dri-devel@lists.freedesktop.org, daniel.vetter@intel.com,
harry.wentland@amd.com, nicholas.kazlauskas@amd.com
Subject: [Intel-gfx] [PATCH v8 0/8] Asynchronous flip implementation for i915
Date: Mon, 14 Sep 2020 11:26:25 +0530 [thread overview]
Message-ID: <20200914055633.21109-1-karthik.b.s@intel.com> (raw)
Without async flip support in the kernel, fullscreen apps where game
resolution is equal to the screen resolution, must perform an extra blit
per frame prior to flipping.
Asynchronous page flips will also boost the FPS of Mesa benchmarks.
v2: -Few patches have been squashed and patches have been shuffled as
per the reviews on the previous version.
v3: -Few patches have been squashed and patches have been shuffled as
per the reviews on the previous version.
v4: -Made changes to fix the sequence and time stamp issue as per the
comments received on the previous version.
-Timestamps are calculated using the flip done time stamp and current
timestamp. Here I915_MODE_FLAG_GET_SCANLINE_FROM_TIMESTAMP flag is used
for timestamp calculations.
-Event is sent from the interrupt handler immediately using this
updated timestamps and sequence.
-Added more state checks as async flip should only allow change in plane
surface address and nothing else should be allowed to change.
-Added a separate plane hook for async flip.
-Need to find a way to reject fbc enabling if it comes as part of this
flip as bspec states that changes to FBC are not allowed.
v5: -Fixed the Checkpatch and sparse warnings.
v6: -Reverted back to the old timestamping code as per the feedback received.
-Added documentation.
v7: -Changes in intel_atomic_check_async()
-Add vfunc for skl_program_async_surface_address()
v8: -Add WA for older platforms with double buffered
async address update enable bit.
Test-with: <20200908061001.20302-1-karthik.b.s@intel.com>
Karthik B S (8):
drm/i915: Add enable/disable flip done and flip done handler
drm/i915: Add support for async flips in I915
drm/i915: Add checks specific to async flips
drm/i915: Do not call drm_crtc_arm_vblank_event in async flips
drm/i915: Add dedicated plane hook for async flip case
drm/i915: WA for platforms with double buffered adress update enable
bit
Documentation/gpu: Add asynchronous flip documentation for i915
drm/i915: Enable async flips in i915
Documentation/gpu/i915.rst | 6 +
.../gpu/drm/i915/display/intel_atomic_plane.c | 7 +
drivers/gpu/drm/i915/display/intel_display.c | 201 ++++++++++++++++++
.../drm/i915/display/intel_display_types.h | 3 +
drivers/gpu/drm/i915/display/intel_sprite.c | 30 +++
drivers/gpu/drm/i915/i915_irq.c | 52 +++++
drivers/gpu/drm/i915/i915_irq.h | 2 +
drivers/gpu/drm/i915/i915_reg.h | 1 +
8 files changed, 302 insertions(+)
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2020-09-14 6:22 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 5:56 Karthik B S [this message]
2020-09-14 5:56 ` [Intel-gfx] [PATCH v8 0/8] Asynchronous flip implementation for i915 Karthik B S
2020-09-14 5:56 ` [PATCH v8 1/8] drm/i915: Add enable/disable flip done and flip done handler Karthik B S
2020-09-14 5:56 ` [Intel-gfx] " Karthik B S
2020-09-15 13:47 ` Ville Syrjälä
2020-09-15 13:47 ` [Intel-gfx] " Ville Syrjälä
2020-09-16 12:36 ` Karthik B S
2020-09-16 12:36 ` [Intel-gfx] " Karthik B S
2020-09-14 5:56 ` [PATCH v8 2/8] drm/i915: Add support for async flips in I915 Karthik B S
2020-09-14 5:56 ` [Intel-gfx] " Karthik B S
2020-09-15 13:48 ` Ville Syrjälä
2020-09-15 13:48 ` [Intel-gfx] " Ville Syrjälä
2020-09-16 12:38 ` Karthik B S
2020-09-16 12:38 ` [Intel-gfx] " Karthik B S
2020-09-14 5:56 ` [PATCH v8 3/8] drm/i915: Add checks specific to async flips Karthik B S
2020-09-14 5:56 ` [Intel-gfx] " Karthik B S
2020-09-15 14:03 ` Ville Syrjälä
2020-09-15 14:03 ` [Intel-gfx] " Ville Syrjälä
2020-09-16 12:44 ` Karthik B S
2020-09-16 12:44 ` [Intel-gfx] " Karthik B S
2020-09-14 5:56 ` [PATCH v8 4/8] drm/i915: Do not call drm_crtc_arm_vblank_event in " Karthik B S
2020-09-14 5:56 ` [Intel-gfx] " Karthik B S
2020-09-15 14:07 ` Ville Syrjälä
2020-09-15 14:07 ` [Intel-gfx] " Ville Syrjälä
2020-09-16 12:46 ` Karthik B S
2020-09-16 12:46 ` [Intel-gfx] " Karthik B S
2020-09-14 5:56 ` [PATCH v8 5/8] drm/i915: Add dedicated plane hook for async flip case Karthik B S
2020-09-14 5:56 ` [Intel-gfx] " Karthik B S
2020-09-15 14:10 ` Ville Syrjälä
2020-09-15 14:10 ` [Intel-gfx] " Ville Syrjälä
2020-09-16 12:48 ` Karthik B S
2020-09-16 12:48 ` [Intel-gfx] " Karthik B S
2020-09-15 14:41 ` Ville Syrjälä
2020-09-15 14:41 ` [Intel-gfx] " Ville Syrjälä
2020-09-16 13:00 ` Karthik B S
2020-09-16 13:00 ` [Intel-gfx] " Karthik B S
2020-09-16 15:52 ` Karthik B S
2020-09-16 15:52 ` [Intel-gfx] " Karthik B S
2020-09-14 5:56 ` [PATCH v8 6/8] drm/i915: WA for platforms with double buffered adress update enable bit Karthik B S
2020-09-14 5:56 ` [Intel-gfx] " Karthik B S
2020-09-15 14:19 ` Ville Syrjälä
2020-09-15 14:19 ` [Intel-gfx] " Ville Syrjälä
2020-09-16 12:54 ` Karthik B S
2020-09-16 12:54 ` [Intel-gfx] " Karthik B S
2020-09-14 5:56 ` [PATCH v8 7/8] Documentation/gpu: Add asynchronous flip documentation for i915 Karthik B S
2020-09-14 5:56 ` [Intel-gfx] " Karthik B S
2020-09-14 5:56 ` [PATCH v8 8/8] drm/i915: Enable async flips in i915 Karthik B S
2020-09-14 5:56 ` [Intel-gfx] " Karthik B S
2020-09-14 11:22 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Asynchronous flip implementation for i915 (rev8) Patchwork
2020-09-14 11:23 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-09-14 11:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-14 13:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914055633.21109-1-karthik.b.s@intel.com \
--to=karthik.b.s@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel@daenzer.net \
--cc=nicholas.kazlauskas@amd.com \
--cc=paulo.r.zanoni@intel.com \
--cc=uma.shankar@intel.com \
--cc=vandita.kulkarni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.