All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
To: <linux-arm-kernel@lists.infradead.org>,
	<linux-acpi@vger.kernel.org>, <iommu@lists.linux-foundation.org>,
	<devel@acpica.org>
Cc: <linuxarm@huawei.com>, <lorenzo.pieralisi@arm.com>,
	<joro@8bytes.org>, <robin.murphy@arm.com>,
	<wanghuiqiang@huawei.com>, <guohanjun@huawei.com>,
	<jonathan.cameron@huawei.com>, <steven.price@arm.com>,
	<Sami.Mujawar@arm.com>
Subject: [RFC PATCH v2 5/8] iommu/arm-smmu-v3: Introduce strtab init helper
Date: Thu, 19 Nov 2020 12:11:47 +0000	[thread overview]
Message-ID: <20201119121150.3316-6-shameerali.kolothum.thodi@huawei.com> (raw)
In-Reply-To: <20201119121150.3316-1-shameerali.kolothum.thodi@huawei.com>

Introduce a helper to check the sid range and to init the l2 strtab
entries(bypass). This will be useful when we have to initialize the
l2 strtab for RMR SIDs.

Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 26 ++++++++++++---------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
index e634bbe60573..1953b317d814 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -2308,6 +2308,19 @@ static bool arm_smmu_sid_in_range(struct arm_smmu_device *smmu, u32 sid)
 
 static struct iommu_ops arm_smmu_ops;
 
+static int arm_smmu_init_sid_strtab(struct arm_smmu_device *smmu, u32 sid)
+{
+	/* Check the SIDs are in range of the SMMU and our stream table */
+	if (!arm_smmu_sid_in_range(smmu, sid))
+		return -ERANGE;
+
+	/* Ensure l2 strtab is initialised */
+	if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB)
+		return arm_smmu_init_l2_strtab(smmu, sid);
+
+	return 0;
+}
+
 static struct iommu_device *arm_smmu_probe_device(struct device *dev)
 {
 	int i, ret;
@@ -2336,21 +2349,12 @@ static struct iommu_device *arm_smmu_probe_device(struct device *dev)
 	INIT_LIST_HEAD(&master->bonds);
 	dev_iommu_priv_set(dev, master);
 
-	/* Check the SIDs are in range of the SMMU and our stream table */
 	for (i = 0; i < master->num_sids; i++) {
 		u32 sid = master->sids[i];
 
-		if (!arm_smmu_sid_in_range(smmu, sid)) {
-			ret = -ERANGE;
+		ret = arm_smmu_init_sid_strtab(smmu, sid);
+		if (ret)
 			goto err_free_master;
-		}
-
-		/* Ensure l2 strtab is initialised */
-		if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB) {
-			ret = arm_smmu_init_l2_strtab(smmu, sid);
-			if (ret)
-				goto err_free_master;
-		}
 	}
 
 	master->ssid_bits = min(smmu->ssid_bits, fwspec->num_pasid_bits);
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
To: <linux-arm-kernel@lists.infradead.org>,
	<linux-acpi@vger.kernel.org>, <iommu@lists.linux-foundation.org>,
	<devel@acpica.org>
Cc: linuxarm@huawei.com, steven.price@arm.com, guohanjun@huawei.com,
	Sami.Mujawar@arm.com, robin.murphy@arm.com,
	wanghuiqiang@huawei.com
Subject: [RFC PATCH v2 5/8] iommu/arm-smmu-v3: Introduce strtab init helper
Date: Thu, 19 Nov 2020 12:11:47 +0000	[thread overview]
Message-ID: <20201119121150.3316-6-shameerali.kolothum.thodi@huawei.com> (raw)
In-Reply-To: <20201119121150.3316-1-shameerali.kolothum.thodi@huawei.com>

Introduce a helper to check the sid range and to init the l2 strtab
entries(bypass). This will be useful when we have to initialize the
l2 strtab for RMR SIDs.

Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 26 ++++++++++++---------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
index e634bbe60573..1953b317d814 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -2308,6 +2308,19 @@ static bool arm_smmu_sid_in_range(struct arm_smmu_device *smmu, u32 sid)
 
 static struct iommu_ops arm_smmu_ops;
 
+static int arm_smmu_init_sid_strtab(struct arm_smmu_device *smmu, u32 sid)
+{
+	/* Check the SIDs are in range of the SMMU and our stream table */
+	if (!arm_smmu_sid_in_range(smmu, sid))
+		return -ERANGE;
+
+	/* Ensure l2 strtab is initialised */
+	if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB)
+		return arm_smmu_init_l2_strtab(smmu, sid);
+
+	return 0;
+}
+
 static struct iommu_device *arm_smmu_probe_device(struct device *dev)
 {
 	int i, ret;
@@ -2336,21 +2349,12 @@ static struct iommu_device *arm_smmu_probe_device(struct device *dev)
 	INIT_LIST_HEAD(&master->bonds);
 	dev_iommu_priv_set(dev, master);
 
-	/* Check the SIDs are in range of the SMMU and our stream table */
 	for (i = 0; i < master->num_sids; i++) {
 		u32 sid = master->sids[i];
 
-		if (!arm_smmu_sid_in_range(smmu, sid)) {
-			ret = -ERANGE;
+		ret = arm_smmu_init_sid_strtab(smmu, sid);
+		if (ret)
 			goto err_free_master;
-		}
-
-		/* Ensure l2 strtab is initialised */
-		if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB) {
-			ret = arm_smmu_init_l2_strtab(smmu, sid);
-			if (ret)
-				goto err_free_master;
-		}
 	}
 
 	master->ssid_bits = min(smmu->ssid_bits, fwspec->num_pasid_bits);
-- 
2.17.1

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
To: <linux-arm-kernel@lists.infradead.org>,
	<linux-acpi@vger.kernel.org>, <iommu@lists.linux-foundation.org>,
	<devel@acpica.org>
Cc: lorenzo.pieralisi@arm.com, joro@8bytes.org,
	jonathan.cameron@huawei.com, linuxarm@huawei.com,
	steven.price@arm.com, guohanjun@huawei.com, Sami.Mujawar@arm.com,
	robin.murphy@arm.com, wanghuiqiang@huawei.com
Subject: [RFC PATCH v2 5/8] iommu/arm-smmu-v3: Introduce strtab init helper
Date: Thu, 19 Nov 2020 12:11:47 +0000	[thread overview]
Message-ID: <20201119121150.3316-6-shameerali.kolothum.thodi@huawei.com> (raw)
In-Reply-To: <20201119121150.3316-1-shameerali.kolothum.thodi@huawei.com>

Introduce a helper to check the sid range and to init the l2 strtab
entries(bypass). This will be useful when we have to initialize the
l2 strtab for RMR SIDs.

Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 26 ++++++++++++---------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
index e634bbe60573..1953b317d814 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -2308,6 +2308,19 @@ static bool arm_smmu_sid_in_range(struct arm_smmu_device *smmu, u32 sid)
 
 static struct iommu_ops arm_smmu_ops;
 
+static int arm_smmu_init_sid_strtab(struct arm_smmu_device *smmu, u32 sid)
+{
+	/* Check the SIDs are in range of the SMMU and our stream table */
+	if (!arm_smmu_sid_in_range(smmu, sid))
+		return -ERANGE;
+
+	/* Ensure l2 strtab is initialised */
+	if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB)
+		return arm_smmu_init_l2_strtab(smmu, sid);
+
+	return 0;
+}
+
 static struct iommu_device *arm_smmu_probe_device(struct device *dev)
 {
 	int i, ret;
@@ -2336,21 +2349,12 @@ static struct iommu_device *arm_smmu_probe_device(struct device *dev)
 	INIT_LIST_HEAD(&master->bonds);
 	dev_iommu_priv_set(dev, master);
 
-	/* Check the SIDs are in range of the SMMU and our stream table */
 	for (i = 0; i < master->num_sids; i++) {
 		u32 sid = master->sids[i];
 
-		if (!arm_smmu_sid_in_range(smmu, sid)) {
-			ret = -ERANGE;
+		ret = arm_smmu_init_sid_strtab(smmu, sid);
+		if (ret)
 			goto err_free_master;
-		}
-
-		/* Ensure l2 strtab is initialised */
-		if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB) {
-			ret = arm_smmu_init_l2_strtab(smmu, sid);
-			if (ret)
-				goto err_free_master;
-		}
 	}
 
 	master->ssid_bits = min(smmu->ssid_bits, fwspec->num_pasid_bits);
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shameer Kolothum <shameerali.kolothum.thodi at huawei.com>
To: devel@acpica.org
Subject: [Devel] [RFC PATCH v2 5/8] iommu/arm-smmu-v3: Introduce strtab init helper
Date: Thu, 19 Nov 2020 12:11:47 +0000	[thread overview]
Message-ID: <20201119121150.3316-6-shameerali.kolothum.thodi@huawei.com> (raw)
In-Reply-To: 20201119121150.3316-1-shameerali.kolothum.thodi@huawei.com

[-- Attachment #1: Type: text/plain, Size: 1991 bytes --]

Introduce a helper to check the sid range and to init the l2 strtab
entries(bypass). This will be useful when we have to initialize the
l2 strtab for RMR SIDs.

Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi(a)huawei.com>
---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 26 ++++++++++++---------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
index e634bbe60573..1953b317d814 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -2308,6 +2308,19 @@ static bool arm_smmu_sid_in_range(struct arm_smmu_device *smmu, u32 sid)
 
 static struct iommu_ops arm_smmu_ops;
 
+static int arm_smmu_init_sid_strtab(struct arm_smmu_device *smmu, u32 sid)
+{
+	/* Check the SIDs are in range of the SMMU and our stream table */
+	if (!arm_smmu_sid_in_range(smmu, sid))
+		return -ERANGE;
+
+	/* Ensure l2 strtab is initialised */
+	if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB)
+		return arm_smmu_init_l2_strtab(smmu, sid);
+
+	return 0;
+}
+
 static struct iommu_device *arm_smmu_probe_device(struct device *dev)
 {
 	int i, ret;
@@ -2336,21 +2349,12 @@ static struct iommu_device *arm_smmu_probe_device(struct device *dev)
 	INIT_LIST_HEAD(&master->bonds);
 	dev_iommu_priv_set(dev, master);
 
-	/* Check the SIDs are in range of the SMMU and our stream table */
 	for (i = 0; i < master->num_sids; i++) {
 		u32 sid = master->sids[i];
 
-		if (!arm_smmu_sid_in_range(smmu, sid)) {
-			ret = -ERANGE;
+		ret = arm_smmu_init_sid_strtab(smmu, sid);
+		if (ret)
 			goto err_free_master;
-		}
-
-		/* Ensure l2 strtab is initialised */
-		if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB) {
-			ret = arm_smmu_init_l2_strtab(smmu, sid);
-			if (ret)
-				goto err_free_master;
-		}
 	}
 
 	master->ssid_bits = min(smmu->ssid_bits, fwspec->num_pasid_bits);
-- 
2.17.1

  parent reply	other threads:[~2020-11-19 12:12 UTC|newest]

Thread overview: 123+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 12:11 [RFC PATCH v2 0/8] ACPI/IORT: Support for IORT RMR node Shameer Kolothum
2020-11-19 12:11 ` [Devel] " Shameer Kolothum
2020-11-19 12:11 ` Shameer Kolothum
2020-11-19 12:11 ` Shameer Kolothum
2020-11-19 12:11 ` [RFC PATCH v2 1/8] ACPICA: IORT: Update for revision E Shameer Kolothum
2020-11-19 12:11   ` [Devel] " Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2021-03-22 10:36   ` Shameerali Kolothum Thodi
2021-03-22 10:36     ` [Devel] " Shameerali Kolothum Thodi
2021-03-22 10:36     ` Shameerali Kolothum Thodi
2021-03-22 10:36     ` Shameerali Kolothum Thodi
2021-03-22 21:57     ` Kaneda, Erik
2021-03-22 21:57       ` Kaneda, Erik
2021-03-22 21:57       ` Kaneda, Erik
2021-03-23 15:53       ` Lorenzo Pieralisi
2021-03-23 15:53         ` [Devel] " Lorenzo Pieralisi
2021-03-23 15:53         ` Lorenzo Pieralisi
2021-03-23 15:53         ` Lorenzo Pieralisi
2021-03-23 18:51         ` Kaneda, Erik
2021-03-23 18:51           ` Kaneda, Erik
2021-03-23 18:51           ` Kaneda, Erik
2021-03-24  9:50           ` Lorenzo Pieralisi
2021-03-24  9:50             ` [Devel] " Lorenzo Pieralisi
2021-03-24  9:50             ` Lorenzo Pieralisi
2021-03-24  9:50             ` Lorenzo Pieralisi
2021-03-25  8:40     ` Jon Nettleton
2021-03-25  8:40       ` Jon Nettleton
2021-03-25  8:40       ` Jon Nettleton
2021-03-25 15:54       ` Shameerali Kolothum Thodi
2021-03-25 15:54         ` [Devel] " Shameerali Kolothum Thodi
2021-03-25 15:54         ` Shameerali Kolothum Thodi
2021-03-25 15:54         ` Shameerali Kolothum Thodi
2021-04-15  7:27   ` Auger Eric
2021-04-15  7:27     ` Auger Eric
2021-04-15  7:27     ` Auger Eric
2020-11-19 12:11 ` [RFC PATCH v2 2/8] ACPI/IORT: Add support for RMR node parsing Shameer Kolothum
2020-11-19 12:11   ` [Devel] " Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2021-04-15  9:39   ` Auger Eric
2021-04-15  9:39     ` Auger Eric
2021-04-15  9:39     ` Auger Eric
2021-04-15 10:30     ` Shameerali Kolothum Thodi
2021-04-15 10:30       ` [Devel] " Shameerali Kolothum Thodi
2021-04-15 10:30       ` Shameerali Kolothum Thodi
2021-04-15 10:30       ` Shameerali Kolothum Thodi
2020-11-19 12:11 ` [RFC PATCH v2 3/8] iommu/dma: Introduce generic helper to retrieve RMR info Shameer Kolothum
2020-11-19 12:11   ` [Devel] " Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11 ` [RFC PATCH v2 4/8] ACPI/IORT: Add RMR memory regions reservation helper Shameer Kolothum
2020-11-19 12:11   ` [Devel] " Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11 ` Shameer Kolothum [this message]
2020-11-19 12:11   ` [Devel] [RFC PATCH v2 5/8] iommu/arm-smmu-v3: Introduce strtab init helper Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11 ` [RFC PATCH v2 6/8] iommu/arm-smmu-v3: Add bypass flag to arm_smmu_write_strtab_ent() Shameer Kolothum
2020-11-19 12:11   ` [Devel] " Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11 ` [RFC PATCH v2 7/8] iommu/arm-smmu-v3: Get associated RMR info and install bypass STE Shameer Kolothum
2020-11-19 12:11   ` [Devel] " Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11 ` [RFC PATCH v2 8/8] iommu/arm-smmu-v3: Reserve any RMR regions associated with a dev Shameer Kolothum
2020-11-19 12:11   ` [Devel] " Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-11-19 12:11   ` Shameer Kolothum
2020-12-10 10:25 ` [RFC PATCH v2 0/8] ACPI/IORT: Support for IORT RMR node Steven Price
2020-12-10 10:25   ` Steven Price
2020-12-10 10:25   ` Steven Price
2020-12-14 10:55   ` Shameerali Kolothum Thodi
2020-12-14 10:55     ` [Devel] " Shameerali Kolothum Thodi
2020-12-14 10:55     ` Shameerali Kolothum Thodi
2020-12-14 10:55     ` Shameerali Kolothum Thodi
2020-12-14 12:33     ` Robin Murphy
2020-12-14 12:33       ` [Devel] " Robin Murphy
2020-12-14 12:33       ` Robin Murphy
2020-12-14 12:33       ` Robin Murphy
2020-12-14 13:42       ` Steven Price
2020-12-14 13:42         ` Steven Price
2020-12-14 13:42         ` Steven Price
2020-12-14 14:47         ` Shameerali Kolothum Thodi
2020-12-14 14:47           ` [Devel] " Shameerali Kolothum Thodi
2020-12-14 14:47           ` Shameerali Kolothum Thodi
2020-12-14 14:47           ` Shameerali Kolothum Thodi
2020-12-17 14:47           ` Jon Nettleton
2020-12-17 14:47             ` Jon Nettleton
2020-12-17 14:47             ` Jon Nettleton
2020-12-17 15:42             ` Shameerali Kolothum Thodi
2020-12-17 15:42               ` [Devel] " Shameerali Kolothum Thodi
2020-12-17 15:42               ` Shameerali Kolothum Thodi
2020-12-17 15:42               ` Shameerali Kolothum Thodi
2020-12-17 15:53               ` Jon Nettleton
2020-12-17 15:53                 ` Jon Nettleton
2020-12-17 15:53                 ` Jon Nettleton
2020-12-18 10:53                 ` Jon Nettleton
2020-12-18 10:53                   ` Jon Nettleton
2020-12-18 10:53                   ` Jon Nettleton
2021-01-04  8:55                   ` Shameerali Kolothum Thodi
2021-01-04  8:55                     ` [Devel] " Shameerali Kolothum Thodi
2021-01-04  8:55                     ` Shameerali Kolothum Thodi
2021-01-04  8:55                     ` Shameerali Kolothum Thodi
2021-01-04 10:55                     ` Jon Nettleton
2021-01-04 10:55                       ` Jon Nettleton
2021-01-04 10:55                       ` Jon Nettleton
2021-04-09  9:50 ` Auger Eric
2021-04-09  9:50   ` Auger Eric
2021-04-09  9:50   ` Auger Eric
2021-04-09 10:08   ` Shameerali Kolothum Thodi
2021-04-09 10:08     ` [Devel] " Shameerali Kolothum Thodi
2021-04-09 10:08     ` Shameerali Kolothum Thodi
2021-04-09 10:08     ` Shameerali Kolothum Thodi
2021-04-15  9:48 ` Auger Eric
2021-04-15  9:48   ` Auger Eric
2021-04-15  9:48   ` Auger Eric
2021-04-15 10:37   ` Shameerali Kolothum Thodi
2021-04-15 10:37     ` [Devel] " Shameerali Kolothum Thodi
2021-04-15 10:37     ` Shameerali Kolothum Thodi
2021-04-15 10:37     ` Shameerali Kolothum Thodi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119121150.3316-6-shameerali.kolothum.thodi@huawei.com \
    --to=shameerali.kolothum.thodi@huawei.com \
    --cc=Sami.Mujawar@arm.com \
    --cc=devel@acpica.org \
    --cc=guohanjun@huawei.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jonathan.cameron@huawei.com \
    --cc=joro@8bytes.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linuxarm@huawei.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robin.murphy@arm.com \
    --cc=steven.price@arm.com \
    --cc=wanghuiqiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.