All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, jsnow@redhat.com,
	qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org
Subject: [PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running
Date: Sat,  9 Jan 2021 15:26:22 +0300	[thread overview]
Message-ID: <20210109122631.167314-3-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20210109122631.167314-1-vsementsov@virtuozzo.com>

If you run './check 303', check includes common.config which adjusts
$PATH to include '.' first, and therefore finds qcow2.py on PATH.  But
if you run './303' directly, there is nothing to adjust PATH, and if
'.' is not already on your PATH by other means, the test fails because
the executable is not found.  Adjust how we invoke the helper
executable to avoid needing a PATH search in the first place.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 tests/qemu-iotests/303 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/303 b/tests/qemu-iotests/303
index 6c21774483..11cd9eeb26 100755
--- a/tests/qemu-iotests/303
+++ b/tests/qemu-iotests/303
@@ -56,7 +56,7 @@ qemu_img_create('-f', iotests.imgfmt, disk, '10M')
 
 add_bitmap(1, 0, 6, False)
 add_bitmap(2, 6, 8, True)
-dump = ['qcow2.py', disk, 'dump-header']
+dump = ['./qcow2.py', disk, 'dump-header']
 subprocess.run(dump)
 # Dump the metadata in JSON format
 dump.append('-j')
-- 
2.29.2



  parent reply	other threads:[~2021-01-09 12:28 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09 12:26 [PATCH v6 00/11] Rework iotests/check Vladimir Sementsov-Ogievskiy
2021-01-09 12:26 ` [PATCH v6 01/11] iotests/277: use dot slash for nbd-fault-injector.py running Vladimir Sementsov-Ogievskiy
2021-01-13 22:37   ` Eric Blake
2021-01-09 12:26 ` Vladimir Sementsov-Ogievskiy [this message]
2021-01-13 22:38   ` [PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running Eric Blake
2021-01-09 12:26 ` [PATCH v6 03/11] iotests: fix some whitespaces in test output files Vladimir Sementsov-Ogievskiy
2021-01-13 22:51   ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 04/11] iotests: make tests executable Vladimir Sementsov-Ogievskiy
2021-01-13 22:53   ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 05/11] iotests/294: add shebang line Vladimir Sementsov-Ogievskiy
2021-01-13 22:54   ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 06/11] iotests: define group in each iotest Vladimir Sementsov-Ogievskiy
2021-01-13 23:01   ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 07/11] iotests: add findtests.py Vladimir Sementsov-Ogievskiy
2021-01-12 16:42   ` Kevin Wolf
2021-01-13 10:37     ` Vladimir Sementsov-Ogievskiy
2021-01-13 11:18       ` Kevin Wolf
2021-01-14  7:38     ` Vladimir Sementsov-Ogievskiy
2021-01-14 10:48       ` Kevin Wolf
2021-01-13 23:10   ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 08/11] iotests: add testenv.py Vladimir Sementsov-Ogievskiy
2021-01-12 17:36   ` Kevin Wolf
2021-01-14  6:14     ` Vladimir Sementsov-Ogievskiy
2021-01-14  6:16       ` Vladimir Sementsov-Ogievskiy
2021-01-14  4:28   ` Vladimir Sementsov-Ogievskiy
2021-01-14 11:14     ` Kevin Wolf
2021-01-14 11:26       ` Vladimir Sementsov-Ogievskiy
2021-01-15 11:18   ` Kevin Wolf
2021-01-15 12:19     ` Vladimir Sementsov-Ogievskiy
2021-01-15 12:45       ` Kevin Wolf
2021-01-15 13:10         ` Vladimir Sementsov-Ogievskiy
2021-01-15 13:20           ` Kevin Wolf
2021-01-15 13:30             ` Vladimir Sementsov-Ogievskiy
2021-01-16 11:03               ` Vladimir Sementsov-Ogievskiy
2021-01-16 11:19                 ` Vladimir Sementsov-Ogievskiy
2021-01-18  9:59                 ` Kevin Wolf
2021-01-18 17:00                   ` Vladimir Sementsov-Ogievskiy
2021-01-09 12:26 ` [PATCH v6 09/11] iotests: add testrunner.py Vladimir Sementsov-Ogievskiy
2021-01-09 12:26 ` [PATCH v6 10/11] iotests: rewrite check into python Vladimir Sementsov-Ogievskiy
2021-01-12 17:41   ` Kevin Wolf
2021-01-13 23:20   ` Eric Blake
2021-01-14  0:18     ` John Snow
2021-01-09 12:26 ` [PATCH v6 11/11] iotests: rename and move 169 and 199 tests Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210109122631.167314-3-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.