From: Leo Yan <leo.yan@linaro.org> To: Arnaldo Carvalho de Melo <acme@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Mike Leach <mike.leach@linaro.org>, Adrian Hunter <adrian.hunter@intel.com>, Andi Kleen <ak@linux.intel.com>, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan <leo.yan@linaro.org> Subject: [PATCH v2 0/8] perf: Refine barriers for AUX ring buffer Date: Wed, 2 Jun 2021 18:29:59 +0800 [thread overview] Message-ID: <20210602103007.184993-1-leo.yan@linaro.org> (raw) Based on the discussion [1], this patch series is to refine the memory barriers for AUX ring buffer. Patches 01 ~ 04 to address the barriers usage in the kernel. The first patch is to make clear comment for how to use the barriers between the data store and aux_head store, this asks the driver to make sure the data is visible. Patches 02 ~ 04 is to refine the drivers for barriers after the data store. Patches 05 ~ 07 is to fix and clean up the memory barries in perf tool for AUX ring buffer. Since the 64-bit value's atomicity is not promised on 32-bit perf, the last patch is to report error and let perf to directly exit for this case. Have testes the patches on Arm64 Juno platform. [1] https://lore.kernel.org/patchwork/patch/1431867/ Leo Yan (8): perf/ring_buffer: Add comment for barriers on AUX ring buffer coresight: tmc-etr: Add barrier after updating AUX ring buffer coresight: tmc-etf: Add comment for store ordering perf/x86: Add barrier after updating bts perf auxtrace: Change to use SMP memory barriers perf auxtrace: Drop legacy __sync functions perf auxtrace: Use WRITE_ONCE() for updating aux_tail perf record: Directly bail out for compat case arch/x86/events/intel/bts.c | 3 +++ .../hwtracing/coresight/coresight-tmc-etf.c | 6 +++++ .../hwtracing/coresight/coresight-tmc-etr.c | 8 ++++++ kernel/events/ring_buffer.c | 9 +++++++ tools/perf/builtin-record.c | 17 ++++++++++++ tools/perf/util/auxtrace.h | 27 +++---------------- 6 files changed, 47 insertions(+), 23 deletions(-) -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Leo Yan <leo.yan@linaro.org> To: Arnaldo Carvalho de Melo <acme@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Mike Leach <mike.leach@linaro.org>, Adrian Hunter <adrian.hunter@intel.com>, Andi Kleen <ak@linux.intel.com>, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan <leo.yan@linaro.org> Subject: [PATCH v2 0/8] perf: Refine barriers for AUX ring buffer Date: Wed, 2 Jun 2021 18:29:59 +0800 [thread overview] Message-ID: <20210602103007.184993-1-leo.yan@linaro.org> (raw) Based on the discussion [1], this patch series is to refine the memory barriers for AUX ring buffer. Patches 01 ~ 04 to address the barriers usage in the kernel. The first patch is to make clear comment for how to use the barriers between the data store and aux_head store, this asks the driver to make sure the data is visible. Patches 02 ~ 04 is to refine the drivers for barriers after the data store. Patches 05 ~ 07 is to fix and clean up the memory barries in perf tool for AUX ring buffer. Since the 64-bit value's atomicity is not promised on 32-bit perf, the last patch is to report error and let perf to directly exit for this case. Have testes the patches on Arm64 Juno platform. [1] https://lore.kernel.org/patchwork/patch/1431867/ Leo Yan (8): perf/ring_buffer: Add comment for barriers on AUX ring buffer coresight: tmc-etr: Add barrier after updating AUX ring buffer coresight: tmc-etf: Add comment for store ordering perf/x86: Add barrier after updating bts perf auxtrace: Change to use SMP memory barriers perf auxtrace: Drop legacy __sync functions perf auxtrace: Use WRITE_ONCE() for updating aux_tail perf record: Directly bail out for compat case arch/x86/events/intel/bts.c | 3 +++ .../hwtracing/coresight/coresight-tmc-etf.c | 6 +++++ .../hwtracing/coresight/coresight-tmc-etr.c | 8 ++++++ kernel/events/ring_buffer.c | 9 +++++++ tools/perf/builtin-record.c | 17 ++++++++++++ tools/perf/util/auxtrace.h | 27 +++---------------- 6 files changed, 47 insertions(+), 23 deletions(-) -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-06-02 10:30 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-02 10:29 Leo Yan [this message] 2021-06-02 10:29 ` [PATCH v2 0/8] perf: Refine barriers for AUX ring buffer Leo Yan 2021-06-02 10:30 ` [PATCH v2 1/8] perf/ring_buffer: Add comment for barriers on " Leo Yan 2021-06-02 10:30 ` Leo Yan 2021-06-07 15:27 ` Peter Zijlstra 2021-06-07 15:27 ` Peter Zijlstra 2021-06-02 10:30 ` [PATCH v2 2/8] coresight: tmc-etr: Add barrier after updating " Leo Yan 2021-06-02 10:30 ` Leo Yan 2021-06-02 10:30 ` [PATCH v2 3/8] coresight: tmc-etf: Add comment for store ordering Leo Yan 2021-06-02 10:30 ` Leo Yan 2021-06-02 10:30 ` [PATCH v2 4/8] perf/x86: Add barrier after updating bts Leo Yan 2021-06-02 10:30 ` Leo Yan 2021-06-07 15:29 ` Peter Zijlstra 2021-06-07 15:29 ` Peter Zijlstra 2021-06-02 10:30 ` [PATCH v2 5/8] perf auxtrace: Change to use SMP memory barriers Leo Yan 2021-06-02 10:30 ` Leo Yan 2021-06-07 10:02 ` Adrian Hunter 2021-06-07 10:02 ` Adrian Hunter 2021-06-07 15:29 ` Peter Zijlstra 2021-06-07 15:29 ` Peter Zijlstra 2021-06-08 16:45 ` Arnaldo Carvalho de Melo 2021-06-08 16:45 ` Arnaldo Carvalho de Melo 2021-06-02 10:30 ` [PATCH v2 6/8] perf auxtrace: Drop legacy __sync functions Leo Yan 2021-06-02 10:30 ` Leo Yan 2021-06-02 10:47 ` Adrian Hunter 2021-06-02 10:47 ` Adrian Hunter 2021-06-02 11:16 ` Leo Yan 2021-06-02 11:16 ` Leo Yan 2021-06-02 11:21 ` Adrian Hunter 2021-06-02 11:21 ` Adrian Hunter 2021-06-02 13:01 ` Leo Yan 2021-06-02 13:01 ` Leo Yan 2021-06-02 10:30 ` [PATCH v2 7/8] perf auxtrace: Use WRITE_ONCE() for updating aux_tail Leo Yan 2021-06-02 10:30 ` Leo Yan 2021-06-07 10:03 ` Adrian Hunter 2021-06-07 10:03 ` Adrian Hunter 2021-06-07 15:31 ` Peter Zijlstra 2021-06-07 15:31 ` Peter Zijlstra 2021-06-08 17:04 ` Arnaldo Carvalho de Melo 2021-06-08 17:04 ` Arnaldo Carvalho de Melo 2021-06-09 0:21 ` Leo Yan 2021-06-09 0:21 ` Leo Yan 2021-06-02 10:30 ` [PATCH v2 8/8] perf record: Directly bail out for compat case Leo Yan 2021-06-02 10:30 ` Leo Yan 2021-06-02 11:18 ` Adrian Hunter 2021-06-02 11:18 ` Adrian Hunter 2021-06-02 12:38 ` Leo Yan 2021-06-02 12:38 ` Leo Yan 2021-06-07 10:23 ` Adrian Hunter 2021-06-07 10:23 ` Adrian Hunter 2021-06-07 15:09 ` Leo Yan 2021-06-07 15:09 ` Leo Yan 2021-06-09 8:23 ` Adrian Hunter 2021-06-09 8:23 ` Adrian Hunter 2021-06-09 8:57 ` Leo Yan 2021-06-09 8:57 ` Leo Yan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210602103007.184993-1-leo.yan@linaro.org \ --to=leo.yan@linaro.org \ --cc=acme@kernel.org \ --cc=adrian.hunter@intel.com \ --cc=ak@linux.intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=coresight@lists.linaro.org \ --cc=hpa@zytor.com \ --cc=jolsa@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=suzuki.poulose@arm.com \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.