From: Nicolin Chen <nicolinc@nvidia.com>
To: <will@kernel.org>, <robin.murphy@arm.com>, <joro@8bytes.org>,
<alex.williamson@redhat.com>, <cohuck@redhat.com>,
<corbet@lwn.net>
Cc: <nicoleotsuka@gmail.com>, <vdumpa@nvidia.com>,
<thierry.reding@gmail.com>, <linux-tegra@vger.kernel.org>,
<nwatterson@nvidia.com>, <Jonathan.Cameron@huawei.com>,
<jean-philippe@linaro.org>, <song.bao.hua@hisilicon.com>,
<eric.auger@redhat.com>, <thunder.leizhen@huawei.com>,
<yuzenghui@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<iommu@lists.linux-foundation.org>, <kvm@vger.kernel.org>,
<linux-doc@vger.kernel.org>
Subject: [RFC][PATCH v2 06/13] vfio/type1: Set/get VMID to/from iommu driver
Date: Mon, 30 Aug 2021 19:59:16 -0700 [thread overview]
Message-ID: <20210831025923.15812-7-nicolinc@nvidia.com> (raw)
In-Reply-To: <20210831025923.15812-1-nicolinc@nvidia.com>
This patch adds a pair of callbacks of iommu_set_nesting_vmid() and
iommu_get_nesting_vmid() to exchange VMID with the IOMMU core (then
an IOMMU driver).
As a VMID is generated in an IOMMU driver, which is called from the
vfio_iommu_attach_group() function call, add iommu_get_nesting_vmid
right after it creates a VMID and add iommu_set_nesting_vmid before
it to let IOMMU driver reuse it.
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
---
drivers/vfio/vfio_iommu_type1.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index bb5d949bc1af..9e72d74dedcd 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -2322,12 +2322,24 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
ret = iommu_enable_nesting(domain->domain);
if (ret)
goto out_domain;
+
+ if (iommu->vmid != VFIO_IOMMU_VMID_INVALID) {
+ ret = iommu_set_nesting_vmid(domain->domain, iommu->vmid);
+ if (ret)
+ goto out_domain;
+ }
}
ret = vfio_iommu_attach_group(domain, group);
if (ret)
goto out_domain;
+ if (iommu->nesting && iommu->vmid == VFIO_IOMMU_VMID_INVALID) {
+ ret = iommu_get_nesting_vmid(domain->domain, &iommu->vmid);
+ if (ret)
+ goto out_domain;
+ }
+
/* Get aperture info */
geo = &domain->domain->geometry;
if (vfio_iommu_aper_conflict(iommu, geo->aperture_start,
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen via iommu <iommu@lists.linux-foundation.org>
To: <will@kernel.org>, <robin.murphy@arm.com>, <joro@8bytes.org>,
<alex.williamson@redhat.com>, <cohuck@redhat.com>,
<corbet@lwn.net>
Cc: jean-philippe@linaro.org, kvm@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, thierry.reding@gmail.com,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH v2 06/13] vfio/type1: Set/get VMID to/from iommu driver
Date: Mon, 30 Aug 2021 19:59:16 -0700 [thread overview]
Message-ID: <20210831025923.15812-7-nicolinc@nvidia.com> (raw)
In-Reply-To: <20210831025923.15812-1-nicolinc@nvidia.com>
This patch adds a pair of callbacks of iommu_set_nesting_vmid() and
iommu_get_nesting_vmid() to exchange VMID with the IOMMU core (then
an IOMMU driver).
As a VMID is generated in an IOMMU driver, which is called from the
vfio_iommu_attach_group() function call, add iommu_get_nesting_vmid
right after it creates a VMID and add iommu_set_nesting_vmid before
it to let IOMMU driver reuse it.
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
---
drivers/vfio/vfio_iommu_type1.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index bb5d949bc1af..9e72d74dedcd 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -2322,12 +2322,24 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
ret = iommu_enable_nesting(domain->domain);
if (ret)
goto out_domain;
+
+ if (iommu->vmid != VFIO_IOMMU_VMID_INVALID) {
+ ret = iommu_set_nesting_vmid(domain->domain, iommu->vmid);
+ if (ret)
+ goto out_domain;
+ }
}
ret = vfio_iommu_attach_group(domain, group);
if (ret)
goto out_domain;
+ if (iommu->nesting && iommu->vmid == VFIO_IOMMU_VMID_INVALID) {
+ ret = iommu_get_nesting_vmid(domain->domain, &iommu->vmid);
+ if (ret)
+ goto out_domain;
+ }
+
/* Get aperture info */
geo = &domain->domain->geometry;
if (vfio_iommu_aper_conflict(iommu, geo->aperture_start,
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicolinc@nvidia.com>
To: <will@kernel.org>, <robin.murphy@arm.com>, <joro@8bytes.org>,
<alex.williamson@redhat.com>, <cohuck@redhat.com>,
<corbet@lwn.net>
Cc: song.bao.hua@hisilicon.com, jean-philippe@linaro.org,
kvm@vger.kernel.org, nwatterson@nvidia.com,
linux-doc@vger.kernel.org, thunder.leizhen@huawei.com,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
yuzenghui@huawei.com, nicoleotsuka@gmail.com,
eric.auger@redhat.com, thierry.reding@gmail.com,
Jonathan.Cameron@huawei.com, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH v2 06/13] vfio/type1: Set/get VMID to/from iommu driver
Date: Mon, 30 Aug 2021 19:59:16 -0700 [thread overview]
Message-ID: <20210831025923.15812-7-nicolinc@nvidia.com> (raw)
In-Reply-To: <20210831025923.15812-1-nicolinc@nvidia.com>
This patch adds a pair of callbacks of iommu_set_nesting_vmid() and
iommu_get_nesting_vmid() to exchange VMID with the IOMMU core (then
an IOMMU driver).
As a VMID is generated in an IOMMU driver, which is called from the
vfio_iommu_attach_group() function call, add iommu_get_nesting_vmid
right after it creates a VMID and add iommu_set_nesting_vmid before
it to let IOMMU driver reuse it.
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
---
drivers/vfio/vfio_iommu_type1.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index bb5d949bc1af..9e72d74dedcd 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -2322,12 +2322,24 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
ret = iommu_enable_nesting(domain->domain);
if (ret)
goto out_domain;
+
+ if (iommu->vmid != VFIO_IOMMU_VMID_INVALID) {
+ ret = iommu_set_nesting_vmid(domain->domain, iommu->vmid);
+ if (ret)
+ goto out_domain;
+ }
}
ret = vfio_iommu_attach_group(domain, group);
if (ret)
goto out_domain;
+ if (iommu->nesting && iommu->vmid == VFIO_IOMMU_VMID_INVALID) {
+ ret = iommu_get_nesting_vmid(domain->domain, &iommu->vmid);
+ if (ret)
+ goto out_domain;
+ }
+
/* Get aperture info */
geo = &domain->domain->geometry;
if (vfio_iommu_aper_conflict(iommu, geo->aperture_start,
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-31 3:07 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 2:59 [RFC][PATCH v2 00/13] iommu/arm-smmu-v3: Add NVIDIA implementation Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 2:59 ` [RFC][PATCH v2 01/13] iommu: Add set_nesting_vmid/get_nesting_vmid functions Nicolin Chen via iommu
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` [RFC][PATCH v2 02/13] vfio: add VFIO_IOMMU_GET_VMID and VFIO_IOMMU_SET_VMID Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 2:59 ` [RFC][PATCH v2 03/13] vfio: Document VMID control for IOMMU Virtualization Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 2:59 ` [RFC][PATCH v2 04/13] vfio: add set_vmid and get_vmid for vfio_iommu_type1 Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 2:59 ` [RFC][PATCH v2 05/13] vfio/type1: Implement set_vmid and get_vmid Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 2:59 ` Nicolin Chen [this message]
2021-08-31 2:59 ` [RFC][PATCH v2 06/13] vfio/type1: Set/get VMID to/from iommu driver Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 2:59 ` [RFC][PATCH v2 07/13] iommu/arm-smmu-v3: Add shared VMID support for NESTING Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 2:59 ` [RFC][PATCH v2 08/13] iommu/arm-smmu-v3: Add VMID alloc/free helpers Nicolin Chen via iommu
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` [RFC][PATCH v2 09/13] iommu/arm-smmu-v3: Pass dev pointer to arm_smmu_detach_dev Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 2:59 ` [RFC][PATCH v2 10/13] iommu/arm-smmu-v3: Pass cmdq pointer in arm_smmu_cmdq_issue_cmdlist() Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 2:59 ` [RFC][PATCH v2 11/13] iommu/arm-smmu-v3: Add implementation infrastructure Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 2:59 ` [RFC][PATCH v2 12/13] iommu/arm-smmu-v3: Add support for NVIDIA CMDQ-Virtualization hw Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 8:03 ` kernel test robot
2021-08-31 9:13 ` kernel test robot
2021-08-31 9:13 ` kernel test robot
2021-08-31 2:59 ` [RFC][PATCH v2 13/13] iommu/nvidia-smmu-v3: Add mdev interface support Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen
2021-08-31 2:59 ` Nicolin Chen via iommu
2021-08-31 8:58 ` kernel test robot
2021-08-31 10:26 ` kernel test robot
2021-08-31 10:26 ` kernel test robot
2021-08-31 16:15 ` [RFC][PATCH v2 00/13] iommu/arm-smmu-v3: Add NVIDIA implementation Alex Williamson
2021-08-31 16:15 ` Alex Williamson
2021-08-31 16:15 ` Alex Williamson
2021-09-01 6:55 ` Tian, Kevin
2021-09-01 6:55 ` Tian, Kevin
2021-09-01 6:55 ` Tian, Kevin
2021-09-02 14:45 ` Jason Gunthorpe
2021-09-02 14:45 ` Jason Gunthorpe
2021-09-02 14:45 ` Jason Gunthorpe via iommu
2021-09-02 22:27 ` Tian, Kevin
2021-09-02 22:27 ` Tian, Kevin
2021-09-02 22:27 ` Tian, Kevin
2021-09-16 18:21 ` Nicolin Chen
2021-09-16 18:21 ` Nicolin Chen
2021-09-16 18:21 ` Nicolin Chen via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210831025923.15812-7-nicolinc@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=corbet@lwn.net \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=nwatterson@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=song.bao.hua@hisilicon.com \
--cc=thierry.reding@gmail.com \
--cc=thunder.leizhen@huawei.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.