From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Robert Richter <rric@kernel.org>, <linux-edac@vger.kernel.org>
Cc: Khuong Dinh <khuong@os.amperecomputing.com>
Subject: [PATCH 2/2] edac: xgene: fix deferred probing
Date: Mon, 24 Jan 2022 21:55:03 +0300 [thread overview]
Message-ID: <20220124185503.6720-3-s.shtylyov@omp.ru> (raw)
In-Reply-To: <20220124185503.6720-1-s.shtylyov@omp.ru>
The driver overrides error codes returned by platform_get_irq_optional()
to -EINVAL for some strange reason, so if it returns -EPROBE_DEFER, the
driver will fail the probe permanently instead of the deferred probing.
Switch to propagating the error codes upstream.
Fixes: 0d4429301c4 ("EDAC: Add APM X-Gene SoC EDAC driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/edac/xgene_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
index 2ccd1db5e98f..7197f9fa0245 100644
--- a/drivers/edac/xgene_edac.c
+++ b/drivers/edac/xgene_edac.c
@@ -1919,7 +1919,7 @@ static int xgene_edac_probe(struct platform_device *pdev)
irq = platform_get_irq_optional(pdev, i);
if (irq < 0) {
dev_err(&pdev->dev, "No IRQ resource\n");
- rc = -EINVAL;
+ rc = irq;
goto out_err;
}
rc = devm_request_irq(&pdev->dev, irq,
--
2.26.3
next prev parent reply other threads:[~2022-01-24 18:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 18:55 [PATCH 0/2] Fix deferred probing in the EDAC drivers Sergey Shtylyov
2022-01-24 18:55 ` [PATCH 1/2] edac: altera: fix deferred probing Sergey Shtylyov
2022-01-26 16:52 ` Dinh Nguyen
2022-01-28 18:36 ` Borislav Petkov
2022-01-28 18:53 ` Sergey Shtylyov
2022-01-28 19:02 ` Sergey Shtylyov
2022-01-28 19:16 ` Borislav Petkov
2022-01-28 19:17 ` Sergey Shtylyov
2022-01-28 19:20 ` Borislav Petkov
2022-01-28 19:35 ` Sergey Shtylyov
2022-01-28 19:47 ` Sergey Shtylyov
2022-01-29 6:48 ` Greg KH
2022-01-29 10:33 ` Borislav Petkov
2022-01-28 19:53 ` Sergey Shtylyov
2022-01-28 19:56 ` Sergey Shtylyov
2022-01-24 18:55 ` Sergey Shtylyov [this message]
2022-01-28 22:39 ` [PATCH 0/2] Fix deferred probing in the EDAC drivers Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220124185503.6720-3-s.shtylyov@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=khuong@os.amperecomputing.com \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.