From: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> To: Andrew Jeffery <andrew@aj.id.au>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, Joel Stanley <joel@jms.id.au>, Arnd Bergmann <arnd@arndb.de> Cc: Jamie Iles <quic_jiles@quicinc.com>, Graeme Gregory <quic_ggregory@quicinc.com>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-aspeed@lists.ozlabs.org>, "Jae Hyun Yoo" <quic_jaehyoo@quicinc.com> Subject: [PATCH v3 2/7] pinctrl: pinctrl-aspeed-g6: remove FWQSPID group in pinctrl Date: Tue, 29 Mar 2022 10:39:27 -0700 [thread overview] Message-ID: <20220329173932.2588289-3-quic_jaehyoo@quicinc.com> (raw) In-Reply-To: <20220329173932.2588289-1-quic_jaehyoo@quicinc.com> FWSPIDQ2 and FWSPIDQ3 are not part of FWSPI18 interface so remove FWQSPID group in pinctrl. These pins must be used with the FWSPI pins that are dedicated for boot SPI interface which provides same 3.3v logic level. Fixes: 2eda1cdec49f ("pinctrl: aspeed: Add AST2600 pinmux support") Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> --- Changes in v3: * None. Changes in v2: * None. drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c index a3fa03bcd9a3..54064714d73f 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c @@ -1236,18 +1236,12 @@ FUNC_GROUP_DECL(SALT8, AA12); FUNC_GROUP_DECL(WDTRST4, AA12); #define AE12 196 -SIG_EXPR_LIST_DECL_SEMG(AE12, FWSPIDQ2, FWQSPID, FWSPID, - SIG_DESC_SET(SCU438, 4)); SIG_EXPR_LIST_DECL_SESG(AE12, GPIOY4, GPIOY4); -PIN_DECL_(AE12, SIG_EXPR_LIST_PTR(AE12, FWSPIDQ2), - SIG_EXPR_LIST_PTR(AE12, GPIOY4)); +PIN_DECL_(AE12, SIG_EXPR_LIST_PTR(AE12, GPIOY4)); #define AF12 197 -SIG_EXPR_LIST_DECL_SEMG(AF12, FWSPIDQ3, FWQSPID, FWSPID, - SIG_DESC_SET(SCU438, 5)); SIG_EXPR_LIST_DECL_SESG(AF12, GPIOY5, GPIOY5); -PIN_DECL_(AF12, SIG_EXPR_LIST_PTR(AF12, FWSPIDQ3), - SIG_EXPR_LIST_PTR(AF12, GPIOY5)); +PIN_DECL_(AF12, SIG_EXPR_LIST_PTR(AF12, GPIOY5)); #define AC12 198 SSSF_PIN_DECL(AC12, GPIOY6, FWSPIABR, SIG_DESC_SET(SCU438, 6)); @@ -1520,9 +1514,8 @@ SIG_EXPR_LIST_DECL_SEMG(Y4, EMMCDAT7, EMMCG8, EMMC, SIG_DESC_SET(SCU404, 3)); PIN_DECL_3(Y4, GPIO18E3, FWSPIDMISO, VBMISO, EMMCDAT7); GROUP_DECL(FWSPID, Y1, Y2, Y3, Y4); -GROUP_DECL(FWQSPID, Y1, Y2, Y3, Y4, AE12, AF12); GROUP_DECL(EMMCG8, AB4, AA4, AC4, AA5, Y5, AB5, AB6, AC5, Y1, Y2, Y3, Y4); -FUNC_DECL_2(FWSPID, FWSPID, FWQSPID); +FUNC_DECL_1(FWSPID, FWSPID); FUNC_GROUP_DECL(VB, Y1, Y2, Y3, Y4); FUNC_DECL_3(EMMC, EMMCG1, EMMCG4, EMMCG8); /* @@ -1918,7 +1911,6 @@ static const struct aspeed_pin_group aspeed_g6_groups[] = { ASPEED_PINCTRL_GROUP(FSI2), ASPEED_PINCTRL_GROUP(FWSPIABR), ASPEED_PINCTRL_GROUP(FWSPID), - ASPEED_PINCTRL_GROUP(FWQSPID), ASPEED_PINCTRL_GROUP(FWSPIWP), ASPEED_PINCTRL_GROUP(GPIT0), ASPEED_PINCTRL_GROUP(GPIT1), -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> To: Andrew Jeffery <andrew@aj.id.au>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, Joel Stanley <joel@jms.id.au>, Arnd Bergmann <arnd@arndb.de> Cc: Jamie Iles <quic_jiles@quicinc.com>, Graeme Gregory <quic_ggregory@quicinc.com>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-aspeed@lists.ozlabs.org>, "Jae Hyun Yoo" <quic_jaehyoo@quicinc.com> Subject: [PATCH v3 2/7] pinctrl: pinctrl-aspeed-g6: remove FWQSPID group in pinctrl Date: Tue, 29 Mar 2022 10:39:27 -0700 [thread overview] Message-ID: <20220329173932.2588289-3-quic_jaehyoo@quicinc.com> (raw) In-Reply-To: <20220329173932.2588289-1-quic_jaehyoo@quicinc.com> FWSPIDQ2 and FWSPIDQ3 are not part of FWSPI18 interface so remove FWQSPID group in pinctrl. These pins must be used with the FWSPI pins that are dedicated for boot SPI interface which provides same 3.3v logic level. Fixes: 2eda1cdec49f ("pinctrl: aspeed: Add AST2600 pinmux support") Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> --- Changes in v3: * None. Changes in v2: * None. drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c index a3fa03bcd9a3..54064714d73f 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c @@ -1236,18 +1236,12 @@ FUNC_GROUP_DECL(SALT8, AA12); FUNC_GROUP_DECL(WDTRST4, AA12); #define AE12 196 -SIG_EXPR_LIST_DECL_SEMG(AE12, FWSPIDQ2, FWQSPID, FWSPID, - SIG_DESC_SET(SCU438, 4)); SIG_EXPR_LIST_DECL_SESG(AE12, GPIOY4, GPIOY4); -PIN_DECL_(AE12, SIG_EXPR_LIST_PTR(AE12, FWSPIDQ2), - SIG_EXPR_LIST_PTR(AE12, GPIOY4)); +PIN_DECL_(AE12, SIG_EXPR_LIST_PTR(AE12, GPIOY4)); #define AF12 197 -SIG_EXPR_LIST_DECL_SEMG(AF12, FWSPIDQ3, FWQSPID, FWSPID, - SIG_DESC_SET(SCU438, 5)); SIG_EXPR_LIST_DECL_SESG(AF12, GPIOY5, GPIOY5); -PIN_DECL_(AF12, SIG_EXPR_LIST_PTR(AF12, FWSPIDQ3), - SIG_EXPR_LIST_PTR(AF12, GPIOY5)); +PIN_DECL_(AF12, SIG_EXPR_LIST_PTR(AF12, GPIOY5)); #define AC12 198 SSSF_PIN_DECL(AC12, GPIOY6, FWSPIABR, SIG_DESC_SET(SCU438, 6)); @@ -1520,9 +1514,8 @@ SIG_EXPR_LIST_DECL_SEMG(Y4, EMMCDAT7, EMMCG8, EMMC, SIG_DESC_SET(SCU404, 3)); PIN_DECL_3(Y4, GPIO18E3, FWSPIDMISO, VBMISO, EMMCDAT7); GROUP_DECL(FWSPID, Y1, Y2, Y3, Y4); -GROUP_DECL(FWQSPID, Y1, Y2, Y3, Y4, AE12, AF12); GROUP_DECL(EMMCG8, AB4, AA4, AC4, AA5, Y5, AB5, AB6, AC5, Y1, Y2, Y3, Y4); -FUNC_DECL_2(FWSPID, FWSPID, FWQSPID); +FUNC_DECL_1(FWSPID, FWSPID); FUNC_GROUP_DECL(VB, Y1, Y2, Y3, Y4); FUNC_DECL_3(EMMC, EMMCG1, EMMCG4, EMMCG8); /* @@ -1918,7 +1911,6 @@ static const struct aspeed_pin_group aspeed_g6_groups[] = { ASPEED_PINCTRL_GROUP(FSI2), ASPEED_PINCTRL_GROUP(FWSPIABR), ASPEED_PINCTRL_GROUP(FWSPID), - ASPEED_PINCTRL_GROUP(FWQSPID), ASPEED_PINCTRL_GROUP(FWSPIWP), ASPEED_PINCTRL_GROUP(GPIT0), ASPEED_PINCTRL_GROUP(GPIT1), -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-29 17:40 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-29 17:39 [PATCH v3 0/7] Fix AST2600 quad mode SPI pinmux settings Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-29 17:39 ` [PATCH v3 1/7] ARM: dts: aspeed-g6: remove FWQSPID group in pinctrl dtsi Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo [this message] 2022-03-29 17:39 ` [PATCH v3 2/7] pinctrl: pinctrl-aspeed-g6: remove FWQSPID group in pinctrl Jae Hyun Yoo 2022-03-30 2:00 ` Andrew Jeffery 2022-03-30 2:00 ` Andrew Jeffery 2022-03-29 17:39 ` [PATCH v3 3/7] dt-bindings: pinctrl: aspeed-g6: remove FWQSPID group Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-29 23:38 ` Rob Herring 2022-03-29 23:38 ` Rob Herring 2022-03-30 2:01 ` Andrew Jeffery 2022-03-30 2:01 ` Andrew Jeffery 2022-03-29 17:39 ` [PATCH v3 4/7] pinctrl: pinctrl-aspeed-g6: add FWQSPI function-group Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-30 2:02 ` Andrew Jeffery 2022-03-30 2:02 ` Andrew Jeffery 2022-03-29 17:39 ` [PATCH v3 5/7] dt-bindings: pinctrl: aspeed-g6: add FWQSPI function/group Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-29 23:38 ` Rob Herring 2022-03-29 23:38 ` Rob Herring 2022-03-30 2:03 ` Andrew Jeffery 2022-03-30 2:03 ` Andrew Jeffery 2022-03-29 17:39 ` [PATCH v3 6/7] ARM: dts: aspeed-g6: add FWQSPI group in pinctrl dtsi Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-30 2:03 ` Andrew Jeffery 2022-03-30 2:03 ` Andrew Jeffery 2022-03-29 17:39 ` [PATCH v3 7/7] ARM: dts: aspeed-g6: fix SPI1/SPI2 quad pin group Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-31 5:50 ` [PATCH v3 0/7] Fix AST2600 quad mode SPI pinmux settings Joel Stanley 2022-03-31 5:50 ` Joel Stanley 2022-03-31 15:44 ` Jae Hyun Yoo 2022-03-31 15:44 ` Jae Hyun Yoo 2022-03-31 15:56 ` Cédric Le Goater 2022-03-31 15:56 ` Cédric Le Goater 2022-03-31 16:06 ` Jae Hyun Yoo 2022-03-31 16:06 ` Jae Hyun Yoo 2022-04-01 14:10 ` Jae Hyun Yoo 2022-04-01 14:10 ` Jae Hyun Yoo 2022-04-01 22:07 ` Cédric Le Goater 2022-04-01 22:07 ` Cédric Le Goater 2022-04-01 22:25 ` Jae Hyun Yoo 2022-04-01 22:25 ` Jae Hyun Yoo 2022-04-17 23:28 ` Linus Walleij 2022-04-17 23:28 ` Linus Walleij 2022-04-18 14:07 ` Jae Hyun Yoo 2022-04-18 14:07 ` Jae Hyun Yoo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220329173932.2588289-3-quic_jaehyoo@quicinc.com \ --to=quic_jaehyoo@quicinc.com \ --cc=andrew@aj.id.au \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=krzk+dt@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=quic_ggregory@quicinc.com \ --cc=quic_jiles@quicinc.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.