All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Ben Widawsky <ben.widawsky@intel.com>
Subject: [PULL 06/12] hw/cxl: Fix memory leak in error paths
Date: Wed, 17 Aug 2022 16:06:10 -0400	[thread overview]
Message-ID: <20220817200536.350795-7-mst@redhat.com> (raw)
In-Reply-To: <20220817200536.350795-1-mst@redhat.com>

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Use g_autofree to free the CXLFixedWindow structure if an
error occurs in configuration before we have added to
the list (via g_steal_pointer())

Fix Coverity CID: 1488872

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20220808122051.14822-2-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/cxl/cxl-host.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c
index 483d8eb13f..faa68ef038 100644
--- a/hw/cxl/cxl-host.c
+++ b/hw/cxl/cxl-host.c
@@ -26,7 +26,7 @@ static void cxl_fixed_memory_window_config(CXLState *cxl_state,
                                            CXLFixedMemoryWindowOptions *object,
                                            Error **errp)
 {
-    CXLFixedWindow *fw = g_malloc0(sizeof(*fw));
+    g_autofree CXLFixedWindow *fw = g_malloc0(sizeof(*fw));
     strList *target;
     int i;
 
@@ -64,7 +64,8 @@ static void cxl_fixed_memory_window_config(CXLState *cxl_state,
         fw->enc_int_gran = 0;
     }
 
-    cxl_state->fixed_windows = g_list_append(cxl_state->fixed_windows, fw);
+    cxl_state->fixed_windows = g_list_append(cxl_state->fixed_windows,
+                                             g_steal_pointer(&fw));
 
     return;
 }
-- 
MST



  parent reply	other threads:[~2022-08-17 20:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 20:05 [PULL 00/12] pc,virtio: fixes Michael S. Tsirkin
2022-08-17 20:05 ` [PULL 01/12] virtio-scsi: fix race in virtio_scsi_dataplane_start() Michael S. Tsirkin
2022-08-17 20:05 ` [PULL 02/12] hw/virtio: gracefully handle unset vhost_dev vdev Michael S. Tsirkin
2022-08-17 20:05 ` [PULL 03/12] hw/virtio: handle un-configured shutdown in virtio-pci Michael S. Tsirkin
2022-08-17 20:06 ` [PULL 04/12] hw/virtio: fix vhost_user_read tracepoint Michael S. Tsirkin
2022-08-17 20:06 ` [PULL 05/12] x86: disable rng seeding via setup_data Michael S. Tsirkin
2022-08-17 20:06 ` Michael S. Tsirkin [this message]
2022-08-17 20:06 ` [PULL 07/12] hw/cxl: Fix wrong query of target ports Michael S. Tsirkin
2022-08-17 20:06 ` [PULL 08/12] hw/cxl: Add stub write function for RO MemoryRegionOps entries Michael S. Tsirkin
2022-08-17 20:06 ` [PULL 09/12] hw/cxl: Fix Get LSA input payload size which should be 8 bytes Michael S. Tsirkin
2022-08-17 20:06 ` [PULL 10/12] hw/cxl: Correctly handle variable sized mailbox input payloads Michael S. Tsirkin
2022-08-17 20:06 ` [PULL 11/12] tests: acpi: silence applesmc warning about invalid key Michael S. Tsirkin
2022-08-17 20:06 ` [PULL 12/12] virtio-pci: don't touch pci on virtio reset Michael S. Tsirkin
2022-08-18 15:35 ` [PULL 00/12] pc,virtio: fixes Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220817200536.350795-7-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=ben.widawsky@intel.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.