All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Ulf Hansson <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-sunxi@lists.linux.dev>
Subject: [PATCH v2 11/12] mmc: sunxi: fix deferred probing
Date: Thu, 8 Jun 2023 22:45:18 +0300	[thread overview]
Message-ID: <20230608194519.10665-12-s.shtylyov@omp.ru> (raw)
In-Reply-To: <20230608194519.10665-1-s.shtylyov@omp.ru>

The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream.  IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...

Fixes: 2408a08583d ("mmc: sunxi-mmc: Handle return value of platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
Changes in version 2:
- slightly reformatted the patch description.

 drivers/mmc/host/sunxi-mmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index 3db9f32d6a7b..69dcb8805e05 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1350,8 +1350,8 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
 		return ret;
 
 	host->irq = platform_get_irq(pdev, 0);
-	if (host->irq <= 0) {
-		ret = -EINVAL;
+	if (host->irq < 0) {
+		ret = host->irq;
 		goto error_disable_mmc;
 	}
 
-- 
2.26.3


WARNING: multiple messages have this Message-ID (diff)
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Ulf Hansson <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-sunxi@lists.linux.dev>
Subject: [PATCH v2 11/12] mmc: sunxi: fix deferred probing
Date: Thu, 8 Jun 2023 22:45:18 +0300	[thread overview]
Message-ID: <20230608194519.10665-12-s.shtylyov@omp.ru> (raw)
In-Reply-To: <20230608194519.10665-1-s.shtylyov@omp.ru>

The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream.  IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...

Fixes: 2408a08583d ("mmc: sunxi-mmc: Handle return value of platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
Changes in version 2:
- slightly reformatted the patch description.

 drivers/mmc/host/sunxi-mmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index 3db9f32d6a7b..69dcb8805e05 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1350,8 +1350,8 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
 		return ret;
 
 	host->irq = platform_get_irq(pdev, 0);
-	if (host->irq <= 0) {
-		ret = -EINVAL;
+	if (host->irq < 0) {
+		ret = host->irq;
 		goto error_disable_mmc;
 	}
 
-- 
2.26.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-06-08 20:01 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 19:45 [PATCH v2 00/12] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 01/12] mmc: bcm2835: fix deferred probing Sergey Shtylyov
2023-06-08 19:45   ` Sergey Shtylyov
2023-06-08 21:39   ` Stefan Wahren
2023-06-08 21:39     ` Stefan Wahren
2023-06-12 19:43     ` Sergey Shtylyov
2023-06-12 19:43       ` Sergey Shtylyov
2023-06-13  8:56       ` Stefan Wahren
2023-06-13  8:56         ` Stefan Wahren
2023-06-13 21:08         ` Sergey Shtylyov
2023-06-13 21:08           ` Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 02/12] mmc: meson-gx: " Sergey Shtylyov
2023-06-08 19:45   ` Sergey Shtylyov
2023-06-08 19:45   ` Sergey Shtylyov
2023-06-09  7:20   ` Neil Armstrong
2023-06-09  7:20     ` Neil Armstrong
2023-06-09  7:20     ` Neil Armstrong
2023-06-08 19:45 ` [PATCH v2 03/12] mmc: mtk-sd: " Sergey Shtylyov
2023-06-08 19:45   ` Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 04/12] mmc: mvsdio: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 05/12] mmc: omap: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 06/12] mmc: omap_hsmmc: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 07/12] mmc: owl: " Sergey Shtylyov
2023-06-08 19:45   ` Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 08/12] mmc: sdhci-acpi: " Sergey Shtylyov
2023-06-09  5:43   ` Adrian Hunter
2023-06-08 19:45 ` [PATCH v2 09/12] mmc: sdhci-spear: " Sergey Shtylyov
2023-06-09  4:40   ` Viresh Kumar
2023-06-09  5:44   ` Adrian Hunter
2023-06-08 19:45 ` [PATCH v2 10/12] mmc: sh_mmcif: " Sergey Shtylyov
2023-06-08 19:45 ` Sergey Shtylyov [this message]
2023-06-08 19:45   ` [PATCH v2 11/12] mmc: sunxi: " Sergey Shtylyov
2023-06-09 20:48   ` Jernej Škrabec
2023-06-09 20:48     ` Jernej Škrabec
2023-06-08 19:45 ` [PATCH v2 12/12] mmc: usdhi60rol0: " Sergey Shtylyov
2023-06-12 14:16 ` [PATCH v2 00/12] Fix deferred probing in the MMC/SD drivers Ulf Hansson
2023-06-12 19:48   ` Sergey Shtylyov
2023-06-12 20:18     ` Ulf Hansson
2023-06-13 20:04       ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230608194519.10665-12-s.shtylyov@omp.ru \
    --to=s.shtylyov@omp.ru \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=samuel@sholland.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.