All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Ulf Hansson <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>
Cc: Chaotian Jing <chaotian.jing@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 03/12] mmc: mtk-sd: fix deferred probing
Date: Thu, 8 Jun 2023 22:45:10 +0300	[thread overview]
Message-ID: <20230608194519.10665-4-s.shtylyov@omp.ru> (raw)
In-Reply-To: <20230608194519.10665-1-s.shtylyov@omp.ru>

The driver overrides the error codes returned by platform_get_irq() to
-EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.

Fixes: 208489032bdd ("mmc: mediatek: Add Mediatek MMC driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
Changes in version 2:
- refreshed the patch.

 drivers/mmc/host/mtk-sd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index edade0e54a0c..9785ec91654f 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2680,7 +2680,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
 
 	host->irq = platform_get_irq(pdev, 0);
 	if (host->irq < 0) {
-		ret = -EINVAL;
+		ret = host->irq;
 		goto host_free;
 	}
 
-- 
2.26.3


WARNING: multiple messages have this Message-ID (diff)
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Ulf Hansson <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>
Cc: Chaotian Jing <chaotian.jing@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 03/12] mmc: mtk-sd: fix deferred probing
Date: Thu, 8 Jun 2023 22:45:10 +0300	[thread overview]
Message-ID: <20230608194519.10665-4-s.shtylyov@omp.ru> (raw)
In-Reply-To: <20230608194519.10665-1-s.shtylyov@omp.ru>

The driver overrides the error codes returned by platform_get_irq() to
-EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.

Fixes: 208489032bdd ("mmc: mediatek: Add Mediatek MMC driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
Changes in version 2:
- refreshed the patch.

 drivers/mmc/host/mtk-sd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index edade0e54a0c..9785ec91654f 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2680,7 +2680,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
 
 	host->irq = platform_get_irq(pdev, 0);
 	if (host->irq < 0) {
-		ret = -EINVAL;
+		ret = host->irq;
 		goto host_free;
 	}
 
-- 
2.26.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-06-08 19:45 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 19:45 [PATCH v2 00/12] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 01/12] mmc: bcm2835: fix deferred probing Sergey Shtylyov
2023-06-08 19:45   ` Sergey Shtylyov
2023-06-08 21:39   ` Stefan Wahren
2023-06-08 21:39     ` Stefan Wahren
2023-06-12 19:43     ` Sergey Shtylyov
2023-06-12 19:43       ` Sergey Shtylyov
2023-06-13  8:56       ` Stefan Wahren
2023-06-13  8:56         ` Stefan Wahren
2023-06-13 21:08         ` Sergey Shtylyov
2023-06-13 21:08           ` Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 02/12] mmc: meson-gx: " Sergey Shtylyov
2023-06-08 19:45   ` Sergey Shtylyov
2023-06-08 19:45   ` Sergey Shtylyov
2023-06-09  7:20   ` Neil Armstrong
2023-06-09  7:20     ` Neil Armstrong
2023-06-09  7:20     ` Neil Armstrong
2023-06-08 19:45 ` Sergey Shtylyov [this message]
2023-06-08 19:45   ` [PATCH v2 03/12] mmc: mtk-sd: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 04/12] mmc: mvsdio: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 05/12] mmc: omap: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 06/12] mmc: omap_hsmmc: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 07/12] mmc: owl: " Sergey Shtylyov
2023-06-08 19:45   ` Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 08/12] mmc: sdhci-acpi: " Sergey Shtylyov
2023-06-09  5:43   ` Adrian Hunter
2023-06-08 19:45 ` [PATCH v2 09/12] mmc: sdhci-spear: " Sergey Shtylyov
2023-06-09  4:40   ` Viresh Kumar
2023-06-09  5:44   ` Adrian Hunter
2023-06-08 19:45 ` [PATCH v2 10/12] mmc: sh_mmcif: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 11/12] mmc: sunxi: " Sergey Shtylyov
2023-06-08 19:45   ` Sergey Shtylyov
2023-06-09 20:48   ` Jernej Škrabec
2023-06-09 20:48     ` Jernej Škrabec
2023-06-08 19:45 ` [PATCH v2 12/12] mmc: usdhi60rol0: " Sergey Shtylyov
2023-06-12 14:16 ` [PATCH v2 00/12] Fix deferred probing in the MMC/SD drivers Ulf Hansson
2023-06-12 19:48   ` Sergey Shtylyov
2023-06-12 20:18     ` Ulf Hansson
2023-06-13 20:04       ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230608194519.10665-4-s.shtylyov@omp.ru \
    --to=s.shtylyov@omp.ru \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chaotian.jing@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.