All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	"Wilczynski, Michal" <michal.wilczynski@intel.com>,
	Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
	"Siwik, Grzegorz" <grzegorz.siwik@intel.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>
Cc: "regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	intel-wired-lan@lists.osuosl.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] ice: Error setting promisc mode on VSI 6 (rc=-17) @ 5.18.x
Date: Wed, 17 Aug 2022 18:07:05 +0200	[thread overview]
Message-ID: <61698d9d-088d-a878-2b23-f5423045c00e@leemhuis.info> (raw)
In-Reply-To: <2151f504-5244-5680-1d70-1fcd8ecd7022@intel.com>

On 17.08.22 17:59, Tony Nguyen wrote:
> On 8/17/2022 2:08 AM, Thorsten Leemhuis wrote:
>> On 05.07.22 15:51, Wilczynski, Michal wrote:
>>>
>>> Adding Grzegorz Siwik,  since he is working on similar issue and already
>>> has a patch that is being tested/reviewed internally at the moment.
>>>
>>> He can you a send patch tomorrow so you can test if it also fixes your
>>> problem.
>>
>> Tony, Jesse, I have to wonder: why is it taken so long to get this
>> regression fixed? The regression was reported 69 days ago and the first
>> patches to fix this went out 40 days ago. That's far from ideal.
> 
> Our validation found issues when testing the original fix which caused
> the delays as the new issues were being worked out.

Yeah, that happens, still I wish it wouldn't taken *that* much longer
then what's outlined in the docs.

Side note: this and a similar issue I had today made me wonder if we
need a tag to make "this is a regression fix" more obvious to reviewers
and maintainers. But I guess that overblown; should be enough if
developers make it obvious in their cover letter or description that
this fixes a regression.

>> Reminder: this regression ideally should have been fixed within two
>> weeks after the report, as explained here:
>> https://docs.kernel.org/process/handling-regressions.html
>>
>> FWIW, in case anyone wonders: the latest patch-series to fix this can be
>> found here:
>> https://lore.kernel.org/intel-wired-lan/1660310750-290943-1-git-send-email-grzegorz.siwik@intel.com/
> 
> I was going to point you to the newest patches, but you located them.
> Our validation finished testing them yesterday so the pull request for
> these will be going out to netdev today.

Great, many thx.

Ciao, Thorsten

WARNING: multiple messages have this Message-ID (diff)
From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	"Wilczynski, Michal" <michal.wilczynski@intel.com>,
	Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
	"Siwik, Grzegorz" <grzegorz.siwik@intel.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	intel-wired-lan@lists.osuosl.org,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [Intel-wired-lan] ice: Error setting promisc mode on VSI 6 (rc=-17) @ 5.18.x
Date: Wed, 17 Aug 2022 18:07:05 +0200	[thread overview]
Message-ID: <61698d9d-088d-a878-2b23-f5423045c00e@leemhuis.info> (raw)
In-Reply-To: <2151f504-5244-5680-1d70-1fcd8ecd7022@intel.com>

On 17.08.22 17:59, Tony Nguyen wrote:
> On 8/17/2022 2:08 AM, Thorsten Leemhuis wrote:
>> On 05.07.22 15:51, Wilczynski, Michal wrote:
>>>
>>> Adding Grzegorz Siwik,  since he is working on similar issue and already
>>> has a patch that is being tested/reviewed internally at the moment.
>>>
>>> He can you a send patch tomorrow so you can test if it also fixes your
>>> problem.
>>
>> Tony, Jesse, I have to wonder: why is it taken so long to get this
>> regression fixed? The regression was reported 69 days ago and the first
>> patches to fix this went out 40 days ago. That's far from ideal.
> 
> Our validation found issues when testing the original fix which caused
> the delays as the new issues were being worked out.

Yeah, that happens, still I wish it wouldn't taken *that* much longer
then what's outlined in the docs.

Side note: this and a similar issue I had today made me wonder if we
need a tag to make "this is a regression fix" more obvious to reviewers
and maintainers. But I guess that overblown; should be enough if
developers make it obvious in their cover letter or description that
this fixes a regression.

>> Reminder: this regression ideally should have been fixed within two
>> weeks after the report, as explained here:
>> https://docs.kernel.org/process/handling-regressions.html
>>
>> FWIW, in case anyone wonders: the latest patch-series to fix this can be
>> found here:
>> https://lore.kernel.org/intel-wired-lan/1660310750-290943-1-git-send-email-grzegorz.siwik@intel.com/
> 
> I was going to point you to the newest patches, but you located them.
> Our validation finished testing them yesterday so the pull request for
> these will be going out to netdev today.

Great, many thx.

Ciao, Thorsten
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

  reply	other threads:[~2022-08-17 16:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09  6:58 [Intel-wired-lan] ice: Error setting promisc mode on VSI 6 (rc=-17) @ 5.18.x Jaroslav Pulchart
2022-06-18 15:36 ` Jaroslav Pulchart
2022-06-19 11:50 ` Thorsten Leemhuis
2022-06-19 11:50   ` Thorsten Leemhuis
2022-06-19 17:00   ` Jaroslav Pulchart
2022-06-19 17:00     ` Jaroslav Pulchart
2022-07-05  9:43     ` Thorsten Leemhuis
2022-07-05  9:43       ` Thorsten Leemhuis
2022-07-05 13:51       ` Wilczynski, Michal
2022-07-05 13:51         ` Wilczynski, Michal
2022-08-17  9:08         ` Thorsten Leemhuis
2022-08-17  9:08           ` Thorsten Leemhuis
2022-08-17 15:59           ` Tony Nguyen
2022-08-17 15:59             ` Tony Nguyen
2022-08-17 16:07             ` Thorsten Leemhuis [this message]
2022-08-17 16:07               ` Thorsten Leemhuis
2022-08-25 10:20   ` [Intel-wired-lan] ice: Error setting promisc mode on VSI 6 (rc=-17) @ 5.18.x #forregzbot Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61698d9d-088d-a878-2b23-f5423045c00e@leemhuis.info \
    --to=regressions@leemhuis.info \
    --cc=anthony.l.nguyen@intel.com \
    --cc=grzegorz.siwik@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jaroslav.pulchart@gooddata.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.wilczynski@intel.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.