From: Joe Perches <joe@perches.com> To: Dan Williams <dan.j.williams@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Keith Busch <keith.busch@intel.com>, Ira Weiny <ira.weiny@intel.com> Cc: linux-kernel@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>, linux-nvdimm@lists.01.org Subject: [PATCH 03/13] nvdimm: Use octal permissions Date: Wed, 11 Sep 2019 19:54:33 -0700 [thread overview] Message-ID: <93cf2f046486416fbcea19a8194411e3f44fd2d3.1568256706.git.joe@perches.com> (raw) In-Reply-To: <cover.1568256705.git.joe@perches.com> Avoid the use of the S_IRUGO define and use 0444 to improve readability and use a more common kernel style. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/nvdimm/btt.c | 39 ++++++++++++++++++--------------------- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index 6362d96dfc16..9cad4dca6eac 100644 --- a/drivers/nvdimm/btt.c +++ b/drivers/nvdimm/btt.c @@ -229,27 +229,24 @@ static void arena_debugfs_init(struct arena_info *a, struct dentry *parent, return; a->debugfs_dir = d; - debugfs_create_x64("size", S_IRUGO, d, &a->size); - debugfs_create_x64("external_lba_start", S_IRUGO, d, - &a->external_lba_start); - debugfs_create_x32("internal_nlba", S_IRUGO, d, &a->internal_nlba); - debugfs_create_u32("internal_lbasize", S_IRUGO, d, - &a->internal_lbasize); - debugfs_create_x32("external_nlba", S_IRUGO, d, &a->external_nlba); - debugfs_create_u32("external_lbasize", S_IRUGO, d, - &a->external_lbasize); - debugfs_create_u32("nfree", S_IRUGO, d, &a->nfree); - debugfs_create_u16("version_major", S_IRUGO, d, &a->version_major); - debugfs_create_u16("version_minor", S_IRUGO, d, &a->version_minor); - debugfs_create_x64("nextoff", S_IRUGO, d, &a->nextoff); - debugfs_create_x64("infooff", S_IRUGO, d, &a->infooff); - debugfs_create_x64("dataoff", S_IRUGO, d, &a->dataoff); - debugfs_create_x64("mapoff", S_IRUGO, d, &a->mapoff); - debugfs_create_x64("logoff", S_IRUGO, d, &a->logoff); - debugfs_create_x64("info2off", S_IRUGO, d, &a->info2off); - debugfs_create_x32("flags", S_IRUGO, d, &a->flags); - debugfs_create_u32("log_index_0", S_IRUGO, d, &a->log_index[0]); - debugfs_create_u32("log_index_1", S_IRUGO, d, &a->log_index[1]); + debugfs_create_x64("size", 0444, d, &a->size); + debugfs_create_x64("external_lba_start", 0444, d, &a->external_lba_start); + debugfs_create_x32("internal_nlba", 0444, d, &a->internal_nlba); + debugfs_create_u32("internal_lbasize", 0444, d, &a->internal_lbasize); + debugfs_create_x32("external_nlba", 0444, d, &a->external_nlba); + debugfs_create_u32("external_lbasize", 0444, d, &a->external_lbasize); + debugfs_create_u32("nfree", 0444, d, &a->nfree); + debugfs_create_u16("version_major", 0444, d, &a->version_major); + debugfs_create_u16("version_minor", 0444, d, &a->version_minor); + debugfs_create_x64("nextoff", 0444, d, &a->nextoff); + debugfs_create_x64("infooff", 0444, d, &a->infooff); + debugfs_create_x64("dataoff", 0444, d, &a->dataoff); + debugfs_create_x64("mapoff", 0444, d, &a->mapoff); + debugfs_create_x64("logoff", 0444, d, &a->logoff); + debugfs_create_x64("info2off", 0444, d, &a->info2off); + debugfs_create_x32("flags", 0444, d, &a->flags); + debugfs_create_u32("log_index_0", 0444, d, &a->log_index[0]); + debugfs_create_u32("log_index_1", 0444, d, &a->log_index[1]); } static void btt_debugfs_init(struct btt *btt) -- 2.15.0 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Dan Williams <dan.j.williams@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Keith Busch <keith.busch@intel.com>, Ira Weiny <ira.weiny@intel.com> Cc: Dan Carpenter <dan.carpenter@oracle.com>, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/13] nvdimm: Use octal permissions Date: Wed, 11 Sep 2019 19:54:33 -0700 [thread overview] Message-ID: <93cf2f046486416fbcea19a8194411e3f44fd2d3.1568256706.git.joe@perches.com> (raw) In-Reply-To: <cover.1568256705.git.joe@perches.com> Avoid the use of the S_IRUGO define and use 0444 to improve readability and use a more common kernel style. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/nvdimm/btt.c | 39 ++++++++++++++++++--------------------- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index 6362d96dfc16..9cad4dca6eac 100644 --- a/drivers/nvdimm/btt.c +++ b/drivers/nvdimm/btt.c @@ -229,27 +229,24 @@ static void arena_debugfs_init(struct arena_info *a, struct dentry *parent, return; a->debugfs_dir = d; - debugfs_create_x64("size", S_IRUGO, d, &a->size); - debugfs_create_x64("external_lba_start", S_IRUGO, d, - &a->external_lba_start); - debugfs_create_x32("internal_nlba", S_IRUGO, d, &a->internal_nlba); - debugfs_create_u32("internal_lbasize", S_IRUGO, d, - &a->internal_lbasize); - debugfs_create_x32("external_nlba", S_IRUGO, d, &a->external_nlba); - debugfs_create_u32("external_lbasize", S_IRUGO, d, - &a->external_lbasize); - debugfs_create_u32("nfree", S_IRUGO, d, &a->nfree); - debugfs_create_u16("version_major", S_IRUGO, d, &a->version_major); - debugfs_create_u16("version_minor", S_IRUGO, d, &a->version_minor); - debugfs_create_x64("nextoff", S_IRUGO, d, &a->nextoff); - debugfs_create_x64("infooff", S_IRUGO, d, &a->infooff); - debugfs_create_x64("dataoff", S_IRUGO, d, &a->dataoff); - debugfs_create_x64("mapoff", S_IRUGO, d, &a->mapoff); - debugfs_create_x64("logoff", S_IRUGO, d, &a->logoff); - debugfs_create_x64("info2off", S_IRUGO, d, &a->info2off); - debugfs_create_x32("flags", S_IRUGO, d, &a->flags); - debugfs_create_u32("log_index_0", S_IRUGO, d, &a->log_index[0]); - debugfs_create_u32("log_index_1", S_IRUGO, d, &a->log_index[1]); + debugfs_create_x64("size", 0444, d, &a->size); + debugfs_create_x64("external_lba_start", 0444, d, &a->external_lba_start); + debugfs_create_x32("internal_nlba", 0444, d, &a->internal_nlba); + debugfs_create_u32("internal_lbasize", 0444, d, &a->internal_lbasize); + debugfs_create_x32("external_nlba", 0444, d, &a->external_nlba); + debugfs_create_u32("external_lbasize", 0444, d, &a->external_lbasize); + debugfs_create_u32("nfree", 0444, d, &a->nfree); + debugfs_create_u16("version_major", 0444, d, &a->version_major); + debugfs_create_u16("version_minor", 0444, d, &a->version_minor); + debugfs_create_x64("nextoff", 0444, d, &a->nextoff); + debugfs_create_x64("infooff", 0444, d, &a->infooff); + debugfs_create_x64("dataoff", 0444, d, &a->dataoff); + debugfs_create_x64("mapoff", 0444, d, &a->mapoff); + debugfs_create_x64("logoff", 0444, d, &a->logoff); + debugfs_create_x64("info2off", 0444, d, &a->info2off); + debugfs_create_x32("flags", 0444, d, &a->flags); + debugfs_create_u32("log_index_0", 0444, d, &a->log_index[0]); + debugfs_create_u32("log_index_1", 0444, d, &a->log_index[1]); } static void btt_debugfs_init(struct btt *btt) -- 2.15.0
next prev parent reply other threads:[~2019-09-12 2:55 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-12 2:54 [PATCH 00/13] nvdimm: Use more common kernel coding style Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 2:54 ` [PATCH 01/13] nvdimm: Use more typical whitespace Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 12:17 ` Christoph Hellwig 2019-09-12 12:17 ` Christoph Hellwig 2019-09-12 15:01 ` Joe Perches 2019-09-12 15:01 ` Joe Perches 2019-09-16 7:07 ` Christoph Hellwig 2019-09-16 7:07 ` Christoph Hellwig 2019-09-12 2:54 ` [PATCH 02/13] nvdimm: Move logical continuations to previous line Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 2:54 ` Joe Perches [this message] 2019-09-12 2:54 ` [PATCH 03/13] nvdimm: Use octal permissions Joe Perches 2019-09-12 2:54 ` [PATCH 04/13] nvdimm: Use a more common kernel spacing style Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 2:54 ` [PATCH 05/13] nvdimm: Use "unsigned int" in preference to "unsigned" Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 2:54 ` [PATCH 06/13] nvdimm: Add and remove blank lines Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 2:54 ` [PATCH 07/13] nvdimm: Use typical kernel brace styles Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 2:54 ` [PATCH 08/13] nvdimm: Use typical kernel style indentation Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 2:54 ` [PATCH 09/13] nvdimm: btt.h: Neaten #defines to improve readability Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 2:54 ` [PATCH 10/13] nvdimm: namespace_devs: Move assignment operators Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 2:54 ` [PATCH 11/13] nvdimm: Use more common logic testing styles and bare ; positions Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 3:52 ` Verma, Vishal L 2019-09-12 3:52 ` Verma, Vishal L 2019-09-12 2:54 ` [PATCH 12/13] nvdimm: namespace_devs: Change progess typo to progress Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 2:54 ` [PATCH 13/13] nvdimm: Miscellaneous neatening Joe Perches 2019-09-12 2:54 ` Joe Perches 2019-09-12 8:00 ` [PATCH 00/13] nvdimm: Use more common kernel coding style Dan Williams 2019-09-12 8:00 ` Dan Williams 2019-09-12 8:15 ` Joe Perches 2019-09-12 8:15 ` Joe Perches 2019-09-12 8:42 ` Miguel Ojeda 2019-09-12 8:42 ` Miguel Ojeda 2019-09-12 14:00 ` Jeff Moyer 2019-09-12 14:00 ` Jeff Moyer 2019-09-12 14:06 ` Johannes Thumshirn 2019-09-12 14:06 ` Johannes Thumshirn 2019-09-12 14:35 ` Dan Williams 2019-09-12 14:35 ` Dan Williams 2019-09-12 14:21 ` Miguel Ojeda 2019-09-12 14:21 ` Miguel Ojeda 2019-09-12 21:08 ` Joe Perches 2019-09-12 21:08 ` Joe Perches 2019-09-12 21:58 ` Miguel Ojeda 2019-09-12 21:58 ` Miguel Ojeda 2019-09-12 22:15 ` Joe Perches 2019-09-12 22:15 ` Joe Perches 2019-09-12 22:38 ` Joe Perches 2019-09-12 22:38 ` Joe Perches 2019-09-12 23:00 ` Nick Desaulniers 2019-09-12 23:00 ` Nick Desaulniers 2019-09-12 23:07 ` Joe Perches 2019-09-12 23:07 ` Joe Perches 2019-09-12 22:58 ` Nick Desaulniers 2019-09-12 22:58 ` Nick Desaulniers 2019-09-12 23:26 ` clang-format and 'clang-format on' and 'clang-format off' Joe Perches 2019-09-12 23:26 ` Joe Perches 2019-09-15 18:25 ` Miguel Ojeda 2019-09-15 18:25 ` Miguel Ojeda
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=93cf2f046486416fbcea19a8194411e3f44fd2d3.1568256706.git.joe@perches.com \ --to=joe@perches.com \ --cc=dan.carpenter@oracle.com \ --cc=dan.j.williams@intel.com \ --cc=dave.jiang@intel.com \ --cc=ira.weiny@intel.com \ --cc=keith.busch@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=vishal.l.verma@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.