From: Len Brown <lenb@kernel.org>
To: Bob Copeland <me@bobcopeland.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Lin Ming <ming.m.lin@intel.com>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
yakui_zhao <yakui.zhao@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Moore, Robert" <robert.moore@intel.com>
Subject: [PATCH] ACPI: resume: re-enable SCI-enable workaround
Date: Fri, 15 May 2009 22:34:15 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0905152233180.4571@localhost.localdomain> (raw)
In-Reply-To: <b6c5339f0905130830k3549095dv3eee08d7d3155a37@mail.gmail.com>
From: Lin Ming <ming.m.lin@intel.com>
The BIOS bug workaround mistakenly got disabled
when we followed the ACPI specification more closely
by ignoring OS updates to that bit.
(The BIOS is supposed to update SCI_EN, not the OS)
http://bugzilla.kernel.org/show_bug.cgi?id=13289
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
as-applied.
thanks,
-Len
drivers/acpi/acpica/aclocal.h | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/acpica/aclocal.h b/drivers/acpi/acpica/aclocal.h
index 772ee5c..2ec394a 100644
--- a/drivers/acpi/acpica/aclocal.h
+++ b/drivers/acpi/acpica/aclocal.h
@@ -787,7 +787,12 @@ struct acpi_bit_register_info {
/* For control registers, both ignored and reserved bits must be preserved */
-#define ACPI_PM1_CONTROL_IGNORED_BITS 0x0201 /* Bits 9, 0(SCI_EN) */
+/*
+ * The ACPI spec says to ignore PM1_CTL.SCI_EN (bit 0)
+ * but we need to be able to write ACPI_BITREG_SCI_ENABLE directly
+ * as a BIOS workaround on some machines.
+ */
+#define ACPI_PM1_CONTROL_IGNORED_BITS 0x0200 /* Bits 9 */
#define ACPI_PM1_CONTROL_RESERVED_BITS 0xC1F8 /* Bits 14-15, 3-8 */
#define ACPI_PM1_CONTROL_PRESERVED_BITS \
(ACPI_PM1_CONTROL_IGNORED_BITS | ACPI_PM1_CONTROL_RESERVED_BITS)
--
1.6.3.1.9.g95405b
next prev parent reply other threads:[~2009-05-16 2:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 10:58 acpi/suspend - irq 9: nobody cared Bob Copeland
2009-05-08 1:53 ` yakui_zhao
2009-05-12 19:01 ` Bjorn Helgaas
2009-05-12 19:26 ` Bob Copeland
2009-05-12 19:26 ` Bob Copeland
2009-05-13 4:05 ` [BISECTED] Was " Bob Copeland
[not found] ` <d3f22a0905122245h15786220g31ad0dcb8caa3a38@mail.gmail.com>
2009-05-13 5:36 ` Lin Ming
2009-05-13 8:15 ` Rafael J. Wysocki
2009-05-13 15:30 ` Bob Copeland
2009-05-13 15:30 ` Bob Copeland
2009-05-16 2:34 ` Len Brown [this message]
2009-05-16 3:30 ` [PATCH] ACPI: resume: re-enable SCI-enable workaround Moore, Robert
2009-05-16 5:49 ` Len Brown
2009-05-16 6:50 ` Moore, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0905152233180.4571@localhost.localdomain \
--to=lenb@kernel.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.