RadioTap Archive on lore.kernel.org
 help / color / Atom feed
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org
Subject: [RFA] HE support
Date: Tue, 30 Jan 2018 09:25:19 +0100
Message-ID: <1517300719.2189.51.camel@sipsolutions.net> (raw)

Hi,

It looks like the spec etc. has matured sufficiently to standardise the
radiotap for HE. Richard Sharpe has also contributed an implementation
for wireshark, and we have an implementation for our driver to report
(a subset of) the information.

Rather than copy/paste all the information into the email, here are the
links to the three newly defined fields.
http://www.radiotap.org/fields/HE
http://www.radiotap.org/fields/HE-MU
http://www.radiotap.org/fields/HE-MU-other-user

I just made a minor change here to delete the duplicated field, and add
an RU offset field (with known flag, of course).

Our implementation for Linux is in this tree:

https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/backport-iwlwifi.git/

related commits:
17df37ef01e234f06458ba6a8ca35303a4323db0
9dadcd648cb0e4dd64fb0df87257bbf1abeb5c19
a3e502d6096bb2b82550027324084c17602b56cd
a76d55a9481e2c7136bf72a4c7682048a0331aef
edb94a27eac211e0dd66920919895d7a27539d32
e374d21c07c23d391c913cc3a61f728df4089253

fdea7e21cd1a743232b70c370b1bb1199d487598
fabf74cdf60527eb2d5f76362fd40ba135853aa3
a10e644921c2d6b5ced56bb44fa2ff312ffae982
5126862ce3cea626fb0f9b4918e8b5d77803f6ba

(but you can just look at the code in net/mac80211/rx.c and
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c)

We'll bring that upstream once radiotap is adopted.

Richard Sharpe's wireshark code is even partially merged already, see
here:
https://code.wireshark.org/review/#/c/25479/
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=731a901a3e25839ef3e0d89a0a21edc69ae474df
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f6571913b74c251abb45d2fec8c66f3c7cbe36d
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8d6202df4559d144bc8edc6fdf4bfa6112fe746f


So let's also start 3 weeks commenting period for this, I think whoever
is interested probably already saw it anyway :-)

johannes

             reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30  8:25 Johannes Berg [this message]
     [not found] ` <1517300719.2189.51.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-02-20  9:37   ` Johannes Berg
     [not found]     ` <1519119420.16723.26.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-02-20 13:01       ` Johannes Berg
     [not found]         ` <1519131691.16723.35.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-02-20 14:59           ` Richard Sharpe
     [not found]             ` <CACyXjPxQLN3iiCjVu5X5ZQUMGBEY9FyM9dnPmEiT7XQnaUhjEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-20 15:06               ` Johannes Berg
2018-02-20 16:05       ` Richard Sharpe
2018-02-20 16:42   ` Johannes Berg
     [not found]     ` <1519144938.16723.42.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-02-22 11:13       ` Johannes Berg
2018-04-12  9:35   ` Johannes Berg
     [not found]     ` <1523525707.12930.6.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-04-12  9:54       ` Guy Harris
     [not found]         ` <9FE36B35-5238-436D-9B5A-342C92D20701-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2018-04-12  9:55           ` Johannes Berg
     [not found]             ` <1523526947.12930.8.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-04-12 13:56               ` Richard Sharpe

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517300719.2189.51.camel@sipsolutions.net \
    --to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
    --cc=radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

RadioTap Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/radiotap/0 radiotap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 radiotap radiotap/ https://lore.kernel.org/radiotap \
		radiotap@radiotap.org
	public-inbox-index radiotap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.netbsd.radiotap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git