* Re: [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable [not found] <20210630140802.39138-1-fishland@aliyun.com> @ 2021-06-30 18:57 ` Uladzislau Rezki 2021-07-01 14:54 ` Neeraj Upadhyay 1 sibling, 0 replies; 8+ messages in thread From: Uladzislau Rezki @ 2021-06-30 18:57 UTC (permalink / raw) To: Liu Song, paulmck; +Cc: paulmck, liu.song11, rcu On Wed, Jun 30, 2021 at 10:08:02PM +0800, Liu Song wrote: > From: Liu Song <liu.song11@zte.com.cn> > > In rcu, most codes have used per_cpu_ptr to obtain per_cpu variable > pointers. This patch adjusts a few codes that have not done so. > > Signed-off-by: Liu Song <liu.song11@zte.com.cn> > --- > kernel/rcu/tasks.h | 2 +- > kernel/rcu/tree.c | 4 ++-- > kernel/rcu/tree_stall.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h > index 350ebf5051f9..0275217cb6e4 100644 > --- a/kernel/rcu/tasks.h > +++ b/kernel/rcu/tasks.h > @@ -875,7 +875,7 @@ static void trc_read_check_handler(void *t_in) > // Allow future IPIs to be sent on CPU and for task. > // Also order this IPI handler against any later manipulations of > // the intended task. > - smp_store_release(&per_cpu(trc_ipi_to_cpu, smp_processor_id()), false); // ^^^ > + smp_store_release(per_cpu_ptr(&trc_ipi_to_cpu, smp_processor_id()), false); // ^^^ > smp_store_release(&texp->trc_ipi_to_cpu, -1); // ^^^ > } > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index 8e78b2430c16..5cab8e39a731 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -399,7 +399,7 @@ bool rcu_eqs_special_set(int cpu) > int old; > int new; > int new_old; > - struct rcu_data *rdp = &per_cpu(rcu_data, cpu); > + struct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu); > > new_old = atomic_read(&rdp->dynticks); > do { > @@ -1333,7 +1333,7 @@ static int rcu_implicit_dynticks_qs(struct rcu_data *rdp) > */ > jtsq = READ_ONCE(jiffies_to_sched_qs); > ruqp = per_cpu_ptr(&rcu_data.rcu_urgent_qs, rdp->cpu); > - rnhqp = &per_cpu(rcu_data.rcu_need_heavy_qs, rdp->cpu); > + rnhqp = per_cpu_ptr(&rcu_data.rcu_need_heavy_qs, rdp->cpu); > if (!READ_ONCE(*rnhqp) && > (time_after(jiffies, rcu_state.gp_start + jtsq * 2) || > time_after(jiffies, rcu_state.jiffies_resched) || > diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h > index 59b95cc5cbdf..990fdb793d57 100644 > --- a/kernel/rcu/tree_stall.h > +++ b/kernel/rcu/tree_stall.h > @@ -349,7 +349,7 @@ static void rcu_dump_cpu_stacks(void) > > static void print_cpu_stall_fast_no_hz(char *cp, int cpu) > { > - struct rcu_data *rdp = &per_cpu(rcu_data, cpu); > + struct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu); > > sprintf(cp, "last_accelerate: %04lx/%04lx dyntick_enabled: %d", > rdp->last_accelerate & 0xffff, jiffies & 0xffff, > -- > 2.20.1 > To me it looks OK. Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com> -- Vlad Rezki ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable [not found] <20210630140802.39138-1-fishland@aliyun.com> 2021-06-30 18:57 ` [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable Uladzislau Rezki @ 2021-07-01 14:54 ` Neeraj Upadhyay 2021-07-01 16:31 ` Paul E. McKenney 1 sibling, 1 reply; 8+ messages in thread From: Neeraj Upadhyay @ 2021-07-01 14:54 UTC (permalink / raw) To: Liu Song, paulmck; +Cc: liu.song11, rcu On 6/30/2021 7:38 PM, Liu Song wrote: > From: Liu Song <liu.song11@zte.com.cn> > > In rcu, most codes have used per_cpu_ptr to obtain per_cpu variable > pointers. This patch adjusts a few codes that have not done so. > Minor: Can we also add below statement? "This patch doesn't introduce any functional change." > Signed-off-by: Liu Song <liu.song11@zte.com.cn> > --- > kernel/rcu/tasks.h | 2 +- > kernel/rcu/tree.c | 4 ++-- > kernel/rcu/tree_stall.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h > index 350ebf5051f9..0275217cb6e4 100644 > --- a/kernel/rcu/tasks.h > +++ b/kernel/rcu/tasks.h > @@ -875,7 +875,7 @@ static void trc_read_check_handler(void *t_in) > // Allow future IPIs to be sent on CPU and for task. > // Also order this IPI handler against any later manipulations of > // the intended task. > - smp_store_release(&per_cpu(trc_ipi_to_cpu, smp_processor_id()), false); // ^^^ > + smp_store_release(per_cpu_ptr(&trc_ipi_to_cpu, smp_processor_id()), false); // ^^^ > smp_store_release(&texp->trc_ipi_to_cpu, -1); // ^^^ > } > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index 8e78b2430c16..5cab8e39a731 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -399,7 +399,7 @@ bool rcu_eqs_special_set(int cpu) > int old; > int new; > int new_old; > - struct rcu_data *rdp = &per_cpu(rcu_data, cpu); > + struct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu); rcu_eqs_special_set() does not exist in rcu dev branch [1]; so this might need rebase. [1] https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/tree/kernel/rcu/tree.c?h=dev > > new_old = atomic_read(&rdp->dynticks); > do { > @@ -1333,7 +1333,7 @@ static int rcu_implicit_dynticks_qs(struct rcu_data *rdp) > */ > jtsq = READ_ONCE(jiffies_to_sched_qs); > ruqp = per_cpu_ptr(&rcu_data.rcu_urgent_qs, rdp->cpu); > - rnhqp = &per_cpu(rcu_data.rcu_need_heavy_qs, rdp->cpu); > + rnhqp = per_cpu_ptr(&rcu_data.rcu_need_heavy_qs, rdp->cpu); > if (!READ_ONCE(*rnhqp) && > (time_after(jiffies, rcu_state.gp_start + jtsq * 2) || > time_after(jiffies, rcu_state.jiffies_resched) || > diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h > index 59b95cc5cbdf..990fdb793d57 100644 > --- a/kernel/rcu/tree_stall.h > +++ b/kernel/rcu/tree_stall.h > @@ -349,7 +349,7 @@ static void rcu_dump_cpu_stacks(void) > > static void print_cpu_stall_fast_no_hz(char *cp, int cpu) > { > - struct rcu_data *rdp = &per_cpu(rcu_data, cpu); > + struct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu); > > sprintf(cp, "last_accelerate: %04lx/%04lx dyntick_enabled: %d", > rdp->last_accelerate & 0xffff, jiffies & 0xffff, > Reviewed-by: Neeraj Upadhyay <neeraju@codeaurora.org> Thanks Neeraj -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable 2021-07-01 14:54 ` Neeraj Upadhyay @ 2021-07-01 16:31 ` Paul E. McKenney 2021-07-01 17:05 ` Neeraj Upadhyay 0 siblings, 1 reply; 8+ messages in thread From: Paul E. McKenney @ 2021-07-01 16:31 UTC (permalink / raw) To: Neeraj Upadhyay; +Cc: Liu Song, liu.song11, rcu On Thu, Jul 01, 2021 at 08:24:32PM +0530, Neeraj Upadhyay wrote: > > > On 6/30/2021 7:38 PM, Liu Song wrote: > > From: Liu Song <liu.song11@zte.com.cn> > > > > In rcu, most codes have used per_cpu_ptr to obtain per_cpu variable > > pointers. This patch adjusts a few codes that have not done so. > > > > Minor: Can we also add below statement? > "This patch doesn't introduce any functional change." > > > Signed-off-by: Liu Song <liu.song11@zte.com.cn> Applied with the usual wordsmithing, including adding words to this effect, so thank you all! I removed the obsolete chunk that Neeraj pointed out as well. Please take a look and check to see if all is well. Thanx, Paul ------------------------------------------------------------------------ commit 9a6b5a10785f4d9b4f073736e6648fa3851882bd Author: Liu Song <liu.song11@zte.com.cn> Date: Wed Jun 30 22:08:02 2021 +0800 rcu: Use per_cpu_ptr to get the pointer of per_cpu variable There are a few remaining locations in kernel/rcu that still use "&per_cpu()". This commit replaces them with "per_cpu_ptr(&)", and does not introduce any functional change.. Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com> Reviewed-by: Neeraj Upadhyay <neeraju@codeaurora.org> Signed-off-by: Liu Song <liu.song11@zte.com.cn> Signed-off-by: Paul E. McKenney <paulmck@kernel.org> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index f9f52daacd1c..806160c44b17 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -923,7 +923,7 @@ static void trc_read_check_handler(void *t_in) // Allow future IPIs to be sent on CPU and for task. // Also order this IPI handler against any later manipulations of // the intended task. - smp_store_release(&per_cpu(trc_ipi_to_cpu, smp_processor_id()), false); // ^^^ + smp_store_release(per_cpu_ptr(&trc_ipi_to_cpu, smp_processor_id()), false); // ^^^ smp_store_release(&texp->trc_ipi_to_cpu, -1); // ^^^ } diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index a627a200a5ae..f42b98af3ed3 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -1290,7 +1290,7 @@ static int rcu_implicit_dynticks_qs(struct rcu_data *rdp) */ jtsq = READ_ONCE(jiffies_to_sched_qs); ruqp = per_cpu_ptr(&rcu_data.rcu_urgent_qs, rdp->cpu); - rnhqp = &per_cpu(rcu_data.rcu_need_heavy_qs, rdp->cpu); + rnhqp = per_cpu_ptr(&rcu_data.rcu_need_heavy_qs, rdp->cpu); if (!READ_ONCE(*rnhqp) && (time_after(jiffies, rcu_state.gp_start + jtsq * 2) || time_after(jiffies, rcu_state.jiffies_resched) || diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h index a8d0fcf0826f..677ee3d8671b 100644 --- a/kernel/rcu/tree_stall.h +++ b/kernel/rcu/tree_stall.h @@ -351,7 +351,7 @@ static void rcu_dump_cpu_stacks(void) static void print_cpu_stall_fast_no_hz(char *cp, int cpu) { - struct rcu_data *rdp = &per_cpu(rcu_data, cpu); + struct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu); sprintf(cp, "last_accelerate: %04lx/%04lx dyntick_enabled: %d", rdp->last_accelerate & 0xffff, jiffies & 0xffff, ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable 2021-07-01 16:31 ` Paul E. McKenney @ 2021-07-01 17:05 ` Neeraj Upadhyay 2021-07-01 18:39 ` Uladzislau Rezki 0 siblings, 1 reply; 8+ messages in thread From: Neeraj Upadhyay @ 2021-07-01 17:05 UTC (permalink / raw) To: paulmck; +Cc: Liu Song, liu.song11, rcu On 7/1/2021 10:01 PM, Paul E. McKenney wrote: > On Thu, Jul 01, 2021 at 08:24:32PM +0530, Neeraj Upadhyay wrote: >> >> >> On 6/30/2021 7:38 PM, Liu Song wrote: >>> From: Liu Song <liu.song11@zte.com.cn> >>> >>> In rcu, most codes have used per_cpu_ptr to obtain per_cpu variable >>> pointers. This patch adjusts a few codes that have not done so. >>> >> >> Minor: Can we also add below statement? >> "This patch doesn't introduce any functional change." >> >>> Signed-off-by: Liu Song <liu.song11@zte.com.cn> > > Applied with the usual wordsmithing, including adding words to this > effect, so thank you all! I removed the obsolete chunk that Neeraj > pointed out as well. > > Please take a look and check to see if all is well. > Looks good to me Thanks Neeraj > Thanx, Paul > > ------------------------------------------------------------------------ > > commit 9a6b5a10785f4d9b4f073736e6648fa3851882bd > Author: Liu Song <liu.song11@zte.com.cn> > Date: Wed Jun 30 22:08:02 2021 +0800 > > rcu: Use per_cpu_ptr to get the pointer of per_cpu variable > > There are a few remaining locations in kernel/rcu that still use > "&per_cpu()". This commit replaces them with "per_cpu_ptr(&)", and does > not introduce any functional change.. > > Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com> > Reviewed-by: Neeraj Upadhyay <neeraju@codeaurora.org> > Signed-off-by: Liu Song <liu.song11@zte.com.cn> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > > diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h > index f9f52daacd1c..806160c44b17 100644 > --- a/kernel/rcu/tasks.h > +++ b/kernel/rcu/tasks.h > @@ -923,7 +923,7 @@ static void trc_read_check_handler(void *t_in) > // Allow future IPIs to be sent on CPU and for task. > // Also order this IPI handler against any later manipulations of > // the intended task. > - smp_store_release(&per_cpu(trc_ipi_to_cpu, smp_processor_id()), false); // ^^^ > + smp_store_release(per_cpu_ptr(&trc_ipi_to_cpu, smp_processor_id()), false); // ^^^ > smp_store_release(&texp->trc_ipi_to_cpu, -1); // ^^^ > } > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index a627a200a5ae..f42b98af3ed3 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -1290,7 +1290,7 @@ static int rcu_implicit_dynticks_qs(struct rcu_data *rdp) > */ > jtsq = READ_ONCE(jiffies_to_sched_qs); > ruqp = per_cpu_ptr(&rcu_data.rcu_urgent_qs, rdp->cpu); > - rnhqp = &per_cpu(rcu_data.rcu_need_heavy_qs, rdp->cpu); > + rnhqp = per_cpu_ptr(&rcu_data.rcu_need_heavy_qs, rdp->cpu); > if (!READ_ONCE(*rnhqp) && > (time_after(jiffies, rcu_state.gp_start + jtsq * 2) || > time_after(jiffies, rcu_state.jiffies_resched) || > diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h > index a8d0fcf0826f..677ee3d8671b 100644 > --- a/kernel/rcu/tree_stall.h > +++ b/kernel/rcu/tree_stall.h > @@ -351,7 +351,7 @@ static void rcu_dump_cpu_stacks(void) > > static void print_cpu_stall_fast_no_hz(char *cp, int cpu) > { > - struct rcu_data *rdp = &per_cpu(rcu_data, cpu); > + struct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu); > > sprintf(cp, "last_accelerate: %04lx/%04lx dyntick_enabled: %d", > rdp->last_accelerate & 0xffff, jiffies & 0xffff, > -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable 2021-07-01 17:05 ` Neeraj Upadhyay @ 2021-07-01 18:39 ` Uladzislau Rezki 2021-07-01 19:57 ` Paul E. McKenney 0 siblings, 1 reply; 8+ messages in thread From: Uladzislau Rezki @ 2021-07-01 18:39 UTC (permalink / raw) To: Neeraj Upadhyay, paulmck; +Cc: paulmck, Liu Song, liu.song11, rcu On Thu, Jul 01, 2021 at 10:35:43PM +0530, Neeraj Upadhyay wrote: > > > On 7/1/2021 10:01 PM, Paul E. McKenney wrote: > > On Thu, Jul 01, 2021 at 08:24:32PM +0530, Neeraj Upadhyay wrote: > > > > > > > > > On 6/30/2021 7:38 PM, Liu Song wrote: > > > > From: Liu Song <liu.song11@zte.com.cn> > > > > > > > > In rcu, most codes have used per_cpu_ptr to obtain per_cpu variable > > > > pointers. This patch adjusts a few codes that have not done so. > > > > > > > > > > Minor: Can we also add below statement? > > > "This patch doesn't introduce any functional change." > > > > > > > Signed-off-by: Liu Song <liu.song11@zte.com.cn> > > > > Applied with the usual wordsmithing, including adding words to this > > effect, so thank you all! I removed the obsolete chunk that Neeraj > > pointed out as well. > > > > Please take a look and check to see if all is well. > > > > Looks good to me > Same to me. Looks good. There are two dots though in the commit message: "change.." :) -- Vlad Rezki ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable 2021-07-01 18:39 ` Uladzislau Rezki @ 2021-07-01 19:57 ` Paul E. McKenney 2021-07-01 20:03 ` Joel Fernandes 0 siblings, 1 reply; 8+ messages in thread From: Paul E. McKenney @ 2021-07-01 19:57 UTC (permalink / raw) To: Uladzislau Rezki; +Cc: Neeraj Upadhyay, Liu Song, liu.song11, rcu On Thu, Jul 01, 2021 at 08:39:33PM +0200, Uladzislau Rezki wrote: > On Thu, Jul 01, 2021 at 10:35:43PM +0530, Neeraj Upadhyay wrote: > > > > > > On 7/1/2021 10:01 PM, Paul E. McKenney wrote: > > > On Thu, Jul 01, 2021 at 08:24:32PM +0530, Neeraj Upadhyay wrote: > > > > > > > > > > > > On 6/30/2021 7:38 PM, Liu Song wrote: > > > > > From: Liu Song <liu.song11@zte.com.cn> > > > > > > > > > > In rcu, most codes have used per_cpu_ptr to obtain per_cpu variable > > > > > pointers. This patch adjusts a few codes that have not done so. > > > > > > > > > > > > > Minor: Can we also add below statement? > > > > "This patch doesn't introduce any functional change." > > > > > > > > > Signed-off-by: Liu Song <liu.song11@zte.com.cn> > > > > > > Applied with the usual wordsmithing, including adding words to this > > > effect, so thank you all! I removed the obsolete chunk that Neeraj > > > pointed out as well. > > > > > > Please take a look and check to see if all is well. > > > > > > > Looks good to me > > > Same to me. Looks good. > > There are two dots though in the commit message: "change.." :) Good eyes, fixed, thank you! Thanx, Paul ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable 2021-07-01 19:57 ` Paul E. McKenney @ 2021-07-01 20:03 ` Joel Fernandes 2021-07-01 23:47 ` Paul E. McKenney 0 siblings, 1 reply; 8+ messages in thread From: Joel Fernandes @ 2021-07-01 20:03 UTC (permalink / raw) To: Paul E. McKenney Cc: Uladzislau Rezki, Neeraj Upadhyay, Liu Song, liu.song11, rcu On Thu, Jul 1, 2021 at 3:57 PM Paul E. McKenney <paulmck@kernel.org> wrote: > > On Thu, Jul 01, 2021 at 08:39:33PM +0200, Uladzislau Rezki wrote: > > On Thu, Jul 01, 2021 at 10:35:43PM +0530, Neeraj Upadhyay wrote: > > > > > > > > > On 7/1/2021 10:01 PM, Paul E. McKenney wrote: > > > > On Thu, Jul 01, 2021 at 08:24:32PM +0530, Neeraj Upadhyay wrote: > > > > > > > > > > > > > > > On 6/30/2021 7:38 PM, Liu Song wrote: > > > > > > From: Liu Song <liu.song11@zte.com.cn> > > > > > > > > > > > > In rcu, most codes have used per_cpu_ptr to obtain per_cpu variable > > > > > > pointers. This patch adjusts a few codes that have not done so. > > > > > > > > > > > > > > > > Minor: Can we also add below statement? > > > > > "This patch doesn't introduce any functional change." > > > > > > > > > > > Signed-off-by: Liu Song <liu.song11@zte.com.cn> > > > > > > > > Applied with the usual wordsmithing, including adding words to this > > > > effect, so thank you all! I removed the obsolete chunk that Neeraj > > > > pointed out as well. > > > > > > > > Please take a look and check to see if all is well. > > > > > > > > > > Looks good to me > > > > > Same to me. Looks good. > > > > There are two dots though in the commit message: "change.." :) > > Good eyes, fixed, thank you! LGTM as well, thanks! Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable 2021-07-01 20:03 ` Joel Fernandes @ 2021-07-01 23:47 ` Paul E. McKenney 0 siblings, 0 replies; 8+ messages in thread From: Paul E. McKenney @ 2021-07-01 23:47 UTC (permalink / raw) To: Joel Fernandes Cc: Uladzislau Rezki, Neeraj Upadhyay, Liu Song, liu.song11, rcu On Thu, Jul 01, 2021 at 04:03:58PM -0400, Joel Fernandes wrote: > On Thu, Jul 1, 2021 at 3:57 PM Paul E. McKenney <paulmck@kernel.org> wrote: > > > > On Thu, Jul 01, 2021 at 08:39:33PM +0200, Uladzislau Rezki wrote: > > > On Thu, Jul 01, 2021 at 10:35:43PM +0530, Neeraj Upadhyay wrote: > > > > > > > > > > > > On 7/1/2021 10:01 PM, Paul E. McKenney wrote: > > > > > On Thu, Jul 01, 2021 at 08:24:32PM +0530, Neeraj Upadhyay wrote: > > > > > > > > > > > > > > > > > > On 6/30/2021 7:38 PM, Liu Song wrote: > > > > > > > From: Liu Song <liu.song11@zte.com.cn> > > > > > > > > > > > > > > In rcu, most codes have used per_cpu_ptr to obtain per_cpu variable > > > > > > > pointers. This patch adjusts a few codes that have not done so. > > > > > > > > > > > > > > > > > > > Minor: Can we also add below statement? > > > > > > "This patch doesn't introduce any functional change." > > > > > > > > > > > > > Signed-off-by: Liu Song <liu.song11@zte.com.cn> > > > > > > > > > > Applied with the usual wordsmithing, including adding words to this > > > > > effect, so thank you all! I removed the obsolete chunk that Neeraj > > > > > pointed out as well. > > > > > > > > > > Please take a look and check to see if all is well. > > > > > > > > > > > > > Looks good to me > > > > > > > Same to me. Looks good. > > > > > > There are two dots though in the commit message: "change.." :) > > > > Good eyes, fixed, thank you! > > LGTM as well, thanks! > Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org> And one more. ;-) Again, thank you all! Thanx, Paul ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-07-01 23:47 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210630140802.39138-1-fishland@aliyun.com>
2021-06-30 18:57 ` [PATCH] rcu: Use per_cpu_ptr to get the pointer of per_cpu variable Uladzislau Rezki
2021-07-01 14:54 ` Neeraj Upadhyay
2021-07-01 16:31 ` Paul E. McKenney
2021-07-01 17:05 ` Neeraj Upadhyay
2021-07-01 18:39 ` Uladzislau Rezki
2021-07-01 19:57 ` Paul E. McKenney
2021-07-01 20:03 ` Joel Fernandes
2021-07-01 23:47 ` Paul E. McKenney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).