Re: [PATCH][SMB3] fix multiuser mount regression #forregzbot

Re: [PATCH][SMB3] fix multiuser mount regression #forregzbot

[Thorsten Leemhuis]

TWIMC: this mail is primarily send for documentation purposes and for
regzbot, my Linux kernel regression tracking bot. These mails usually
contain '#forregzbot' in the subject, to make them easy to spot and filter.

Seems below regression soon will be getting fixed, but with the nearing
final I want to have this in the tracking to make sure everyone is aware
of it:

#regzbot ^introduced 73f9bfbe3d81
#regzbot title cifs: smb3: incorrect session setup check for multiuser
mounts
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I'm getting a lot of
reports on my table. I can only look briefly into most of them and lack
knowledge about most of the areas they concern. I thus unfortunately
will sometimes get things wrong or miss something important. I hope
that's not the case here; if you think it is, don't hesitate to tell me
in a public reply, it's in everyone's interest to set the public record
straight.



On 17.03.22 04:20, Steve French wrote:
> cifssmb3: fix incorrect session setup check for multiuser mounts
> 
> A recent change to how the SMB3 server (socket) and session status
> is managed regressed multiuser mounts by changing the check
> for whether session setup is needed to the socket (TCP_Server_info)
> structure instead of the session struct (cifs_ses). Add additional
> check in cifs_setup_sesion to fix this.
> 
> Fixes: 73f9bfbe3d81 ("cifs: maintain a state machine for tcp/smb/tcon sessions")
> Reported-by: Ronnie Sahlberg <lsahlber@redhat.com>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
>  fs/cifs/connect.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 053cb449eb16..d3020abfe404 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -3924,7 +3924,8 @@ cifs_setup_session(const unsigned int xid,
> struct cifs_ses *ses,
> 
>   /* only send once per connect */
>   spin_lock(&cifs_tcp_ses_lock);
> - if (server->tcpStatus != CifsNeedSessSetup) {
> + if ((server->tcpStatus != CifsNeedSessSetup) &&
> +     (ses->status == CifsGood)) {
>   spin_unlock(&cifs_tcp_ses_lock);
>   return 0;
>   }
> 

Re: [PATCH][SMB3] fix multiuser mount regression #forregzbot

[Thorsten Leemhuis]

On 18.03.22 15:41, Thorsten Leemhuis wrote:
> TWIMC: this mail is primarily send for documentation purposes and for
> regzbot, my Linux kernel regression tracking bot. These mails usually
> contain '#forregzbot' in the subject, to make them easy to spot and filter.

#regzbot fixed-by: e3ee9fb22652f228

> Seems below regression soon will be getting fixed, but with the nearing
> final I want to have this in the tracking to make sure everyone is aware
> of it:
> 
> #regzbot ^introduced 73f9bfbe3d81
> #regzbot title cifs: smb3: incorrect session setup check for multiuser
> mounts
> #regzbot ignore-activity
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> 
> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> reports on my table. I can only look briefly into most of them and lack
> knowledge about most of the areas they concern. I thus unfortunately
> will sometimes get things wrong or miss something important. I hope
> that's not the case here; if you think it is, don't hesitate to tell me
> in a public reply, it's in everyone's interest to set the public record
> straight.
> 
> 
> 
> On 17.03.22 04:20, Steve French wrote:
>> cifssmb3: fix incorrect session setup check for multiuser mounts
>>
>> A recent change to how the SMB3 server (socket) and session status
>> is managed regressed multiuser mounts by changing the check
>> for whether session setup is needed to the socket (TCP_Server_info)
>> structure instead of the session struct (cifs_ses). Add additional
>> check in cifs_setup_sesion to fix this.
>>
>> Fixes: 73f9bfbe3d81 ("cifs: maintain a state machine for tcp/smb/tcon sessions")
>> Reported-by: Ronnie Sahlberg <lsahlber@redhat.com>
>> Signed-off-by: Steve French <stfrench@microsoft.com>
>> ---
>>  fs/cifs/connect.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
>> index 053cb449eb16..d3020abfe404 100644
>> --- a/fs/cifs/connect.c
>> +++ b/fs/cifs/connect.c
>> @@ -3924,7 +3924,8 @@ cifs_setup_session(const unsigned int xid,
>> struct cifs_ses *ses,
>>
>>   /* only send once per connect */
>>   spin_lock(&cifs_tcp_ses_lock);
>> - if (server->tcpStatus != CifsNeedSessSetup) {
>> + if ((server->tcpStatus != CifsNeedSessSetup) &&
>> +     (ses->status == CifsGood)) {
>>   spin_unlock(&cifs_tcp_ses_lock);
>>   return 0;
>>   }
>>