* Re: [PATCH net] bgmac: fix *initial* chip reset to support BCM5358 [not found] ` <b7b11a57-9512-cda9-1b15-5dd5aa12f162@gmail.com> @ 2023-04-14 14:04 ` Linux regression tracking (Thorsten Leemhuis) 2023-04-14 14:08 ` Ricardo Cañuelo 0 siblings, 1 reply; 3+ messages in thread From: Linux regression tracking (Thorsten Leemhuis) @ 2023-04-14 14:04 UTC (permalink / raw) To: Florian Fainelli, Rafał Miłecki, Ricardo Cañuelo, Rafał Miłecki Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Arnd Bergmann, netdev, bcm-kernel-feedback-list, Jon Mason, Linux kernel regressions list On 05.04.23 14:42, Florian Fainelli wrote: > On 4/4/2023 6:52 AM, Rafał Miłecki wrote: >> On 4.04.2023 15:46, Ricardo Cañuelo wrote: >>> On mar 07-02-2023 23:53:27, Rafał Miłecki wrote: >>>> While bringing hardware up we should perform a full reset including the >>>> switch bit (BGMAC_BCMA_IOCTL_SW_RESET aka SICF_SWRST). It's what >>>> specification says and what reference driver does. >>>> >>>> This seems to be critical for the BCM5358. Without this hardware >>>> doesn't >>>> get initialized properly and doesn't seem to transmit or receive any >>>> packets. >>>> >>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> >>> >>> KernelCI found this patch causes a regression in the >>> bootrr.deferred-probe-empty test [1] on sun8i-h3-libretech-all-h3-cc >>> [2], see the bisection report for more details [3] >>> >>> Does it make sense to you? >> >> It doesn't seem to make any sense. I guess that on your platform >> /sys/kernel/debug/devices_deferred >> is not empty anymore? >> >> Does your platform use Broadcom Ethernet controller at all? > > I do not believe it does, however according to the log, the driver is > enabled: > > <6>[ 1.819466] bgmac_bcma: Broadcom 47xx GBit MAC driver loaded > > but it should not be probing any device since you don't have any > internal BCMA bus to match gigabit devices with. Later in the log we see: > > 1c22c00.codec sun4i-codec: Failed to register our card > > and most likely as you already wrote the deferred device list might not > be empty. What happened to this? It seems there wasn't any progress since above mail week. But well, seems to be a odd issue anyway (is that one of those issues that CI systems find, but don't cause practical issues in the field?). Hence: can somebody with more knowledge about this please tell if it this is something I can likely drop from the list of tacked regressions? Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page. #regzbot poke ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] bgmac: fix *initial* chip reset to support BCM5358 2023-04-14 14:04 ` [PATCH net] bgmac: fix *initial* chip reset to support BCM5358 Linux regression tracking (Thorsten Leemhuis) @ 2023-04-14 14:08 ` Ricardo Cañuelo 2023-04-14 14:12 ` Linux regression tracking #update (Thorsten Leemhuis) 0 siblings, 1 reply; 3+ messages in thread From: Ricardo Cañuelo @ 2023-04-14 14:08 UTC (permalink / raw) To: Linux regressions mailing list, Florian Fainelli, Rafał Miłecki, Rafał Miłecki Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Arnd Bergmann, netdev, bcm-kernel-feedback-list, Jon Mason Hi Thorsten, On 14/4/23 16:04, Linux regression tracking (Thorsten Leemhuis) wrote: > What happened to this? It seems there wasn't any progress since above > mail week. But well, seems to be a odd issue anyway (is that one of > those issues that CI systems find, but don't cause practical issues in > the field?). Hence: can somebody with more knowledge about this please > tell if it this is something I can likely drop from the list of tacked > regressions? From Rafał's answer, I think we can consider this a false positive and move on. Cheers, Ricardo ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] bgmac: fix *initial* chip reset to support BCM5358 2023-04-14 14:08 ` Ricardo Cañuelo @ 2023-04-14 14:12 ` Linux regression tracking #update (Thorsten Leemhuis) 0 siblings, 0 replies; 3+ messages in thread From: Linux regression tracking #update (Thorsten Leemhuis) @ 2023-04-14 14:12 UTC (permalink / raw) To: Ricardo Cañuelo, Linux regressions mailing list, Florian Fainelli, Rafał Miłecki, Rafał Miłecki Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Arnd Bergmann, netdev, bcm-kernel-feedback-list, Jon Mason On 14.04.23 16:08, Ricardo Cañuelo wrote: > Hi Thorsten, > > On 14/4/23 16:04, Linux regression tracking (Thorsten Leemhuis) wrote: >> What happened to this? It seems there wasn't any progress since above >> mail week. But well, seems to be a odd issue anyway (is that one of >> those issues that CI systems find, but don't cause practical issues in >> the field?). Hence: can somebody with more knowledge about this please >> tell if it this is something I can likely drop from the list of tacked >> regressions? > > From Rafał's answer, I think we can consider this a false positive and > move on. great, thx for confirming! #regzbot inconclusive: CI false positive #regzbot ignore-activity Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr That page also explains what to do if mails like this annoy you. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-14 14:12 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20230227091156.19509-1-zajec5@gmail.com> [not found] ` <20230404134613.wtikjp6v63isofoc@rcn-XPS-13-9305> [not found] ` <002c1f96-b82f-6be7-2530-68c5ae1d962d@milecki.pl> [not found] ` <b7b11a57-9512-cda9-1b15-5dd5aa12f162@gmail.com> 2023-04-14 14:04 ` [PATCH net] bgmac: fix *initial* chip reset to support BCM5358 Linux regression tracking (Thorsten Leemhuis) 2023-04-14 14:08 ` Ricardo Cañuelo 2023-04-14 14:12 ` Linux regression tracking #update (Thorsten Leemhuis)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).