* [PATCH libselinux] libselinux/src/Makefile: don't pass bogus -I and -L to python setup.py build_ext
@ 2019-10-25 13:41 Thomas Petazzoni
2019-11-01 9:22 ` Nicolas Iooss
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2019-10-25 13:41 UTC (permalink / raw)
To: selinux; +Cc: Thomas Petazzoni
Using $(DESTDIR) during the build does not follow the normal/standard
semantic of DESTDIR: it is normally only needed during the
installation. Therefore, a lot of build systems/environments don't
pass any DESTDIR at build time, which causes setup.py to be called
with -I /usr/include -L /usr/lib, which breaks cross-compilation.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
libselinux/src/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile
index 2b1696a0..3b8bad81 100644
--- a/libselinux/src/Makefile
+++ b/libselinux/src/Makefile
@@ -130,7 +130,7 @@ SWIGRUBY = swig -Wall -ruby -o $(SWIGRUBYCOUT) -outdir ./ $(DISABLE_FLAGS)
all: $(LIBA) $(LIBSO) $(LIBPC)
pywrap: all selinuxswig_python_exception.i
- CFLAGS="$(CFLAGS) $(SWIG_CFLAGS)" $(PYTHON) setup.py build_ext -I $(DESTDIR)$(INCLUDEDIR) -L $(DESTDIR)$(LIBDIR)
+ CFLAGS="$(CFLAGS) $(SWIG_CFLAGS)" $(PYTHON) setup.py build_ext
rubywrap: all $(SWIGRUBYSO)
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH libselinux] libselinux/src/Makefile: don't pass bogus -I and -L to python setup.py build_ext
2019-10-25 13:41 [PATCH libselinux] libselinux/src/Makefile: don't pass bogus -I and -L to python setup.py build_ext Thomas Petazzoni
@ 2019-11-01 9:22 ` Nicolas Iooss
2019-11-02 17:23 ` Nicolas Iooss
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Iooss @ 2019-11-01 9:22 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: SElinux list
On Fri, Oct 25, 2019 at 3:42 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Using $(DESTDIR) during the build does not follow the normal/standard
> semantic of DESTDIR: it is normally only needed during the
> installation. Therefore, a lot of build systems/environments don't
> pass any DESTDIR at build time, which causes setup.py to be called
> with -I /usr/include -L /usr/lib, which breaks cross-compilation.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
This patch looks good to me. It does not seem to break the build
configurations that I am using and fixes a real issue. If nobody
complains, I will merge it (without the 2 other patches) tomorrow.
Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
Thanks!
> ---
> libselinux/src/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile
> index 2b1696a0..3b8bad81 100644
> --- a/libselinux/src/Makefile
> +++ b/libselinux/src/Makefile
> @@ -130,7 +130,7 @@ SWIGRUBY = swig -Wall -ruby -o $(SWIGRUBYCOUT) -outdir ./ $(DISABLE_FLAGS)
> all: $(LIBA) $(LIBSO) $(LIBPC)
>
> pywrap: all selinuxswig_python_exception.i
> - CFLAGS="$(CFLAGS) $(SWIG_CFLAGS)" $(PYTHON) setup.py build_ext -I $(DESTDIR)$(INCLUDEDIR) -L $(DESTDIR)$(LIBDIR)
> + CFLAGS="$(CFLAGS) $(SWIG_CFLAGS)" $(PYTHON) setup.py build_ext
>
> rubywrap: all $(SWIGRUBYSO)
>
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH libselinux] libselinux/src/Makefile: don't pass bogus -I and -L to python setup.py build_ext
2019-11-01 9:22 ` Nicolas Iooss
@ 2019-11-02 17:23 ` Nicolas Iooss
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Iooss @ 2019-11-02 17:23 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: SElinux list
On Fri, Nov 1, 2019 at 10:22 AM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
>
> On Fri, Oct 25, 2019 at 3:42 PM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> >
> > Using $(DESTDIR) during the build does not follow the normal/standard
> > semantic of DESTDIR: it is normally only needed during the
> > installation. Therefore, a lot of build systems/environments don't
> > pass any DESTDIR at build time, which causes setup.py to be called
> > with -I /usr/include -L /usr/lib, which breaks cross-compilation.
> >
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> This patch looks good to me. It does not seem to break the build
> configurations that I am using and fixes a real issue. If nobody
> complains, I will merge it (without the 2 other patches) tomorrow.
>
> Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
>
> Thanks!
Applied.
Nicolas
> > ---
> > libselinux/src/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile
> > index 2b1696a0..3b8bad81 100644
> > --- a/libselinux/src/Makefile
> > +++ b/libselinux/src/Makefile
> > @@ -130,7 +130,7 @@ SWIGRUBY = swig -Wall -ruby -o $(SWIGRUBYCOUT) -outdir ./ $(DISABLE_FLAGS)
> > all: $(LIBA) $(LIBSO) $(LIBPC)
> >
> > pywrap: all selinuxswig_python_exception.i
> > - CFLAGS="$(CFLAGS) $(SWIG_CFLAGS)" $(PYTHON) setup.py build_ext -I $(DESTDIR)$(INCLUDEDIR) -L $(DESTDIR)$(LIBDIR)
> > + CFLAGS="$(CFLAGS) $(SWIG_CFLAGS)" $(PYTHON) setup.py build_ext
> >
> > rubywrap: all $(SWIGRUBYSO)
> >
> > --
> > 2.21.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-02 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 13:41 [PATCH libselinux] libselinux/src/Makefile: don't pass bogus -I and -L to python setup.py build_ext Thomas Petazzoni
2019-11-01 9:22 ` Nicolas Iooss
2019-11-02 17:23 ` Nicolas Iooss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).