From: Stephen Smalley <sds@tycho.nsa.gov>
To: Paul Moore <paul@paul-moore.com>
Cc: Richard Haines <richard_c_haines@btinternet.com>,
selinux@vger.kernel.org, Ondrej Mosnacek <omosnace@redhat.com>
Subject: Re: [PATCH 2/2] selinux-testsuite: Add fs*(2) API filesystem tests
Date: Fri, 24 Jan 2020 14:25:56 -0500 [thread overview]
Message-ID: <693e8b96-32a6-6854-eb12-cff93f470ae4@tycho.nsa.gov> (raw)
In-Reply-To: <CAHC9VhTkhrdTPfhBMD=tBqVbCZBGdQS+fPHO1y4k79-CQrAPiw@mail.gmail.com>
On 1/24/20 2:17 PM, Paul Moore wrote:
> On Fri, Jan 24, 2020 at 10:12 AM Stephen Smalley <sds@tycho.nsa.gov> wrote:
>> On 1/20/20 6:11 AM, Richard Haines wrote:
>>> Test filesystem permissions using the fsopen(2), fsconfig(2), fsmount(2),
>>> fspick(2) and fsmount(2) api's introduced in kernel 5.2.
>>>
>>> Also tests move_mount(2) using open_tree(2).
>>>
>>> These tests use common code from tests/filesystem.
>>>
>>> Signed-off-by: Richard Haines <richard_c_haines@btinternet.com>
>>
>> Only question I have is whether we want to enable the move_mount test
>> unconditionally and let it break on kernels with the regression. Otherwise,
>
> Historically we haven't broken the test suite for older kernels, but I
> will admit that testing older kernels is no longer a priority for me.
If it were a new permission, I'd agree that we definitely want it
conditional on the appropriate kernel version. Since it is a fix for a
regression in checking an existing permission, it wasn't as clear to me.
Won't matter for RHEL because the fs_filesystem tests are only enabled
for >= 5.2 since the new system calls weren't added until then, so none
of these tests will run on RHEL regardless. It would only show up on
Fedora kernels from 5.2 through 5.5 that don't have the fix back-ported.
next prev parent reply other threads:[~2020-01-24 19:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 11:11 [PATCH 0/2] selinux-testsuite: Add fs*(2) API filesystem tests Richard Haines
2020-01-20 11:11 ` [PATCH 1/2] selinux-testsuite: Prepare for adding fs*(2) API tests Richard Haines
2020-01-24 15:12 ` Stephen Smalley
2020-01-20 11:11 ` [PATCH 2/2] selinux-testsuite: Add fs*(2) API filesystem tests Richard Haines
2020-01-21 18:56 ` Stephen Smalley
2020-01-24 15:13 ` Stephen Smalley
2020-01-24 19:17 ` Paul Moore
2020-01-24 19:25 ` Stephen Smalley [this message]
2020-01-24 19:41 ` Ondrej Mosnacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=693e8b96-32a6-6854-eb12-cff93f470ae4@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=richard_c_haines@btinternet.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).